Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2327#issuecomment-55306364
I need to look this over still, but want to remove WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2327#discussion_r17438553
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -51,10 +51,12 @@ private[sql] abstract class BasicColumnAccessor
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2327#discussion_r17439088
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -295,8 +295,16 @@ class HiveQuerySuite extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2327#issuecomment-55308174
Nice speed ups. I think they might be even more pronounced when there are
multiple threads fighting for the GC.
Minor comments only. Will merge after
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2226#issuecomment-55310313
@liancheng has a few more style suggestions then we will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1846#issuecomment-55310967
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2345#discussion_r17452614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -47,6 +48,53 @@ object Optimizer extends RuleExecutor
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55336553
LGTM to me once the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17453165
--- Diff: .gitignore ---
@@ -19,6 +19,7 @@ conf/spark-env.sh
conf/streaming-env.sh
conf/log4j.properties
conf/spark-defaults.conf
+conf
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55337715
This looks pretty awesome! I'd like to do a quick pass and make sure there
aren't any missing places, but overall this looks complete to me. Is there a
reason the PR
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2364#issuecomment-55337901
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55348969
Thanks! I've merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2352#issuecomment-55442596
Thanks for finding this! I've merge to master and 1.1 and 1.0.
@JoshRosen I think this should fix the Jenkins errors. Please let me know
if SQL is responsible
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2367#discussion_r17497519
--- Diff: docs/sql-programming-guide.md ---
@@ -1110,7 +1109,7 @@ evaluated by the SQL execution engine. A full list
of the functions supported c
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2367#discussion_r17497864
--- Diff: docs/sql-programming-guide.md ---
@@ -1110,7 +1109,7 @@ evaluated by the SQL execution engine. A full list
of the functions supported c
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2375#issuecomment-55480184
Thanks! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2327#discussion_r17513542
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -295,8 +295,16 @@ class HiveQuerySuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17513558
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -51,13 +51,13 @@ private[hive] abstract class HiveFunctionRegistry
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17513564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55502187
Thanks for fixing this! While I think eliminating the problem is great, it
also seems like a bug to me that casting a timestamp to a timestamp throws an
exception
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513645
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -181,6 +182,12 @@ class SqlParser extends StandardTokenParsers
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -181,6 +182,12 @@ class SqlParser extends StandardTokenParsers
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,24 @@ case class DescribeCommand(child: SparkPlan, output
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513661
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,24 @@ case class DescribeCommand(child: SparkPlan, output
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,24 @@ case class DescribeCommand(child: SparkPlan, output
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513664
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -119,4 +119,20 @@ class CachedTableSuite extends QueryTest
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513670
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -214,6 +214,7 @@ private[hive] object HiveQl {
*/
def getAst
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513672
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -233,7 +234,7 @@ private[hive] object HiveQl {
} else
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513682
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -263,6 +262,19 @@ private[hive] object HiveQl
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17513680
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -243,14 +244,12 @@ private[hive] object HiveQl {
} else
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2381#issuecomment-55502894
Thanks for working on this! A few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/2382
[SPARK-3414][SQL] Replace LowerCaseSchema with Resolver
_This PR is a follow up to #2293 (and to a lesser extent #2262 #2334)._
In #2293 the catalog was changed to store analyzed logical
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55503844
/cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55503862
/cc @ericl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2377#issuecomment-55504372
Thanks! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2367#issuecomment-55504402
Thanks! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55504491
SQL LGTM.
@JoshRosen is this ready to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2327#issuecomment-55508421
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2209#issuecomment-55509530
@JoshRosen I am hoping that #2164 will fix the test time outs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2164#issuecomment-55509834
I'm going to merge this to avoid more test timeouts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2354#issuecomment-55510095
Failed due to flakey streaming test `recovery with file input stream ***
FAILED ***`.
/cc @tdas
---
If your project is set up for it, you can reply
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/2384
[SQL][DOCS] Improve section on thrift-server
Taken from @liancheng's updates. Merged conflicts with #2316.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2384#issuecomment-55513917
Looks like another streaming failure:
```scala
[info] - Success with ack *** FAILED ***
[info] 4000 did not equal 5000 (SparkSinkSuite.scala:195
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17524775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17525906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17562464
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2397#issuecomment-55783349
I agree with making it lazy. Can you also update the title and the
description to reflect the final syntax?
---
If your project is set up for it, you can reply
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17619067
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -632,6 +632,12 @@ class HiveQuerySuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17619745
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -244,18 +244,22 @@ case class Cast(child: Expression
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2392#issuecomment-55788147
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-55788087
Minor style suggestion, otherwise LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2400#issuecomment-55788313
Oh wow, this was easier/cleaner than I expected. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2407#issuecomment-55788762
We may need to coordinate this with #2241, but otherwise I agree this is
much cleaner than before. Thanks for looking into this!
---
If your project is set up
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2392#issuecomment-55789138
Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17620241
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17620453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/package.scala
---
@@ -22,4 +22,9 @@ package org.apache.spark.sql.catalyst
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17620503
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -98,12 +98,12 @@ case class Star(
override def
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2209#issuecomment-55792642
Merged to master. Thanks for looking this over!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55793191
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17622161
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2384#issuecomment-55794220
Merged to master and 1.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17622320
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -246,6 +246,7 @@ object HiveMetastoreTypes extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2407#issuecomment-55794888
Can you maybe change the title to something like `... Use
GenericUDFUtils.ConversionHelper for Simple UDF type conversions`?
---
If your project is set up for it, you
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2252#issuecomment-55797114
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55797286
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2252#issuecomment-55800318
Good comparison @nchammas, It odes not look like this implementation
currently preserves the input type or supports decimal.
---
If your project is set up for it, you
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55931582
Yeah, thanks for working on this! :) What do you think about making a dummy
commit in this PR that changes SQL to make sure everything tests as expected?
You can
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55941569
oh hmmm, I guess its also okay to do a dummy follow up PR to make sure
things are working.
@rxin do you have a second to look this over? I think its mostly
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/2434
[SQL][DOCS] Improve table caching section
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark patch-1
Alternatively you can review
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55948936
@pwendell @JoshRosen FYI, I'm going to merge this. I'll try and watch
jenkins to see if anything breaks.
---
If your project is set up for it, you can reply
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55957213
Can you just make a follow up PR with the change? I don' think we have
permission to reopen things and we can't roll back merges in apache only add
new commits
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55968474
Merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990116
Overall I think this is better, thanks! One minor issue is that
`hive-thriftserver` is missing from the SQL tests (Sorry, I think I left this
out when you asked
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990548
One minor issue is that hive-thriftserver is missing from the SQL tests
No problem. Just give me an updated list of arguments to pass to sbt when
you just
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805241
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -170,13 +171,14 @@ class HiveContext(sc: SparkContext) extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805302
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -292,24 +294,20 @@ class HiveContext(sc: SparkContext) extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805365
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -59,7 +60,7 @@ private[hive] class HiveMetastoreCatalog(hive
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805395
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -39,6 +38,8 @@ import
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805441
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -212,7 +214,13 @@ private[hive] object HiveQl {
/**
* Returns
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805479
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala
---
@@ -77,7 +78,7 @@ class TestHiveContext(sc: SparkContext) extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805505
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -23,7 +23,7 @@ import org.apache.hadoop.hive.common.`type
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805519
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -35,6 +35,7 @@ import org.apache.spark.sql.catalyst.types
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805523
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -71,14 +72,14 @@ case class HiveTableScan(
Cast
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805581
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -71,14 +72,14 @@ case class HiveTableScan(
Cast
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805610
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -40,6 +39,9 @@ import org.apache.spark.rdd.RDD
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805665
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -110,7 +109,8 @@ private[hive] case class
HiveSimpleUdf(functionClassName
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805714
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -79,9 +80,9 @@ class StatisticsSuite extends QueryTest
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805760
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -511,11 +512,14 @@ class HiveQuerySuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17805768
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -511,11 +512,14 @@ class HiveQuerySuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17806062
--- Diff:
sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17806162
--- Diff:
sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17806225
--- Diff:
sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17812765
--- Diff:
sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17812784
--- Diff:
sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17812813
--- Diff:
sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17812859
--- Diff:
sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r17812902
--- Diff:
sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2241#issuecomment-56243807
Hi @zhzhan, thanks for working on this! and sorry that I took me a while
to look at it. I made several comments inline.
I'll let @pwendell comment
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2368#issuecomment-56244170
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2397#issuecomment-56244356
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
1 - 100 of 6629 matches
Mail list logo
