Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5400#discussion_r31728134
--- Diff:
network/common/src/main/java/org/apache/spark/network/buffer/LargeByteBuffer.java
---
@@ -0,0 +1,135 @@
+/*
+* Licensed to the Apache
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5400#discussion_r31688086
--- Diff:
network/common/src/main/java/org/apache/spark/network/buffer/LargeByteBufferHelper.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110477498
@massie my sailing lingo is pretty rusty, but I'll try to keep it going --
the PR's telltales are smoothly streaming aft now
---
If your project is set up for it, you
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6545#issuecomment-110477739
Jenkins, this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6627#discussion_r32067595
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala ---
@@ -27,7 +27,7 @@ import scala.language.reflectiveCalls
import
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6627#issuecomment-110514359
code changes lgtm. I'm a little concerned about the dependency issues, but
I'm not sure what to do about it
---
If your project is set up for it, you can reply
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6702#issuecomment-110518176
should we add some tests in `BlockManagerSuite` to prevent future
regressions? There is already a test removing block, but it doesn't check
that the blocks are actually
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6627#discussion_r32068173
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala ---
@@ -19,15 +19,27 @@ package org.apache.spark.sql.hive
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32081635
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -17,23 +17,23 @@
package org.apache.spark.storage
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32081958
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -17,9 +17,10 @@
package org.apache.spark.shuffle.hash
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32013943
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110364223
thanks @massie. That makes more sense now -- in fact I should have seen
the jira had a link to https://issues.apache.org/jira/browse/SPARK-7263 , my
mistake
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6205#discussion_r33064341
--- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala ---
@@ -182,3 +184,109 @@ private[spark] object RpcAddress {
RpcAddress(host, port
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6205#discussion_r33063832
--- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala ---
@@ -162,9 +163,15 @@ abstract class RpcEnvSuite extends SparkFunSuite
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6545#issuecomment-114570582
sorry for the delay, I'm just looking at this again. @steveloughran I want
to make sure I understand what you are proposing -- that fix would be totally
independent
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-114572521
ping @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-114608397
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-114620735
shoot, those mima failures are real ... looks like `RpcUtils` is public
(probably accidentally) so we can't change the return type of `lookupTimeout`
and `askTimeout
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33075440
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,59 @@ class DAGSchedulerSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33078052
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -305,7 +305,7 @@ private[spark] class MapOutputTrackerMaster(conf:
SparkConf
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33077937
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1193,8 +1193,10 @@ class DAGScheduler(
// TODO
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33081062
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,59 @@ class DAGSchedulerSuite
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6917#issuecomment-114612295
hey @andrewor14 is this the same as
https://issues.apache.org/jira/browse/SPARK-4746? I dropped this PR b/c it
seemed there was no interest: https://github.com/apache
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33095319
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,59 @@ class DAGSchedulerSuite
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4055#issuecomment-114653145
@suyanNone I think the problem w/ the test case as-is, is that you are
still having multiple completion events for the exact same task, which we
doesn't really happen
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6973#issuecomment-115370523
hmm, now I am a little confused -- that test actually passes even without
your changes. Sorry this may have been my fault for suggesting a test in
`SparkContextSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6973#discussion_r33295521
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -90,39 +92,47 @@ class SparkEnv (
private var driverTmpDirToDelete: Option[String
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6990#discussion_r33254453
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfo.scala ---
@@ -70,6 +70,11 @@ private[storage] class BlockInfo(val level:
StorageLevel, val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6990#discussion_r33255398
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -833,8 +833,10 @@ private[spark] class BlockManager(
logDebug(Put
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33256599
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1264,7 +1266,8 @@ class DAGScheduler(
* Aborts all jobs depending
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33256629
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1281,8 +1284,9 @@ class DAGScheduler(
}
/** Fails
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33256565
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1155,7 +1156,8 @@ class DAGScheduler(
case commitDenied
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33257058
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -662,6 +662,7 @@ private[spark] class TaskSetManager(
val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33255869
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -745,8 +745,9 @@ class DAGScheduler(
submitWaitingStages
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r3325
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/DAGSchedulerEvent.scala ---
@@ -74,6 +74,7 @@ private[scheduler] case class ExecutorAdded(execId
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6990#discussion_r33307046
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -833,8 +833,10 @@ private[spark] class BlockManager(
logDebug(Put
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33266312
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -20,9 +20,12 @@ package org.apache.spark
import
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33257851
--- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala ---
@@ -139,5 +139,32 @@ class FailureSuite extends SparkFunSuite with
LocalSparkContext
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33267940
--- Diff:
core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7004#issuecomment-115295063
Hi @JDrit I left a few comments on the code. I know this is still a WIP,
so I didn't go through very detailed, but there are some style and scoping
(more things should
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7014#issuecomment-115270287
@tomwhite this looks great! thanks so much for working on this, I think it
will be a really good addition. I left some minor style comments in addition
to the ones
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33266254
--- Diff: core/pom.xml ---
@@ -398,6 +398,41 @@
artifactIdpy4j/artifactId
version0.8.2.1/version
/dependency
+dependency
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6973#discussion_r33265121
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -272,4 +273,24 @@ class SparkContextSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33257390
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -728,16 +730,16 @@ private[spark] class TaskSetManager
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7004#issuecomment-115288920
Jenkins, this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33267979
--- Diff:
core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33268046
--- Diff:
core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33274057
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33273406
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33273664
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33275843
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7004#discussion_r33278696
--- Diff:
core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33276076
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
---
@@ -191,13 +194,24 @@ private[spark] class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33276680
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33274518
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -66,6 +65,9 @@ private[spark] class
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-115322472
I left a handful of minor comments, but overall looks good. I'll defer to
@tnachen on the correctness of the mesos interaction. My one concern is about
testing
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7004#issuecomment-115328079
One high-level question -- if a user does *not* call
`SparkConf.registerAvroSchema`, this will still write the schema with every
record, correct? The only potential
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33273309
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33274248
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7023#discussion_r33286297
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -784,6 +784,37 @@ class DAGSchedulerSuite
assert
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7023#issuecomment-115350486
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7028#issuecomment-115413847
This will be great to add that to the exception msg, the current Driver
stacktrace is not very useful. But, I think just munging it with the existing
stack trace might
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-115415052
@BryanCutler good catch, I'm glad you found that!
and +1 to `-Yno-adapted-args` (or `-Ywarn-adapted-args`) @zsxwing , I
think auto-tupling is just a source
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7028#issuecomment-115466021
OK, I took a closer look at the the way the exception handling works and I
see what you mean. I'm not particularly tied to that formatting I suggested,
that was just
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6917#discussion_r33146259
--- Diff: dev/run-tests.py ---
@@ -639,32 +651,47 @@ def detect_binary_inop_with_mima():
run_cmd([os.path.join(SPARK_HOME, dev, mima
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4055#issuecomment-113285019
I think its actually a real test failure -- ignore late map task
completions in DAGSchedulerSuite was failing for me when run locally as well.
---
If your project
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r32778875
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,49 @@ class DAGSchedulerSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r32778983
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,49 @@ class DAGSchedulerSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r32781070
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,49 @@ class DAGSchedulerSuite
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6935#issuecomment-115742256
@steveloughran @XuTingjun sorry I finally took a closer look here. So I
tried running a manual test on this patch and
https://github.com/apache/spark/pull/6545
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33360109
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1264,7 +1267,10 @@ class DAGScheduler(
* Aborts all jobs depending
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33360179
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -47,7 +47,10 @@ class FakeDAGScheduler(sc: SparkContext
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6752#issuecomment-115695061
thanks @vanzin , merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-115758383
@ankurcha I don't have any strong feelings on the workload -- I just wanted
to test basic executor allocation with just 2 slaves, the workload doesn't
really matter
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33373176
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -17,15 +17,18 @@
package
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-115703939
Hi @ankurcha thanks for updating. I just left a few more teeny tiny
comments. (I think you might have missed one comment I made about a variable
being `private
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33359186
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +88,103 @@ private[mesos] trait
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33358001
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -17,15 +17,17 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33358059
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -66,6 +65,9 @@ private[spark] class
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7014#issuecomment-115708177
a couple of minor comments, aside from that just waiting to see if the
tests pass
---
If your project is set up for it, you can reply to this email and have your
reply
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33358265
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33358278
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33359952
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -17,7 +17,7 @@
package org.apache.spark.executor
-import
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7023#discussion_r33375326
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -784,6 +784,37 @@ class DAGSchedulerSuite
assert
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-115776638
@BryanCutler yes, changing compiler options should definitely be handled as
a separate issue, not as part of this PR. sorry I should have been more clear
about that, I
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33373060
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -17,15 +17,18 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6990#discussion_r33398416
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -833,8 +833,10 @@ private[spark] class BlockManager(
logDebug(Put
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r32781253
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,49 @@ class DAGSchedulerSuite
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4055#issuecomment-113297759
Hi @suyanNone I'm still trying to understand this. Your high-level
description of the problem makes sense, but I'm confused by the test case. I
put in a few comments
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6205#discussion_r33107889
--- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala ---
@@ -182,3 +184,109 @@ private[spark] object RpcAddress {
RpcAddress(host, port
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6990#discussion_r33184610
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -834,7 +837,9 @@ private[spark] class BlockManager(
// Either
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5400#issuecomment-114977357
ping @tgravescs
btw, another design issue that was brought up earlier was whether we should
just limit each block to never exceed 2GB, and just have
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6973#issuecomment-114979266
Hi @rekhajoshm
The PR look reasonable (with the suggested changes from andrew). Could you
also (a) change the title / description to be a more descriptive, eg
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-115838890
thanks for all the updates @ankurcha ! This lgtm. @tnachen do you mind
doing another pass and commenting on appropriate workload?
I'll leave this open for more
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6935#issuecomment-115849879
sorry I didn't see that comment about the tests ... I wrote something up
which mimics the existing `UISeleniumSuite`.
```scala
From
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33385404
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -17,15 +17,18 @@
package
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/6750
[SPARK-8103][core] DAGScheduler should now submit multiple concurrent
attempts for a stage
https://issues.apache.org/jira/browse/SPARK-8103
cc @kayousterhout (thanks for the extra test case
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6750#issuecomment-110899669
(separate comment just to avoid putting this in the pr description for
eventual merging)
@kayousterhout I agree that your test is much clearer than running jobs
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/5964
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5964#issuecomment-110900021
closing, since I've broken this into separate prs -- thanks for the
comments everyone, would appreciate reviews of
https://github.com/apache/spark/pull/6648 and
https
401 - 500 of 3519 matches
Mail list logo
