Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17433682
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -396,19 +352,27 @@ trait ClientBase extends Logging
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2360#discussion_r17433769
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -21,12 +21,9 @@ import java.io.IOException
import
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17434531
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -45,120 +46,97 @@ class Client(clientArgs: ClientArguments, hadoopConf
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17434858
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -37,7 +35,10 @@ import org.apache.spark.deploy.SparkHadoopUtil
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17435086
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
---
@@ -84,7 +83,7 @@ class YarnSparkHadoopUtil extends
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2363#discussion_r17436782
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -220,8 +220,14 @@ class SparkContext(config: SparkConf) extends Logging
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2350#issuecomment-55311722
I'm kind of ok with making the Client class private, but the object needs
to stay public for backwards compatibility through spark-class.
---
If your project
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17449666
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
---
@@ -35,28 +34,57 @@ class ClientArguments(val args: Array
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2363#issuecomment-55348787
@andrewor14 what about my comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2363#issuecomment-55348917
To clarify I suggested possibly naming the config with .internal. In the
very least I think we should put a comment by it saying so in case other users
see it and add
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1279#discussion_r17459005
--- Diff:
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -81,6 +81,10 @@ class Client(clientArgs: ClientArguments, hadoopConf
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1279#issuecomment-55351694
Also note Kyle was intern at yahoo but has went back to school not sure if
he will have time to continue this. We can wait to see if he responds
---
If your project
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1279#discussion_r17459926
--- Diff:
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -81,6 +81,10 @@ class Client(clientArgs: ClientArguments, hadoopConf
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2218#issuecomment-55399971
+1, thanks @kramimus!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2363#issuecomment-55401587
@andrewor14 ok I filed https://issues.apache.org/jira/browse/SPARK-3508.
Please make sure all user concerns are addressed before committing. I would
have like to see
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-55405175
@vanzin this mostly looks good. I've been trying to run it locally but I
have been having lots of issues with the unit tests lately. Hopefully have
this done
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-55405196
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/154#discussion_r1748
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -273,7 +273,7 @@ trait ClientBase extends Logging
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/154#issuecomment-55407631
Note that this pr will also probably conflict with
https://github.com/apache/spark/pull/2350
---
If your project is set up for it, you can reply to this email and have
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1574#discussion_r17480411
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -224,6 +225,17 @@ trait ClientBase extends Logging
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1574#issuecomment-55408768
you mention only fixing this in core, have you tried looking at the others
and we can get some committers more familiar with that area to look it over?
---
If your
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1684#issuecomment-55408934
Note this is going to conflict with
https://github.com/apache/spark/pull/2350
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1934#issuecomment-55409179
@JoshRosen any other comments on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55409250
@sarutak can you please either upmerge or close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2363#issuecomment-55422201
@andrewor14 this seems to also be causing a compilation error on
branch-1.1:
core/src/main/scala/org/apache/spark/scheduler/cluster
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1934#issuecomment-55438132
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55447972
thanks, can you please also address my concerns in the comment above.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user tgravescs opened a pull request:
https://github.com/apache/spark/pull/2373
[SPARK-3456] YarnAllocator on alpha can lose container requests to RM
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgravescs/spark SPARK
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2373#issuecomment-55451089
cc @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2373#issuecomment-55453723
yeah no big deal, I should have seen this in testing it originally.
unfortunately the alpha doesn't use the AMRMClient api which handles adding
them
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2373#discussion_r17503861
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -121,7 +124,7 @@ private[yarn] abstract class YarnAllocator
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-55465007
@pwendell see the comments above:
They take about 1min to run on my machine. Most of the time is setting up
and tearing down the MiniYARNCluster instance
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2373#discussion_r17507134
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -121,7 +124,7 @@ private[yarn] abstract class YarnAllocator
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2283#discussion_r17511949
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -107,8 +103,11 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2320#issuecomment-55588750
yes that is how it works in standalone mode and it will. The master,
workers, and all the applications/clients/drivers need to have the same shared
secret
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2283#issuecomment-55592767
+1 looks good. Thanks @sarutak
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2126#issuecomment-55797660
so it sounds like we should set the user to whoever we wan to access hdfs
when we launch the task then. There aren't any other side affects that will
cause
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2126#issuecomment-55887296
@jongyoul sorry I don't know what you mean by on Aug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2126#issuecomment-55892735
Ok, sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-55895625
@pwendell @andrewor14 Any concerns with the time on this? I know our
unit tests already take a long time to run but this doesn't seem to bad. I
think going
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2198#issuecomment-55895905
@sarutak it is going to be another day or 2 before I can get time to look
at this in detail.
---
If your project is set up for it, you can reply to this email
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2204#issuecomment-55910777
looks good. I tested it on hadoop 0.23 and it works also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2232#issuecomment-56042913
From the other pr we need to keep backwards compatibility for the env
variables, the configs should be fine. I believe this pr matches the behavior
described below
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1573#issuecomment-56044590
@renozhang can you address my comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17753562
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -417,41 +381,136 @@ trait ClientBase extends Logging
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1391#issuecomment-56174217
@mridulm any comments?
I'm ok with it if its a consistent problem for users. One thing we
definitely need to do is document it and possibly look at including
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17785127
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -37,154 +36,106 @@ import
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17786319
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -415,41 +381,153 @@ trait ClientBase extends Logging
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17786722
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientDistributedCacheManager.scala
---
@@ -19,29 +19,24 @@ package
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2350#issuecomment-56183509
This mostly looks good. A couple minor comments is all. I do also still
want to run through some tests on alpha.
---
If your project is set up for it, you can
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17788554
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -415,41 +381,153 @@ trait ClientBase extends Logging
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2198#discussion_r17803484
--- Diff: docs/running-on-yarn.md ---
@@ -50,6 +50,13 @@ Most of the configs are the same for Spark on YARN as
for other deployment modes
/td
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2198#issuecomment-56221633
How have you tested this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2311#issuecomment-56308622
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user tgravescs opened a pull request:
https://github.com/apache/spark/pull/2484
[SPARK-3632] ConnectionManager can run out of receive threads with
authentication on
If you turn authentication on and you are using a lot of executors. There
is a chance that all
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56371027
yes it would be nice to tell the user what the overhead limit is calculated
to be as I might not realize there is overhead and that its dependent upon the
multiplier
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1573#discussion_r17853745
--- Diff: docs/running-on-yarn.md ---
@@ -205,6 +205,8 @@ Note that for the first option, both executors and the
application master will s
log4j
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1573#issuecomment-56385141
thanks @renozhang, minor request about the documentation, otherwise looks
good.
---
If your project is set up for it, you can reply to this email and have your
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17861794
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -37,154 +36,106 @@ import
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2311#issuecomment-56408312
I've been having a multiple different issues with the success/failure
reporting (SPARK-3627). Does this handle all of those?
---
If your project is set up
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17868237
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -29,6 +29,7 @@ import org.apache.hadoop.yarn.api
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17882325
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -91,7 +94,11 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17884602
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -91,7 +94,11 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2484#issuecomment-56460598
@rxin I think you had looked at the connectionManager, any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2350#discussion_r17885897
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientDistributedCacheManager.scala
---
@@ -19,29 +19,24 @@ package
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2350#issuecomment-56460800
yes I had tested an earlier version and didn't find any issues. Let me
look at this tomorrow and i'll try it out again on this hopefully last version.
---
If your
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1573#issuecomment-56516302
testfailure is unrelated to this pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1573#issuecomment-56521585
+1 thanks @renozhang !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56526845
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56522491
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56532051
@JoshRosen Any idea why Jenkins isn't running on this? Could you kick it
manually?
---
If your project is set up for it, you can reply to this email and have your
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2350#issuecomment-56546944
ran through some tests on 0.23 and seems to be working fine. I'll commit
this.
Thanks @andrewor14 !
---
If your project is set up for it, you can reply
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2198#issuecomment-56550485
This looks good. Thanks @sarutak !
I made one small change at checkin to use getInt instead of getLong on the
config. It was also over 100 characters
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17940217
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -91,7 +94,11 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17951431
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -91,7 +94,11 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56706929
@pwendell @mateiz @andrewor14 can any of you kick jenkins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56707989
ah sorry, looks like something conflicts now and it needs upmerged.
@nishkamravi2 can you please upmerge
---
If your project is set up for it, you can reply
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56816028
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2528#issuecomment-56816905
Yeah changes look good if Jenkins passes. We now have a map and for loop a
single instance so we probably could condense it but not a big deal.
---
If your project
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2484#issuecomment-56816998
Thanks @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56818674
@JoshRosen would you mind kicking jenkins again now that its upmerged?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2528#issuecomment-56874196
yep, looks good. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2311#issuecomment-56910981
@witgo There are cases not covered by this pr that I would like to fix up
dealing with exit codes and final status. Would you mind if I just pull these
changes
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2311#issuecomment-56912131
also maybe I'm missing something but I don't see how the changes help in
yarn-client mode? The changes you made were on the application master running
on a separate
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-56979002
It seems a bit much to have 2 configs to do essentially same thing. I see
it leading to confusion and just extra overhead.
---
If your project is set up for it, you
GitHub user tgravescs opened a pull request:
https://github.com/apache/spark/pull/2577
[SPARK-3627] - [yarn] - fix exit code and final status reporting to RM
See the description and whats handled in the jira comment:
https://issues.apache.org/jira/browse/SPARK-3627?focusedCommentId
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57176392
@witgo can you verify this covers https://github.com/apache/spark/pull/2311
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57180050
sorry perhaps I'm missing something, why are we adding the value of
LD_LIBRARY_PATH to the java.library.path and not just using LD_LIBRARY_PATH
like proposed
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57185274
also note this does change everything to allow yarn to retry. previously
when it hit the maximum number of executor failures it didn't retry the AM. I
waffled back
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18173150
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -450,6 +539,15 @@ object ApplicationMaster extends
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18179848
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18180627
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18182939
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class ApplicationMaster
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2584#issuecomment-57239423
as I said on the jira, I don't really want to add a config to make the
Client api public because it shouldn't be used as programmatic interface at
this point
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2484#issuecomment-57313278
Thanks @rxin. I updated based on your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57313993
thanks for the review @vanzin. I've updated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57317439
I haven't looked at the code to fully understand what all changes would be
required and why its so much more complex. So if it makes the implementation
much simpler
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2579#discussion_r18217523
--- Diff: docs/running-on-yarn.md ---
@@ -181,7 +181,7 @@ In YARN terminology, executors and application masters
run inside containers.
yarn
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2485#issuecomment-57326448
@andrewor14 did you have any further comments on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18238788
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClientImpl.scala
---
@@ -66,14 +70,16 @@ private class YarnRMClientImpl(args
1 - 100 of 3229 matches
Mail list logo
