[GitHub] spark pull request: [SPARK-7008] An implement of Factorization Mac...

2015-04-20 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/5591 [SPARK-7008] An implement of Factorization Machines based on Scala and Spark MLlib. An implementation of Factorization Machines based on Scala and Spark MLlib. Factorization Machine

[GitHub] spark pull request: [SPARK-7008] An implement of Factorization Mac...

2015-05-04 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/5591#issuecomment-98899177 OK, please close it. On May 1, 2015, at 5:35 AM, Xiangrui Meng notificati...@github.com wrote: @zhengruifeng https://github.com/zhengruifeng

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 **[Test build #59997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59997/consoleFull)** for PR 13511 at commit [`652b9ef`](https://github.com/apache/spark

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59997/ Test PASSed

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13514: [SPARK-15770][ML] 'Experimental' annotation audit

2016-06-04 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13514 [SPARK-15770][ML] 'Experimental' annotation audit ## What changes were proposed in this pull request? 1, remove comments `:: Experimental ::` for non-experimental API 2, add comments

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 **[Test build #60002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60002/consoleFull)** for PR 13514 at commit [`42adf3f`](https://github.com/apache/spark

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13515 **[Test build #60005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60005/consoleFull)** for PR 13515 at commit [`77d3486`](https://github.com/apache/spark

[GitHub] spark issue #13514: [SPARK-15770][ML] 'Experimental' annotation audit

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 **[Test build #60001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60001/consoleFull)** for PR 13514 at commit [`546987f`](https://github.com/apache/spark

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 **[Test build #60001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60001/consoleFull)** for PR 13514 at commit [`546987f`](https://github.com/apache/spark

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60001/ Test PASSed

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13515 [MINOR] Fix Typos 'an -> a' ## What changes were proposed in this pull request? `an -> a` Use cmds like `grep -in ' an [^aeiou]' yarn/src/main/scala/org/apache

[GitHub] spark pull request #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13515#discussion_r65814235 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -366,7 +366,7 @@ object SparkSubmit

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 **[Test build #60002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60002/consoleFull)** for PR 13514 at commit [`42adf3f`](https://github.com/apache/spark

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13514 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60002/ Test PASSed

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 ``` >>> from pyspark.mllib.evaluation import * >>> predictionAndLabels = sc.parallelize([(0.0, 0.0), (0.0, 1.0), (0.0, 0.0), (1.0, 0.0), (1.0, 1.0), (1.0, 1.0), (1.

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #13511: [SPARK-14900][ML][PySpark] Add accuracy and depre...

2016-06-04 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13511 [SPARK-14900][ML][PySpark] Add accuracy and deprecate precison,recall,f1 ## What changes were proposed in this pull request? 1, add accuracy for MulticlassMetrics 2, deprecate overall

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13515 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13515 **[Test build #60003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60003/consoleFull)** for PR 13515 at commit [`2531a5f`](https://github.com/apache/spark

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13515 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60003/ Test FAILed

[GitHub] spark pull request #13521: [SPARK-15770][CORE][SQL][ML] Annotation audit for...

2016-06-06 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13521 [SPARK-15770][CORE][SQL][ML] Annotation audit for Experimental and DeveloperApi 2 ## What changes were proposed in this pull request? 1, remove comments `:: Experimental ::` for non

[GitHub] spark pull request #13560: [SPARK-15823][PySpark][ML] Add @property for 'pro...

2016-06-08 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13560 [SPARK-15823][PySpark][ML] Add @property for 'property' in MulticlassMetrics ## What changes were proposed in this pull request? `accuracy` should be decorated with `@property` to keep

[GitHub] spark pull request #13560: [SPARK-15823][PySpark][ML] Add @property for 'acc...

2016-06-10 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13560#discussion_r66569553 --- Diff: python/pyspark/mllib/evaluation.py --- @@ -183,7 +183,7 @@ class MulticlassMetrics(JavaModelWrapper): 0.66

[GitHub] spark pull request #13390: [SPARK-15617][ML][DOC] Clarify that fMeasure in M...

2016-06-03 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13390#discussion_r65692163 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala --- @@ -39,16 +39,16 @@ class

[GitHub] spark pull request: [DO_NOT_MERGE][ML] Enable java save/load tests...

2016-05-28 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13376 [DO_NOT_MERGE][ML] Enable java save/load tests for ML ## What changes were proposed in this pull request? Because `SPARK-6725` is already Resolved, the `TODO` save/load tests depending

[GitHub] spark pull request #13657: [SPARK-15939][ML][PySpark] Clarify ml.linalg usag...

2016-06-14 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13657 [SPARK-15939][ML][PySpark] Clarify ml.linalg usage ## What changes were proposed in this pull request? 1, update comments in `pyspark.ml` that it use `ml.linalg` not `mllib.linalg` 2

[GitHub] spark issue #13519: [SPARK-15771] [ML] [Examples] Use 'accuracy' rather than...

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13519 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 **[Test build #59997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59997/consoleFull)** for PR 13511 at commit [`652b9ef`](https://github.com/apache/spark

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 @srowen It is just the local test code, please ignore it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13511: [SPARK-14900][ML][PySpark] Add accuracy and deprecate pr...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13511 Looks correct, what are you pointing out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13515 **[Test build #60003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60003/consoleFull)** for PR 13515 at commit [`2531a5f`](https://github.com/apache/spark

[GitHub] spark pull request #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13515#discussion_r6583 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -37,7 +37,7 @@ import

[GitHub] spark issue #13390: [SPARK-15617][ML][DOC] Clarify that fMeasure in Multicla...

2016-06-04 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13390 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-15617][ML][DOC] Clarify that fMeasure i...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13390#discussion_r65030639 --- Diff: docs/mllib-evaluation-metrics.md --- @@ -182,17 +183,22 @@ $$\hat{\delta}(x) = \begin{cases}1 & \text{if $x = 0$}, \\ 0 & \text{o

[GitHub] spark pull request: [SPARK-15650][ML] Add correctness test for Mul...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13398#discussion_r65046391 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluatorSuite.scala --- @@ -40,4 +41,51 @@ class

[GitHub] spark pull request: [SPARK-15650][ML] Add correctness test for Mul...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13398#issuecomment-222445158 cc @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15650][ML] Add correctness test for Mul...

2016-05-30 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13398 [SPARK-15650][ML] Add correctness test for MulticlassClassification ## What changes were proposed in this pull request? Add tests to verify the correctness

[GitHub] spark pull request: [SPARK-15617][ML][DOC] Clarify that fMeasure i...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13390#discussion_r65027076 --- Diff: docs/mllib-evaluation-metrics.md --- @@ -182,17 +183,22 @@ $$\hat{\delta}(x) = \begin{cases}1 & \text{if $x = 0$}, \\ 0 & \text{o

[GitHub] spark pull request: [SPARK-15617][ML][DOC] Clarify that fMeasure i...

2016-05-29 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13390 [SPARK-15617][ML][DOC] Clarify that fMeasure in MulticlassMetrics is "micro" f1_score ## What changes were proposed in this pull request? clarify that fMeasure in Multicl

[GitHub] spark pull request: [SPARK-15650][ML] Add correctness test for Mul...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13398#discussion_r65048853 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluatorSuite.scala --- @@ -40,4 +41,51 @@ class

[GitHub] spark pull request: [SPARK-15607][ML] Remove redundant toArray in ...

2016-05-27 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/13354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-15291][GraphX] Remove redundant operati...

2016-05-27 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/13075 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-15610][ML] PCA should not support k == ...

2016-05-27 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13356#issuecomment-77181 So I will just change the error message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15650][ML] Add correctness test for Mul...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/13398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-15650][ML] Add correctness test for Mul...

2016-05-30 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13398#discussion_r65077584 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluatorSuite.scala --- @@ -40,4 +41,51 @@ class

[GitHub] spark pull request: [SPARK-15607][ML] Remove redundant toArray in ...

2016-05-27 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13354 [SPARK-15607][ML] Remove redundant toArray in ml.linalg ## What changes were proposed in this pull request? `sliceInds, sliceVals` are already of type `Array`, so remove `toArray

[GitHub] spark pull request: [SPARK-15610][ML] PCA should not support k == ...

2016-05-27 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13356 [SPARK-15610][ML] PCA should not support k == numFeatures ## What changes were proposed in this pull request? Fix the wrong bound of `k` in `PCA` `require(k <= sources.first().s

[GitHub] spark pull request: [SPARK-15610][ML] PCA should not support k == ...

2016-05-27 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13356#issuecomment-222109494 cc @jkbradley @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14634][ML] Add BisectingKMeansSummary

2016-05-25 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/12394#issuecomment-221764870 cc @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13317#issuecomment-221795573 @holdenk Yes. I use cmd like this `grep -in ' a [aeiou]' mllib/src/main/scala/org/apache/spark/ml/*/*scala` to generate potential wrong lines. --- If your

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13317#issuecomment-221803163 @holdenk Thanks. Good night. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/13317 [MINOR] Fix Typos ## What changes were proposed in this pull request? `a` -> `an` ## How was this patch tested? local build You can me

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13317#issuecomment-221792040 @holdenk Thanks. I think you are right. I will revert `an one-xxx` to `a one-xxx`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13317#issuecomment-221801013 @holdenk Excuse me, How to deal with MiMa test failures? It seems caused by change in `core` --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13317#issuecomment-221790963 @holdenk Thanks. I have fixed this. and run `lint-java` to check java file. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13390: [SPARK-15617][ML][DOC] Clarify that fMeasure in Multicla...

2016-06-01 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13390 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-15617][ML][DOC] Clarify that fMeasure i...

2016-05-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/13390#issuecomment-222364467 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15617][ML][DOC] Clarify that fMeasure i...

2016-05-29 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13390#discussion_r65005147 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -153,7 +153,7 @@ class MulticlassMetrics @Since("

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-23 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11263#issuecomment-187644623 @mengxr Ok, I have fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11303 [SPARK-13435] [MLlib] Add Weighted Cohen's kappa to MulticlassMetrics JIRA: https://issues.apache.org/jira/browse/SPARK-13435 ## What changes were proposed in this pull request

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-23 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11303#issuecomment-187687258 @srowen yes, the style problem was caused by that the IJ's default 'reformating' style for scala dont match spark's. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-23 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53776227 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -211,4 +211,119 @@ class MulticlassMetrics @Since

[GitHub] spark pull request: [SPARK-13435] [MLlib] Fix the wrong parameter ...

2016-02-26 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11387 [SPARK-13435] [MLlib] Fix the wrong parameter in R code comment in AssociationRulesSuite ## What changes were proposed in this pull request? just chang R Snippet Comment

[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML

2016-02-28 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11419 [SPARK-13538][ML] Add GaussianMixture to ML JIRA: https://issues.apache.org/jira/browse/SPARK-13538 ## What changes were proposed in this pull request? Add GaussianMixture

[GitHub] spark pull request: [SPARK-13551] [MLLib] Fix wrong comment and re...

2016-02-29 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11429 [SPARK-13551] [MLLib] Fix wrong comment and remove meanless lines in mllib.JavaBisectingKMeansExample JIRA: https://issues.apache.org/jira/browse/SPARK-13551 ## What changes were

[GitHub] spark pull request: [SPARK-13550] [ML] Add java example for ml.clu...

2016-02-29 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11428 [SPARK-13550] [ML] Add java example for ml.clustering.BisectingKMeans JIRA: https://issues.apache.org/jira/browse/SPARK-13550 ## What changes were proposed in this pull request

[GitHub] spark pull request: [SPARK-13551] [MLLib] Fix wrong comment and re...

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11429#issuecomment-190117144 @srowen Sorry, but can I make a PR without JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-190159614 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-27 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11411 [SPARK-13385][MLlib] Enable AssociationRules to generate consequents with user-defined lengths JIRA: https://issues.apache.org/jira/browse/SPARK-13385 ## What changes were proposed

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-26 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/11263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-26 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11263#issuecomment-189584541 There is something wrong with my git operation. I will close this PR, and send another PR. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53736779 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -129,86 +135,199 @@ class MulticlassMetrics @Since

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53736887 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/evaluation/MulticlassMetricsSuite.scala --- @@ -51,6 +51,9 @@ class MulticlassMetricsSuite

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53726515 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -25,18 +25,19 @@ import org.apache.spark.rdd.RDD

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53727121 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -129,86 +135,199 @@ class MulticlassMetrics @Since

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53740489 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -129,86 +135,199 @@ class MulticlassMetrics @Since

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53740507 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -129,86 +135,199 @@ class MulticlassMetrics @Since

[GitHub] spark pull request: [SPARK-13435] [MLlib] Add Weighted Cohen's kap...

2016-02-22 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11303#discussion_r53741198 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -25,18 +25,19 @@ import org.apache.spark.rdd.RDD

[GitHub] spark pull request: https://issues.apache.org/jira/browse/SPARK-13...

2016-02-18 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11263 https://issues.apache.org/jira/browse/SPARK-13385 ## What changes were proposed in this pull request? Enable AssociationRules to generate consequents with user-defined lengths

[GitHub] spark pull request: [SPARK-13386][Graphx] ConnectedComponents shou...

2016-02-19 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11268 [SPARK-13386][Graphx] ConnectedComponents should support maxIteration option ## What changes were proposed in this pull request? add maxIteration option for ConnectedComponents

[GitHub] spark pull request: [SPARK-13386][GraphX] ConnectedComponents shou...

2016-02-19 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11268#discussion_r53542779 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala --- @@ -411,8 +411,8 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph: Graph

[GitHub] spark pull request: [SPARK-13386][GraphX] ConnectedComponents shou...

2016-02-19 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11268#discussion_r53544885 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/ConnectedComponents.scala --- @@ -29,13 +29,14 @@ object ConnectedComponents

[GitHub] spark pull request: [SPARK-13386][GraphX] ConnectedComponents shou...

2016-02-20 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11268#discussion_r53549798 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/ConnectedComponents.scala --- @@ -29,13 +29,14 @@ object ConnectedComponents

[GitHub] spark pull request: [SPARK-13416][GraphX] Add positive check for o...

2016-02-20 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11284 [SPARK-13416][GraphX] Add positive check for option 'numIter' in StronglyConnectedComponents JIRA: https://issues.apache.org/jira/browse/SPARK-13416 ## What changes were proposed

[GitHub] spark pull request: [SPARK-13416][GraphX] Add positive check for o...

2016-02-20 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/11284#discussion_r53562433 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/StronglyConnectedComponents.scala --- @@ -36,7 +36,7 @@ object StronglyConnectedComponents

[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-190486901 @sethah GaussianMixture is a kind of clustering algorithm, not classification. And ProbabilisticClassifier extend Predictor, so it has a "setLab

[GitHub] spark pull request: [SPARK-13550] [ML] Add java example for ml.clu...

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11428#issuecomment-190484554 @srowen this is the first java example for ml.clustering.BisectingKMeans --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11411#issuecomment-190507307 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-190507332 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13714][GraphX] Another ConnectedCompone...

2016-03-10 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/11556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [Minor][Core] Add nonEmpty to RDD and JavaRDD

2016-03-18 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/11823 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [Spark-13814][PySpark] Delete unnecessary impo...

2016-03-11 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11651#issuecomment-195254744 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [Spark-13814][PySpark] Delete unnecessary impo...

2016-03-10 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11651 [Spark-13814][PySpark] Delete unnecessary imports in python examples files JIRA: https://issues.apache.org/jira/browse/SPARK-13814 ## What changes were proposed in this pull request

[GitHub] spark pull request: [Spark-13814][PySpark] Delete unnecessary impo...

2016-03-10 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11651#issuecomment-195238849 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13816][Graphx] Add parameter checks for...

2016-03-11 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11655 [SPARK-13816][Graphx] Add parameter checks for algorithms in Graphx JIRA: https://issues.apache.org/jira/browse/SPARK-13816 ## What changes were proposed in this pull request

[GitHub] spark pull request: [Spark-13814][PySpark] Delete unnecessary impo...

2016-03-11 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11651#issuecomment-195252149 it sames something wrong in JavaMaxAbsScalerExample... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [Spark-13814][PySpark] Delete unnecessary impo...

2016-03-11 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11651#issuecomment-195265628 @srowen I think so, I have reviewed all python examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

  1   2   3   4   5   6   7   8   9   >