[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-12 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-111384430 ping... May AmplabJenkins test this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-07 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-109764220 ping.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-07 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/6551#discussion_r31886041 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -59,6 +59,32 @@ object HiveTypeCoercion

[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-07 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/6551#discussion_r31886263 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -39,6 +39,16 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/6551#discussion_r31798693 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -59,6 +59,42 @@ object HiveTypeCoercion

[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-109194778 @rxin @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8010][SQL]Promote numeric types to stri...

2015-06-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-109181623 @cloud-fan and @chenghao-intel Resolve conflicts and test suite passed locally. Would you mind to review this? --- If your project is set up

[GitHub] spark pull request: [SPARK-8010][SQL]Promote types to StringType a...

2015-06-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-109329059 @cloud-fan That's make sense, thanks. Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8010][SQL]Promote numeric types to stri...

2015-06-02 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-108021959 @cloud-fan and @chenghao-intel. Updated, Any more comments? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8010][SQL]Promote numeric types to stri...

2015-06-01 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-107399872 @chenghao-intel Could u please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-8010][SQL]Promote numeric types to stri...

2015-06-01 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/6551 [SPARK-8010][SQL]Promote numeric types to string type as implicit conversion in HiveTypeCoercion 1. Given a query `select coalesce(null, 1, '1') from dual` will cause exception

[GitHub] spark pull request: [SPARK-8010][SQL]Promote numeric types to stri...

2015-06-01 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/6551#issuecomment-107636869 Thanks, @cloud-fan and @chenghao-intel. I will update it tomorrow night. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-05-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4060#issuecomment-98597077 OK, Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-05-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/4060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-3298][SQL] Add `allowExisting` flag to ...

2015-03-18 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/4271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-3298][SQL] Add `allowExisting` flag to ...

2015-03-18 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4271#issuecomment-82779677 OK,closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5740] Change comment default value from...

2015-03-15 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4530#issuecomment-80892574 OK, closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5740] Change comment default value from...

2015-03-15 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/4530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-6285][SQL]Remove ParquetTestData in Spa...

2015-03-15 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/5032 [SPARK-6285][SQL]Remove ParquetTestData in SparkBuild.scala and in README.md This is a following clean up PR for #5010 This will resolve issues when launching `hive/console` like below

[GitHub] spark pull request: [SPARK-6285][SQL]Remove ParquetTestData in Spa...

2015-03-15 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/5032#issuecomment-80944151 ok, thanks @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SQL] Add fetched row count in SparkSQLCLIDriv...

2015-02-14 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4604 [SQL] Add fetched row count in SparkSQLCLIDriver before this change: ```scala Time taken: 0.619 seconds ``` after this change : ```scala Time taken: 0.619

[GitHub] spark pull request: [SPARK-5740] Change comment default value from...

2015-02-11 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4530#issuecomment-73995963 Sorry, didn't notice this before. Hive isn't even consistent across versions for this... I'd change the `default empty string` to `null

[GitHub] spark pull request: [SPARK-5740] Change comment default value from...

2015-02-11 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4530 [SPARK-5740] Change comment default value from null to None in DescribeCommand Just make this consistent with Hive. You can merge this pull request into a Git repository by running

[GitHub] spark pull request: [SPARK-5740] Change comment default value from...

2015-02-11 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4530#issuecomment-73859711 /cc @rxin @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL][Minor] correct some comments

2015-02-10 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4508 [SQL][Minor] correct some comments You can merge this pull request into a Git repository by running: $ git pull https://github.com/OopsOutOfMemory/spark cmt Alternatively you can

[GitHub] spark pull request: [SQL][Minor] correct some comments

2015-02-10 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4508#issuecomment-73816744 Thanks @srowen : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5651][SQL] Support db.table in Create T...

2015-02-09 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4473 [SPARK-5651][SQL] Support db.table in Create Table within backticks of HiveContext Support: ```scala create table `table_in_database_creation.test2` as select * from src limit 1

[GitHub] spark pull request: [SPARK-5651][SQL] Support create table `db.tab...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4427#discussion_r24334944 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -397,6 +397,13 @@ private[hive] object HiveQl { protected def

[GitHub] spark pull request: [SPARK-5651][SQL] Support create table `db.tab...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4427#discussion_r24335234 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -397,6 +397,13 @@ private[hive] object HiveQl { protected def

[GitHub] spark pull request: [SPARK-5651][SQL] Support create table `db.tab...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4427#issuecomment-73526018 @watermen You need to pass test the suite locally and make sure you can generate the golden file and then commit the files to the test server. Otherwise

[GitHub] spark pull request: [SPARK-5651][SQL] Support create table `db.tab...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4427#issuecomment-73637908 @yhuai Didn't notice this before, thanks. I think we'd better not change this, but only update the `input46.q`. Is that ok ? @watermen Maybe

[GitHub] spark pull request: [SPARK-5651][SQL] Update `input46.q` to be con...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4473#issuecomment-73638171 @watermen I think we only need to update the sql test tile is ok. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-5651][SQL] Update `input46.q` to be con...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4473#issuecomment-73638108 yes, I know it support because it's (db,tableName) case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-5651][SQL] Update `input46.q` to be con...

2015-02-09 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/4473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-5686][SQL] Add show current roles comma...

2015-02-09 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4471 [SPARK-5686][SQL] Add show current roles command in HiveQl You can merge this pull request into a Git repository by running: $ git pull https://github.com/OopsOutOfMemory/spark

[GitHub] spark pull request: [SPARK-5651][SQL] Support 'create db.table' in...

2015-02-08 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4427#issuecomment-73350429 @watermen Can you make sure this is now accepted by Hive trunk since this is a test file that `excluded` in hive testing in `Hivev0.13`. If it does

[GitHub] spark pull request: [SPARK-5651][SQL] Support 'create db.table' in...

2015-02-08 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4427#discussion_r24287128 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -397,6 +397,10 @@ private[hive] object HiveQl { protected def

[GitHub] spark pull request: [SPARK-4131][SQL][WIP] support writing data in...

2015-02-08 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4380#discussion_r24287310 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -48,6 +48,38 @@ import scala.collection.JavaConversions

[GitHub] spark pull request: [SPARK-5651][SQL] Support create table `db.tab...

2015-02-08 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4427#issuecomment-73409523 Would you like to add some test suites for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-02-06 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4060#issuecomment-73202418 yeah, I use a single logical operator here. If handle the type of the table and then delegate. Is that ok to do like below? we need catch exceptions

[GitHub] spark pull request: SPARK-4502 [SQL]

2015-02-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4398#issuecomment-73069398 you can do it like this: ` [SPARK-4502][SQL] Fix reads unnecessary nested fields from Parquet ` --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SQL][HiveConsole][DOC] HiveConsole `correct h...

2015-02-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4389#issuecomment-73072289 this exception is weird, seems no relation with my code. I test this suite `JavaAPISuite` locally, passed this suite test. Regression

[GitHub] spark pull request: [SPARK-5324][SQL] Results of describe can't be...

2015-02-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4249#issuecomment-73064648 @marmbrus is this ready to go ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe tab...

2015-02-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4227#issuecomment-73062533 Hi, @rxin Thanks for the advice. I refined the code according to your advice now I think it's ready to go. yeah, this PR is a little conflict

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4387#issuecomment-73176620 @pwendell @marmbrus @rxin Thanks for your comments that make me more clearly. And I import `sql()` function by default so we do not need write

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-05 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4387#issuecomment-73094427 @pwendell @rxin Here is my concern, sorry if I'm wrong. For Usage Level: Shall we not `automatically` provide `hiveContext` in spark shell even

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4060#discussion_r24102921 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala --- @@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe tab...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4227#issuecomment-72819162 May AmplabJenkins test this please ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4387#issuecomment-72999671 yep, @pwendell JIRA Name it is `shengli` Username: OopsOutOfMemory Full Name: shengli Email: victorshengli at 126 dot com Groups

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4387#discussion_r24145135 --- Diff: repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkILoop.scala --- @@ -1016,6 +1020,13 @@ class SparkILoop( sparkContext

[GitHub] spark pull request: [SQL][HiveConsole][DOC] HiveConsole `correct h...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4389#issuecomment-73002183 @rxin @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4387#discussion_r24145690 --- Diff: repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkILoop.scala --- @@ -1016,6 +1020,13 @@ class SparkILoop( sparkContext

[GitHub] spark pull request: [SQL][HiveConsole][DOC] HiveConsole `correct h...

2015-02-04 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4389 [SQL][HiveConsole][DOC] HiveConsole `correct hiveconsole imports` Sorry for that PR #4330 has some mistakes. I correct it so it works correctly now. You can merge this pull

[GitHub] spark pull request: [SPARK-5324][SQL] Results of describe can't be...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4249#issuecomment-72875605 /cc @marmbrus make the references as default argument. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-04 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4387 [SPARK-5586][Spark Shell][SQL] Make `sqlContext` available in spark shell Result is like this ``` 15/02/05 13:41:22 INFO SparkILoop: Created spark context.. Spark context

[GitHub] spark pull request: [SPARK-5586][Spark Shell][SQL] Make `sqlContex...

2015-02-04 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4387#issuecomment-72997735 @pwendell @rxin @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SQL][Hiveconsole] Bring hive console code up ...

2015-02-03 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4330#issuecomment-72628043 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-02-02 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4060#issuecomment-72478581 Updated. /cc @marmbrus @yhuai @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5324][SQL] Results of describe can't be...

2015-02-02 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4249#discussion_r23932721 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -54,13 +54,8 @@ private[hive] case object NativePlaceholder extends

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-02-02 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4060#discussion_r23932366 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala --- @@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing

[GitHub] spark pull request: [SQL][Hiveconsole] Bring hive console code up ...

2015-02-02 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4330#issuecomment-72606138 /cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL][Hiveconsole] Bring hive console code up ...

2015-02-02 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4330 [SQL][Hiveconsole] Bring hive console code up to date and update README.md Add `import org.apache.spark.sql.Dsl._` to make DSL query works. Since queryExecution is not avaliable

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-01-30 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4060#discussion_r23841357 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala --- @@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing

[GitHub] spark pull request: [SPARK-5196][SQL] Support `comment` in Create ...

2015-01-30 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/3999#issuecomment-72303112 @marmbrus @rxin Is this ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-3298][SQL] Add flag control overwrite r...

2015-01-29 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/4175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-3298][SQL] Add `allowExisting` flag to ...

2015-01-29 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4271 [SPARK-3298][SQL] Add `allowExisting` flag to control registerAsTable / registerTempTable https://issues.apache.org/jira/browse/SPARK-3298 add a parameter into `registerTempTable

[GitHub] spark pull request: [SPARK-3298][SQL] Add `allowExisting` flag to ...

2015-01-29 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4271#issuecomment-72064637 @squito @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-01-29 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4060#issuecomment-71996144 Hi, @liancheng Would you mind review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...

2015-01-29 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4060#issuecomment-71998834 /cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5324][SQL] Results of describe can't be...

2015-01-28 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4249 [SPARK-5324][SQL] Results of describe can't be queried Make below code works. ``` sql(DESCRIBE test).registerTempTable(describeTest) sql(SELECT * FROM describeTest).collect

[GitHub] spark pull request: [SQL] Implement Describe Table for SQLContext

2015-01-28 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4207#issuecomment-71799906 @yanbohappy thanks for the discussion and the work efforts : ) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-5324][SQL] Results of describe can't be...

2015-01-28 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4249#issuecomment-71825463 /cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4127#issuecomment-71707934 Hi, @rxin I created a new PR #4227 to rewrite `this part` and bring everything up-to-date, would you please review it? --- If your project is set up

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4127#issuecomment-71709975 ok, please close this one : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4127#issuecomment-71711069 I don't have permission, too. I only have `comment` permission here. what's going wrong? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe tab...

2015-01-27 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4227 [SPARK-5135][SQL] Add support for describe table to DDL in SQLContext Hi, @rxin @marmbrus I considered your suggestion and now re-write it. This is now up-to-date. Could u please

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe tab...

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4227#issuecomment-71770856 yeah, @rxin, would you like to talk with @marmbrus for `what we'd like to show in describe extended table` in SQLContext and then file a `JIRA` issues? So

[GitHub] spark pull request: [SQL] Implement Describe Table for SQLContext

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4207#issuecomment-71772475 hi, @yanbohappy Thanks for working on this. But by the way, this JIRA(SPARK-5324) `Results of describe can't be queried` is mainly focus on `make describe

[GitHub] spark pull request: [SQL] Implement Describe Table for SQLContext

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4207#issuecomment-71770183 hi, @yanbohappy, I've already worked in this. For your PR, I took a look at it. But I think it's a little hacky to me. Would you like to review mine

[GitHub] spark pull request: [SQL] Implement Describe Table for SQLContext

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4207#discussion_r23661855 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1034,4 +1034,11 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SQL] Implement Describe Table for SQLContext

2015-01-27 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4207#discussion_r23661781 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1034,4 +1034,11 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-3298][SQL] Add flag control overwrite r...

2015-01-26 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4175#issuecomment-71577816 Thanks, squito :) I'm working on this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-3298][SQL] Add flag control overwrite r...

2015-01-23 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4175#issuecomment-71167869 /cc @scwf @chenghao-intel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3298][SQL] Add flag control overwrite r...

2015-01-23 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request: https://github.com/apache/spark/pull/4175 [SPARK-3298][SQL] Add flag control overwrite registerAsTable / registerTempTable https://issues.apache.org/jira/browse/SPARK-3298 add a flag `allowOverwrite` to control

[GitHub] spark pull request: [SPARK-3298][SQL] Add flag control overwrite r...

2015-01-23 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4175#issuecomment-71166995 @marmbrus Any comments here ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-22 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4127#discussion_r23359955 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -178,3 +180,34 @@ case class DescribeCommand

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-21 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4127#discussion_r23359441 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -178,3 +180,34 @@ case class DescribeCommand

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4127#discussion_r23276671 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala --- @@ -300,6 +301,8 @@ case object StringType extends NativeType

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/3935#issuecomment-70772639 Thanks @rxin Should I close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4127#discussion_r23276780 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -70,9 +71,16 @@ class HiveContext(sc: SparkContext) extends

[GitHub] spark pull request: [SPARK-5263][SQL] `create table` DDL need to c...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4058#issuecomment-70795697 yeah. closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5263][SQL] `create table` DDL need to c...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/4058 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory closed the pull request at: https://github.com/apache/spark/pull/3935 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on a diff in the pull request: https://github.com/apache/spark/pull/4127#discussion_r23276556 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -178,3 +180,34 @@ case class DescribeCommand

[GitHub] spark pull request: [SPARK-5196][SQL] Support `comment` in Create ...

2015-01-20 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/3999#issuecomment-70797638 /cc @yhuai @marmbrus Test Passed. Is that OK with you? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-3880] HBase as data source to SparkSQL

2015-01-17 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4084#issuecomment-70359819 and we need check the coding styles. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-16 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/3935#issuecomment-70220078 @rxin The rebase may have some problems, cause changed 278 files ? how do I revert it ? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-5135][SQL] Add support for describe [ex...

2015-01-16 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/3935#issuecomment-70237945 Thanks @scwf @rxin, conflicts resolved cleanly, this now up-to-date. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-5196][SQL] Support `comment` in Create ...

2015-01-16 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/3999#issuecomment-70276610 ping @yhuai @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5264][SQL] support `drop table` DDL com...

2015-01-16 Thread OopsOutOfMemory
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/4060#issuecomment-70354063 @marmbrus @yhuai Could you review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

  1   2   >