[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-30 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16699 #18489 fixed the build failure. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-30 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16699 @hvanhovell I will send a quick fix soon, thanks for your kindly remind. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-30 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16699 @yanboliang @actuaryzhang this PR breaks the scala-2.10 build: ``` [error]

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-30 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16699 Merged into master. Thanks for contribution and all reviews! This great feature will benefit lots of users. @actuaryzhang Could you send follow-up PRs to address the two inline comments?

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78920/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78920/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78920/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-29 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 Made a new commit that fixes the issues you pointed out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78812/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78812/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78812/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-28 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16699 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-28 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 Got it. I should pay more attention to that mailing list from now on :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16699 this is a known issue in test runs currently - it's mentioned in d...@spark.apache.org, just so you know. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 Not sure what this error msg means, but it seems unrelated to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78729/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78729/ Test FAILed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78729/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78727/ Test FAILed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78727/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #78727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78727/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-06-27 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @yanboliang Thanks much for the review. The new commit includes everything you suggested except implementing `WeightLeastSquares` interface for `OffsetInstance`. Please see my incline comments

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-05-19 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @yanboliang Thanks for the update. This is a big change, although lots of then are on the test side. Let me know if there is anything I can do to help make the review easier. --- If

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-05-19 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16699 @actuaryzhang Sorry for late response. I will review this PR after finishing 2.2 release, thanks for your patience. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-04-20 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @yanboliang @sethah Any suggestion on moving this PR forward? Appreciate your comments and reviews. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-20 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @sethah Is there anything else you would recommend for this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72863/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72863/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72863/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @sethah Thanks much for your review. I've made a new commit that addressed all your comments. Please see my inline comments. Let me know if there is any other suggestions. Thanks. --- If

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72858/ Test FAILed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72857/ Test FAILed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72858/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72857/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16699 Ah, thank you very much for that clarification, I don't have much experience using R. I tried this out earlier, and it seems you have to use the same offset column name as you show above. I

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @sethah The predict method can work with new data in R. See below. Shall we focus on the current implementation, instead of discussing the details of the R behavior? :) Let me know if

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-13 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16699 I'm finding R's behavior for prediction with offsets to be a bit strange. Yes, R does use the original offsets supplied during training to do prediction, but what if I want to make predictions on a

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-10 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @sethah Thanks much for your review. Regarding prediction, both R and my implementation here allow prediction with offsets. If the users want to get the predicted rates (instead of

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-10 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16699 @actuaryzhang This is looking pretty good overall. Regarding the prediction logic, R glm does not allow you to predict with offsets, correct? I notice that statsmodels in Python _does_ allow it.

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-10 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @sethah Yes, that is lots of work. However, the only critical change (since the last commit) is on the calculation of the null deviance. The other changes are mainly because of updating

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-10 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16699 whew, this was a lot of work :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72672/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72672/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-09 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @sethah @imatiach-msft Please review the new commit. Main changes: - Fix issue in null deviance calculation in the presence of offset. Except for special cases (Gaussian with

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72672 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72672/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72162/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72162/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @yanboliang @zhengruifeng @srowen Could you guys take a look and let me know if there is any changes needed? Thanks much! --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @imatiach-msft Thanks much for your review. Renamed `off`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72162/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-30 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16699 LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72095/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72095/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72095/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @zhengruifeng Thanks for the suggestions. Added casting and instrumentation. @imatiach-msft Thanks for the clarification! It is probably worth another PR to clean up all tests in GLM.

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16699 @actuaryzhang thank you for updating the PR - I agree with your first two points. With regards to the method of RDD[Instance] also working with RDD[OffsetInstance], I think it should work,

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72068/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72068/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72068/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72067/ Test FAILed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72067/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72040/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72040/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72040/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @imatiach-msft Many thanks again for the review. I have incorporated some of your suggestions: 1. Create initialization of instance directly if it is Gaussian(identity) to avoid expensive

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-26 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16699 This looks really good. I made a couple more comments. I'm not sure about the class hierarchy of Instance/OffsetInstance. Maybe committers can take a look/comment on this PR? @jkbradley

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72003/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72003/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @imatiach-msft Thanks so much for your detailed review. Incredibly helpful. I've addressed all your comments in the new commit. Major changes are highlighted below: 1. Create

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #72003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72003/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16699 @actuaryzhang added a couple comments, please take a look, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @zhengruifeng @imatiach-msft Thanks much for pointing out the issue due to the hasOffset trait. This is what caused the test to fail. I have moved it to the GLRBase class. Things are

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71995/ Test PASSed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #71995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71995/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #71995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71995/testReport)** for PR 16699 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71994/ Test FAILed. ---

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16699 **[Test build #71994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71994/testReport)** for PR 16699 at commit

  1   2   >