Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-69561617
@andrewor14 instead of making the behavior of StreamingListenerBus to match
that of the LiveListenerBus, I sent #4006 to make them share the same codes in
the parent
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/3710
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22786673
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -118,7 +127,7 @@ private[spark] class LiveListenerBus extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22786686
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -49,7 +52,8 @@ private[spark] class LiveListenerBus extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22786638
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -17,20 +17,28 @@
package
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22618979
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -49,7 +52,8 @@ private[spark] class LiveListenerBus extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22619236
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -75,6 +79,11 @@ private[spark] class LiveListenerBus extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22619853
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -17,20 +17,28 @@
package
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22617594
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -27,7 +28,8 @@ import org.apache.spark.util.Utils
*
*
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22619181
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -49,7 +52,8 @@ private[spark] class LiveListenerBus extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22620055
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22617679
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -49,7 +52,8 @@ private[spark] class LiveListenerBus extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22619353
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -118,7 +127,7 @@ private[spark] class LiveListenerBus extends
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-69100998
Hi @zsxwing the changes look reasonable. My comments are mainly minor
wording suggestions and clarifications. One thing is that we can save the
refactoring of
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22263727
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22263766
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22263767
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22263810
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -39,18 +45,19 @@ private[spark] class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22263834
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -35,8 +36,9 @@ private[spark] class LiveListenerBus extends
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68074729
I left a few more comments. There are clear inconsistencies between
`LiveListenerBus` and `StreamingListenerBus`, which can only be solved by
actually having
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68074746
Finally, I would prefer @andrewor14 take a final look because he
understands that nuances of this class.
---
If your project is set up for it, you can reply to this email
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22265975
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22265994
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -17,20 +17,25 @@
package
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22266122
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -39,18 +45,19 @@ private[spark] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22266208
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -35,8 +36,9 @@ private[spark] class LiveListenerBus extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22266216
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68082967
[Test build #24800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24800/consoleFull)
for PR 3710 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68083137
[Test build #24801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24801/consoleFull)
for PR 3710 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68083163
[Test build #24801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24801/consoleFull)
for PR 3710 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68083165
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22266276
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22266417
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -64,36 +71,40 @@ private[spark] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68083882
[Test build #24803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24803/consoleFull)
for PR 3710 at commit
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68083944
All right, look good to me, but I will let @andrewor14 take the final call.
He is on vacation so it will probably be a few days for him to respond.
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68085413
[Test build #24800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24800/consoleFull)
for PR 3710 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68085416
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68086093
[Test build #24803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24803/consoleFull)
for PR 3710 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68086095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22243823
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -75,6 +78,11 @@ private[spark] class LiveListenerBus extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22245060
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -17,20 +17,25 @@
package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22245148
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -75,6 +78,11 @@ private[spark] class LiveListenerBus extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22245204
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -17,20 +17,25 @@
package
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22245199
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -75,6 +78,11 @@ private[spark] class LiveListenerBus extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22245214
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -75,6 +78,11 @@ private[spark] class LiveListenerBus extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68028341
[Test build #24761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24761/consoleFull)
for PR 3710 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22246575
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -17,20 +17,25 @@
package
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68032028
[Test build #24761 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24761/consoleFull)
for PR 3710 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-68032031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-67924795
[Test build #24730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24730/consoleFull)
for PR 3710 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-67924843
This looks good to me; I'd say it's ready to merge. Left one really minor
comment about maybe applying the same stop() fix to LiveListenerBus so that the
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-67924852
Hey @zsxwing can you update the title to make it more specific?
Updated the title and description.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-67927925
[Test build #24730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24730/consoleFull)
for PR 3710 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3710#issuecomment-67927929
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
53 matches
Mail list logo
