[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-121073637 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-06-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-113320434 @acvogel @fatlotus was the VPC problem ever resolved? If not I would prefer to close this PR since it's mostly gone stale at this point. --- If your project is set

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-96768699 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-04-27 Thread fatlotus
Github user fatlotus commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-96770335 I tried this patch, and had some problems with VPC. (In particular, an underlying bug with Boto left certain attributes empty, on accounts created within the last year

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-30 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-87752321 @acvogel Other than code complexity, the main reason I'd be hesitant about adding this option is that most of the Spark, spark-ec2 operations (like start-all.sh,

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/5109#discussion_r27132818 --- Diff: ec2/spark_ec2.py --- @@ -528,32 +532,53 @@ def launch_cluster(conn, opts, cluster_name): name = '/dev/sd' + string.letters[i + 1]

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/5109#discussion_r27143511 --- Diff: ec2/spark_ec2.py --- @@ -567,16 +592,28 @@ def launch_cluster(conn, opts, cluster_name): for i in my_req_ids:

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-86131454 Taking a closer look at this patch, I have to admit I'm neutral on whether it's worth adding the logic and complexity to support this feature. Granted, this is a

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread acvogel
Github user acvogel commented on a diff in the pull request: https://github.com/apache/spark/pull/5109#discussion_r27145944 --- Diff: ec2/spark_ec2.py --- @@ -528,32 +532,53 @@ def launch_cluster(conn, opts, cluster_name): name = '/dev/sd' + string.letters[i + 1]

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread acvogel
Github user acvogel commented on a diff in the pull request: https://github.com/apache/spark/pull/5109#discussion_r27149279 --- Diff: ec2/spark_ec2.py --- @@ -567,16 +592,28 @@ def launch_cluster(conn, opts, cluster_name): for i in my_req_ids:

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/5109#discussion_r27149320 --- Diff: ec2/spark_ec2.py --- @@ -528,32 +532,53 @@ def launch_cluster(conn, opts, cluster_name): name = '/dev/sd' + string.letters[i + 1]

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/5109#discussion_r27152639 --- Diff: ec2/spark_ec2.py --- @@ -567,16 +592,28 @@ def launch_cluster(conn, opts, cluster_name): for i in my_req_ids:

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-86167855 Thanks for explaining the use case @acvogel. I'm not familiar with MLlib, honestly, but that makes sense. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-25 Thread acvogel
Github user acvogel commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-86156199 The use case which led to this patch is for long-running jobs with few slaves where we require a large master instance type. For instance, training decision trees using

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-24 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-85521950 OK sounds good. FWIW, I think it's fine if we won't support the master-spot/slaves-non-spot combo as long as we error out early and cleanly. But if you want to make

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-24 Thread acvogel
Github user acvogel commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-85782112 I added the support for the on-demand slaves / spot master combination. I tried out all four combinations mentioned above and encountered no problems. I also tested

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-23 Thread acvogel
Github user acvogel commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-85339056 @chammas Good question! I had tested all combinations except for the case where the master is a spot instance and the slaves are on-demand instances. There is a bug with

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-85310826 @nchammas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-23 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-85314778 Thanks for submitting this patch! @acvogel Just to be clear, with this PR do we mean to support any of the following combinations? * master is spot

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-20 Thread fatlotus
Github user fatlotus commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-84148723 Yay! I was just about to write a patch for this myself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-20 Thread acvogel
GitHub user acvogel opened a pull request: https://github.com/apache/spark/pull/5109 [SPARK-6403][EC2] Add option to launch EC2 master as a spot instance instead of on demand. Adds option to launch EC2 master as a spot instance instead of on demand. Introduces a new command line

[GitHub] spark pull request: [SPARK-6403][EC2] Add option to launch EC2 mas...

2015-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5109#issuecomment-84106499 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your