[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-113051708 Thanks - I'm going to merge this and fix the since version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-113052722 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32653337 --- Diff: python/pyspark/sql/functions.py --- @@ -404,6 +405,21 @@ def when(condition, value): @since(1.4) --- End diff -- 1.5

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111813086 [Test build #34881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34881/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111805838 [Test build #34881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34881/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111813092 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111805774 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111805782 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111828049 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111828154 [Test build #34885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34885/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111828052 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111790522 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111790437 **[Test build #34867 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34867/console)** for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111860304 [Test build #34888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34888/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111860315 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111841603 [Test build #34885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34885/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111843152 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111843159 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111843274 [Test build #34888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34888/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111841615 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111768867 log(a) should be log(e, a), where e is the natural logatirhm. so we should just have a ctor that takes one argument, and creates Log(EulerNumber, argument). --- If

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375528 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375525 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -255,3 +265,56 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111771377 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375627 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -90,18 +90,26 @@ abstract class UnaryMathExpression(f:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111771375 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111776334 [Test build #34860 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34860/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111776341 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375494 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375557 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111778145 [Test build #34867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34867/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375281 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375290 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375357 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375476 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375580 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32376356 --- Diff: python/pyspark/sql/functions.py --- @@ -143,7 +143,8 @@ def _(): 'atan2': 'Returns the angle theta from the conversion of rectangular

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769155 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769142 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777873 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777875 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111780568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769616 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769620 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375539 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -255,3 +265,56 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375632 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -90,18 +90,26 @@ abstract class UnaryMathExpression(f: Double

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111771425 [Test build #34863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34863/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375269 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769207 [Test build #34860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34860/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769216 @rxin it is. Currently log(a) will create Log(a), which is natural logarithm. The issue now is how to handle `log(null, a)`. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111769677 [Test build #34862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34862/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375635 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1084,6 +1084,22 @@ object functions { def log(columnName: String): Column =

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777972 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777968 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111783117 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111783111 **[Test build #34862 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34862/console)** for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111780478 [Test build #34863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34863/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32376385 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -255,3 +255,18 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32371060 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32371101 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111717437 @rxin is this ready to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32371084 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1084,6 +1084,22 @@ object functions { def log(columnName: String): Column

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32371138 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32373967 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32373942 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32373979 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111378648 @rxin @marmbrus I think your comments are addressed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32315992 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,22 @@ class

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32320603 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathExpressionsSuite.scala --- @@ -236,6 +236,19 @@ class MathExpressionsSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32314542 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression,

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32315475 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1084,6 +1084,22 @@ object functions { def log(columnName:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32315786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,52 @@ case class Pow(left: Expression,

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32315686 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathExpressionsSuite.scala --- @@ -236,6 +236,19 @@ class MathExpressionsSuite extends

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111046086 [Test build #34681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34681/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111045661 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111045624 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111088074 [Test build #34681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34681/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111088089 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111287892 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111287878 [Test build #34712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34712/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32274856 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275335 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,18 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275171 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275146 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275321 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -110,6 +110,19 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275133 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -254,3 +254,54 @@ case class Pow(left: Expression, right:

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275196 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -110,6 +110,19 @@ class DataFrameFunctionsSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32275894 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -204,4 +204,18 @@ class MathFunctionsSuite

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111365725 [Test build #34745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34745/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111365733 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111337952 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111337944 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111338165 [Test build #34743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34743/consoleFull) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111339206 [Test build #34743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34743/console) for PR 6725 at commit

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111339218 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111340186 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111340179 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   >