Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-150096989
@cloud-fan OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user Sephiroth-Lin closed the pull request at:
https://github.com/apache/spark/pull/7417
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-149791623
Hi @Sephiroth-Lin , according to the previous discussion, I think we should
NOT do optimization according to data size, do you mind closing this PR and
help us review
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r42272013
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrategies
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41956822
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrate
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41954063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrategies ext
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41855351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -28,9 +28,17 @@ import org.apache.spark.sql.execut
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41817949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -28,9 +28,17 @@ import org.apache.spark.sql.execution.metr
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41473252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrategies
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41467358
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r41081828
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -274,12 +275,30 @@ private[sql] abstract class SparkStrategies
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-145190616
@zsxwing the rdds order do matters for `RDD.cartesian`, because of the
inefficient way we compute `CartesianRDD`:
```
for (x <- rdd1.iterator(currSplit.s1, cont
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-144133656
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-144133653
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-144133384
[Test build #43092 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43092/console)
for PR 7417 at commit
[`ce6ad25`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-144102643
[Test build #43092 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43092/consoleFull)
for PR 7417 at commit
[`ce6ad25`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-144101968
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138886020
BTW, can you add some unit test like what I did at
https://github.com/apache/spark/issues/8652
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138807985
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138807983
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138807953
[Test build #42193 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42193/console)
for PR 7417 at commit
[`e01c8f0`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138804849
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138804959
[Test build #42193 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42193/consoleFull)
for PR 7417 at commit
[`e01c8f0`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138804840
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38992905
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -267,12 +267,32 @@ private[sql] abstract class SparkStrategies
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38992862
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -267,12 +267,32 @@ private[sql] abstract class SparkStrategies
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38927387
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -28,9 +28,17 @@ import org.apache.spark.sql.execu
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38927289
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -28,9 +28,17 @@ import org.apache.spark.sql.execu
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38926444
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -54,7 +62,10 @@ case class CartesianProduct(left:
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38926127
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -267,12 +267,32 @@ private[sql] abstract class SparkStrat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138560912
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138560916
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138560862
[Test build #42133 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42133/console)
for PR 7417 at commit
[`8a8658c`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138556037
[Test build #42133 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42133/consoleFull)
for PR 7417 at commit
[`8a8658c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138554283
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138554397
@scwf done. @zsxwing updated code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138554309
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138544481
@Sephiroth-Lin can you rebase this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-138037270
@zsxwing it is definitely putting the small table in the left side of
'RDD.cartesian` improve the performance. you can have a simple test that do
cartesian with a big data
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38678714
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -27,16 +27,27 @@ import org.apache.spark.sql.execution.{B
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-137310991
@Sephiroth-Lin there are two changes in your patch: using
`BroadcastNestedLoopJoin` for the small table, and putting the small table in
the left side of `RDD.cartesian`.
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38608917
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -27,16 +27,27 @@ import org.apache.spark.sql.execution.{
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-137258596
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38590589
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -27,16 +27,27 @@ import org.apache.spark.sql.execution.{B
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38504238
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -27,16 +27,27 @@ import org.apache.spark.sql.execu
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38483827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -27,16 +27,27 @@ import org.apache.spark.sql.execution.{B
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-136882809
@davies @zsxwing any thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126891899
[Test build #185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/185/console)
for PR 7417 at commit
[`04678d1`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126891961
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126891220
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126891047
[Test build #39347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39347/console)
for PR 7417 at commit
[`04678d1`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126882610
[Test build #39347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39347/consoleFull)
for PR 7417 at commit
[`04678d1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126882306
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126882274
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126881827
[Test build #185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/185/consoleFull)
for PR 7417 at commit
[`04678d1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126881571
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126881510
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126880682
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126879380
[Test build #39341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39341/console)
for PR 7417 at commit
[`04678d1`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126879388
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126878743
[Test build #39341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39341/consoleFull)
for PR 7417 at commit
[`04678d1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126878467
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126878455
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126865575
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126865552
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126865560
[Test build #39320 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39320/console)
for PR 7417 at commit
[`4310536`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126865546
[Test build #39321 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39321/console)
for PR 7417 at commit
[`b2a0ae8`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126864814
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126864809
[Test build #39326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39326/console)
for PR 7417 at commit
[`5ca1d26`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126861943
[Test build #39326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39326/consoleFull)
for PR 7417 at commit
[`5ca1d26`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126861648
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126861632
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126857675
[Test build #39321 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39321/consoleFull)
for PR 7417 at commit
[`b2a0ae8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126857609
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126857606
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126856830
[Test build #39320 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39320/consoleFull)
for PR 7417 at commit
[`4310536`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126856531
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126856549
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-126856094
@hvanhovell Good suggestion, thank you, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-124562458
@Sephiroth-Lin The performance improvement sounds really good. It seems
like a good thing to put in Spark.
---
If your project is set up for it, you can reply to thi
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r35433399
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -213,10 +213,51 @@ private[sql] abstract class SparkStrategie
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r35433038
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -213,10 +213,51 @@ private[sql] abstract class SparkStrategie
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r35422390
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastCartesianProduct.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to th
Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123925858
@hvanhovell I use tpc-ds to test, for below SQL clause:
```
with single_value as (
select 1 tpcds_val from date_dim
)
select sum(ss_quantity *
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123573072
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123573027
[Test build #38024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38024/console)
for PR 7417 at commit
[`99bcde7`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123560475
[Test build #38024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38024/consoleFull)
for PR 7417 at commit
[`99bcde7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123559820
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123559815
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r35180395
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastCartesianProduct.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r35098517
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastCartesianProduct.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to th
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-123296087
Do you have any benchmarking results for this? Would be great to see how
much this improves the current situation.
---
If your project is set up for it, you can repl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122788178
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122788052
[Test build #37807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37807/console)
for PR 7417 at commit
[`a168900`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122773389
[Test build #37807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37807/consoleFull)
for PR 7417 at commit
[`a168900`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122773299
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122773289
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122160225
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122160203
[Test build #37566 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37566/console)
for PR 7417 at commit
[`547242e`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7417#issuecomment-122154517
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
1 - 100 of 150 matches
Mail list logo
