[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r46084064 --- Diff: R/pkg/R/DataFrame.R --- @@ -290,6 +292,121 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r46084477 --- Diff: R/pkg/R/types.R --- @@ -41,3 +41,11 @@ COMPLEX_TYPES <- list( # The full list of data types. DATA_TYPES <-

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160335856 Couple of minor comments, but otherwise change looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160353817 **[Test build #46845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46845/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160356898 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160356896 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160356742 **[Test build #46845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46845/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160362018 LGTM. Thanks @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160202381 Could we please review this? I think it would be great to get matching coltype<- in Spark 1.6 --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160203546 **[Test build #46831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46831/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160208217 **[Test build #46831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46831/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-160208675 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-24 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-159493605 @sun-rui ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-24 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-159495383 Will take a look soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-20 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158497430 @sun-rui any more comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158248747 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158248743 **[Test build #46380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46380/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158248744 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158252319 **[Test build #46382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46382/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158255672 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158255674 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158255594 **[Test build #46382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46382/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158256775 updated from comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-158248496 **[Test build #46380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46380/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r45251812 --- Diff: R/pkg/R/DataFrame.R --- @@ -293,6 +294,121 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-18 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r45172112 --- Diff: R/pkg/R/DataFrame.R --- @@ -293,6 +294,121 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-18 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r45172274 --- Diff: R/pkg/R/DataFrame.R --- @@ -293,6 +294,121 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-18 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r45172125 --- Diff: R/pkg/R/DataFrame.R --- @@ -293,6 +294,121 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-18 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r45171646 --- Diff: R/pkg/R/types.R --- @@ -41,3 +41,11 @@ COMPLEX_TYPES <- list( # The full list of data types. DATA_TYPES <-

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-18 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9654#discussion_r45290804 --- Diff: R/pkg/R/DataFrame.R --- @@ -293,6 +294,121 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-157513119 any more comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156318724 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156318715 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156322278 **[Test build #45825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45825/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156320225 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156320477 **[Test build #45826 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45826/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156322849 **[Test build #45826 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45826/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156322489 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156322484 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/9218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156023432 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156025454 **[Test build #45719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45719/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-156016257 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-156020677 **[Test build #45718 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45718/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-156020841 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-156020838 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156023384 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-156017477 **[Test build #45718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45718/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156028187 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156028109 **[Test build #45719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45719/consoleFull)** for PR 9654 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9654#issuecomment-156028189 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-156016213 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-11 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/9654 [SPARK-9319][SPARKR] Add support for setting column names, types Add support for for colnames, colnames<-, coltypes<- Also added tests for names, names<- which have no test previously.

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-04 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43983636 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43717596 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43717683 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43717935 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43718136 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43718270 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43604632 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43604658 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43603571 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43604767 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43698022 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43698343 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43694097 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r43694062 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,75 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152797513 yes, I agree: throw a complex types not supported error message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152861491 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152861497 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152868688 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152884866 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152884821 **[Test build #44783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44783/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152884867 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152883770 **[Test build #44783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44783/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152862545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152862543 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152862485 **[Test build #44767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44767/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152862537 **[Test build #44767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44767/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152865413 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152865405 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152882211 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152882214 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152867650 **[Test build #44769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44769/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152868689 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152868672 **[Test build #44769 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44769/consoleFull)** for PR 9218 at commit

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-11-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152862908 ``` Error : /home/jenkins/workspace/SparkPullRequestBuilder/R/pkg/man/colnames.Rd: Sections \title, and \name must exist and be unique in Rd files ERROR:

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152774672 Any more thought on this and #8984? It looks like we are cutting the 1.6.0 release very soon. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-31 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-152774865 My take is that its even fine if we only support basic types through `coltypes<-` for now and throw a `complex types not supported` error message for now. That way the

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-27 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-151399054 @felixcheung, type inferring works for complex types in createDataFrame(). You can refer to the test case for "create DataFrame with complex types" in test_sparkSQL.R.

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-151379530 @sun-rui That's a great point, `coltypes()` as its signature is defined, would only return a list of simple types. But how would one create a DataFrame with

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-24 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-150809533 I am not clear that for both coltypes() and coltypes<-(), how to represent complex types in R types? do you have idea? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r42899259 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,57 @@ setMethod("names<-", } }) +#' @rdname columns +#'

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-23 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r42884395 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,57 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-22 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/9218#discussion_r42785428 --- Diff: R/pkg/R/DataFrame.R --- @@ -276,6 +276,57 @@ setMethod("names<-", } }) +#' @rdname columns +#' @name

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-150125119 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-150125099 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-150126793 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-150126792 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   >