Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51296954
Alright, I've merged this in. Thanks Nan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15829983
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -293,7 +291,7 @@ private[spark] class TaskSetManager(
for
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15830012
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -310,6 +308,16 @@ private[spark] class TaskSetManager(
}
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15830030
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -341,20 +354,27 @@ private[spark] class TaskSetManager(
*
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15830100
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -363,25 +378,27 @@ private[spark] class TaskSetManager(
}
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15830234
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -249,15 +249,16 @@ private[spark] class TaskSchedulerImpl(
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51235942
Thanks, this looks good. I made some more small comments on it and there
were a couple left over from before. Please take a look at
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51274652
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17957/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51279900
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15851835
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -192,56 +211,59 @@ class TaskSetManagerSuite extends FunSuite with
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15851837
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -192,56 +211,59 @@ class TaskSetManagerSuite extends FunSuite with
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15851858
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -192,56 +211,59 @@ class TaskSetManagerSuite extends FunSuite with
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15852006
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -192,56 +211,59 @@ class TaskSetManagerSuite extends FunSuite with
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51283019
Cool, thanks! One final thing, I made some comments on the tests since it
seemed that some of the changes broke previous stuff we were testing for. If
they didn't, please
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51284233
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17970/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51287327
that's for fitting some early version of the patches, sorry about that, I
just forgot to undo the changes...
---
If your project is set up for it, you can reply to
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51287813
Alright, thanks for all your work on this. Just want to make sure we don't
miss stuff here.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51288049
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51288095
thanks for the patient review @mateiz @mridulm @kayousterhout @lirui-intel
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51095112
I see, got it. So just to be clear, in this new version, we still always
launch node-local tasks first on a node if there are any for it, but we can
also launch no-pref
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51098059
In the current version (no delay for nopref tasks at all)
yes, we check node-local tasks prior to no-pref tasks, if none, we can
launch no-pref immediately,
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51104685
ah, yes, I didn't do cross-job tracking here, so basically, the problem you
mentioned also exists
---
If your project is set up for it, you can reply to this email
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51108988
e.g. when there are some process-local tasks, node-local tasks, and
nopref tasks, node-local ones may not be able to run due to the delay
scheduling, so it will go
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51109866
yes, if there are only node-local and no-pref , node-local ones should run
right away, it's included in the current version
if you think it's OK, I can add a
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-5172
Sure, it would be good to add this. So just to double-check then, the
current (posted) version of the code does this, and it does pass unit tests and
not delay streaming,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51118639
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17875/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51125262
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51130511
unrelated pyspark failure (crashed)
rebasing to retest it
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51130972
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17883/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51131059
@mateiz , BTW, I met this for several times, all scala/java test cases
passed, but pyspark just crashed, what's the reason of this? maybe need to file
a JIRA?
---
If
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51132167
This particular failure was my fault, due to running tests locally and
merging when Jenkins hadn't completed. Sorry about that; I won't make that
mistake again.
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51134875
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51135109
@JoshRosen thanks for the explanation, that's just fine
@mateiz ...except pyspark, others seem to be fine...
---
If your project is set up for it, you can
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51136353
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51139533
Jenkins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51140635
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51140876
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17907/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51143952
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-51146059
finally,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50978501
I might give more explanation on the trace printed above
Set()
ANY,NODE_LOCAL
task 1, ArrayBuffer()
task 0, ArrayBuffer(TaskLocation(localhost,
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15684978
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -341,20 +354,27 @@ private[spark] class TaskSetManager(
*
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50857528
Awesome, looks like this passes now! What was it, was there a bug or tests
being flaky?
---
If your project is set up for it, you can reply to this email and have your
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50886564
hey @mateiz I tried different implementations locally, it seems that the
failed test cases are just brought by the unnecessary delay for nopref tasks,
in the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50747908
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17577/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50757880
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50762557
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17579/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50778426
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50832131
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17614/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50832184
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50834871
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17615/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50837758
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50839859
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17622/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50841195
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17624/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50841687
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50843804
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50605238
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17446/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50605235
all tasks are NO_PREFS or ANY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50605973
actually, I cannot reproduce it locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50612620
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17448/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50678936
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17485/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50684500
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50684943
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50689753
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17497/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50689820
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50697216
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17516/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50699556
@mateiz it seems that when I remove the fine granularity tracking, the test
cases failed again
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50704168
Alright, please look into it then. We should understand why it's happening
if it happens regularly. Maybe you need to run all the tests locally, not just
that suite, or
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50704994
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17536/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50705044
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50705498
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17538/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50707892
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508220
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -246,28 +246,36 @@ private[spark] class TaskSchedulerImpl(
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508258
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -113,6 +114,10 @@ private[spark] class TaskSetManager(
// but at
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508307
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -341,20 +346,31 @@ private[spark] class TaskSetManager(
*
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508323
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -363,38 +379,44 @@ private[spark] class TaskSetManager(
}
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508338
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -435,6 +460,13 @@ private[spark] class TaskSetManager(
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508347
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -751,20 +787,7 @@ private[spark] class TaskSetManager(
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508357
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -80,7 +80,7 @@ class FakeTaskSetManager(
override def
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15508376
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -341,20 +346,31 @@ private[spark] class TaskSetManager(
*
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50442021
This looks a lot better, thanks. Still made a few comments throughout it. I
think we can get rid of the fine-grained tracking of which nodes have node-only
tasks, that is
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15518169
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -751,20 +787,7 @@ private[spark] class TaskSetManager(
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15518594
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -246,28 +246,36 @@ private[spark] class TaskSchedulerImpl(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50468872
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17353/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50469155
Hi, @mateiz , I just updated the patch,
The reason I kept a per-node tracking of NODE_LOCAL-only tasks is that, we
don't want to delay the scheduling of
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50472816
QA results for PR 1313:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50477384
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17355/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50483404
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50564670
@CodingCat regarding the node-local tasks, yes, IMO we don't need to make
that optimization. It complicates the bookkeeping in the code with only a
minimal benefit (some
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1313#discussion_r15563591
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -363,25 +385,27 @@ private[spark] class TaskSetManager(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50568905
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17408/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50570521
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17410/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50571327
@mateiz , it seems that if we don't track NODE_LOCAL only tasks in a fine
granularity and adjust the delay for different nodes and different moments
(after all
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50575597
That could be a bug, not something due to the timeout. It complains of the
test taking 20s. Can you look at what that test was doing? As far as I can tell
it's not even
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50352463
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17281/consoleFull
---
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50363865
Hi, @mateiz, I just updated the patch, it has passed the unit test
also I squashed the commits to keep only 3 versions of the patch,
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50364070
QA tests have started for PR 1313. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17284/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50363114
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50370657
QA results for PR 1313:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50257258
Since all process local tasks are also node, rack and any : we will incur
node local delay also.
On 27-Jul-2014 11:09 am, Matei Zaharia notificati...@github.com
1 - 100 of 181 matches
Mail list logo
