[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2017-03-10 Thread shivaram
Github user shivaram closed the pull request at: https://github.com/apache/spark/pull/16290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2017-02-27 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r103276097 --- Diff: R/pkg/R/sparkR.R --- @@ -376,6 +377,12 @@ sparkR.session <- function( overrideEnvs(sparkConfigMap, paramMap) } + #

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2017-02-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r102373053 --- Diff: R/pkg/R/sparkR.R --- @@ -376,6 +377,12 @@ sparkR.session <- function( overrideEnvs(sparkConfigMap, paramMap) } + #

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2017-02-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r101883075 --- Diff: R/pkg/R/sparkR.R --- @@ -376,6 +377,12 @@ sparkR.session <- function( overrideEnvs(sparkConfigMap, paramMap) } + #

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92971642 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92968560 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92958552 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92953413 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92951374 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92949262 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92935954 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -964,10 +970,16 @@ object StaticSQLConf { } }

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92932104 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -964,10 +970,16 @@ object StaticSQLConf { } }

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92932105 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92932097 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -819,7 +819,13 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92932095 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-17 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92931894 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92916658 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -819,7 +819,13 @@ private[sql] class SQLConf extends Serializable

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-16 Thread bdwyer2
Github user bdwyer2 commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92916155 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92877278 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -55,14 +55,19 @@ private[sql] class SharedState(val sparkContext:

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92873918 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -964,11 +970,17 @@ object StaticSQLConf { } }

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92761572 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -964,11 +970,17 @@ object StaticSQLConf { } }

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92553628 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2165,6 +2165,14 @@ test_that("SQL error message is returned from JVM", {

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92553387 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2165,6 +2165,14 @@ test_that("SQL error message is returned from JVM", {

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92548697 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -55,14 +55,19 @@ private[sql] class SharedState(val

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread bdwyer2
Github user bdwyer2 commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92533173 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2165,6 +2165,14 @@ test_that("SQL error message is returned from JVM", {

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92531777 --- Diff: R/pkg/R/sparkR.R --- @@ -363,6 +363,13 @@ sparkR.session <- function( ...) { sparkConfigMap <-

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92531445 --- Diff: R/pkg/R/sparkR.R --- @@ -363,6 +363,13 @@ sparkR.session <- function( ...) { sparkConfigMap <-

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-14 Thread shivaram
GitHub user shivaram opened a pull request: https://github.com/apache/spark/pull/16290 [SPARK-18817] [SPARKR] [SQL] Set default warehouse dir to tempdir ## What changes were proposed in this pull request? This PR sets the default warehouse dir to a temporary directory in SparkR