Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16441
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96721137
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +72,156 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96720750
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/Loss.scala
---
@@ -67,3 +66,12 @@ trait Loss extends Serializable {
*/
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96720362
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -52,4 +51,10 @@ object LogLoss extends Loss {
// The
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96719349
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -177,6 +177,8 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96718917
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -315,8 +368,9 @@ object GBTClassificationModel extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96716341
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +158,21 @@ class GBTClassifier @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708064
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -52,4 +51,10 @@ object LogLoss extends Loss {
// The
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96707275
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +158,21 @@ class GBTClassifier @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708089
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +72,156 @@ class GBTClassifierSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708082
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/Loss.scala
---
@@ -67,3 +66,12 @@ trait Loss extends Serializable {
*/
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708053
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -315,8 +368,9 @@ object GBTClassificationModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96707360
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -177,6 +177,8 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95697903
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,18 +316,30 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95697512
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -193,6 +199,8 @@ object GBTClassifier extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95697253
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +158,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95670584
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -193,6 +199,8 @@ object GBTClassifier extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95672358
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,18 +316,30 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95667604
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +158,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95518069
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +72,157 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95517754
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -20,6 +20,12 @@ package org.apache.spark.mllib.tree.loss
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95517520
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,18 +316,33 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95517316
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,18 +316,33 @@ class GBTClassificationModel
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95498992
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -20,6 +20,12 @@ package org.apache.spark.mllib.tree.loss
import
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95495553
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -20,6 +20,12 @@ package org.apache.spark.mllib.tree.loss
import
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95497945
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +72,157 @@ class GBTClassifierSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95495249
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,18 +316,33 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95499165
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,18 +316,33 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95492631
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel private[ml](
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95482452
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -52,4 +61,8 @@ object LogLoss extends Loss {
// The
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95482409
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -20,6 +20,15 @@ package org.apache.spark.mllib.tree.loss
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95481743
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95481100
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95480871
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95480825
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -215,10 +224,21 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95480340
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95455485
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95454611
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -215,10 +224,21 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95474280
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -20,6 +20,15 @@ package org.apache.spark.mllib.tree.loss
import
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95457108
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95474360
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -52,4 +61,8 @@ object LogLoss extends Loss {
// The following
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95454890
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95455906
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -241,19 +261,42 @@ class GBTClassificationModel private[ml](
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95442630
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95432804
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95431357
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,6 +321,13 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95431048
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95430551
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95429802
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95429690
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95429487
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,6 +321,13 @@ class GBTClassificationModel private[ml](
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95423563
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95418591
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95418341
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,6 +321,13 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95408807
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -248,12 +268,38 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95408548
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -248,12 +268,38 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95407706
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -215,10 +223,23 @@ class GBTClassificationModel
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95399715
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95399594
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95392592
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95392109
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95387530
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95388361
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95387289
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95386959
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -17,20 +17,23 @@
package
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95276987
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -17,20 +17,23 @@
package
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95284606
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -248,12 +268,38 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95287318
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95285636
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -275,6 +321,13 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95284126
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95285904
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -215,10 +223,23 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95284948
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95286255
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95286413
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95284176
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +70,79 @@ class GBTClassifierSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95286979
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -248,12 +268,38 @@ class GBTClassificationModel private[ml](
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95276132
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -248,12 +269,38 @@ class GBTClassificationModel private[ml](
77 matches
Mail list logo
