Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r53599
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r04548
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110560960
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110556382
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110420176
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110114252
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110060244
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110058436
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109892051
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109888297
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109866897
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109865610
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109863558
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109859539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109854005
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109852878
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109827813
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109827145
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109827042
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109827045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109826890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109826847
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104506871
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1686,4 +1689,162 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104488815
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1686,4 +1689,162 @@ class HiveDDLSuite
}
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104485607
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104361311
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -146,7 +147,7 @@ class DDLSuite extends QueryTest with
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104361050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
---
@@ -162,6 +164,28 @@ object CatalogUtils {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104360436
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -146,7 +147,7 @@ class DDLSuite extends QueryTest with
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104359591
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -146,7 +147,7 @@ class DDLSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104359096
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -146,7 +147,7 @@ class DDLSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104359071
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -72,14 +73,14 @@ class DDLSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104359108
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -169,7 +170,7 @@ class DDLSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104359085
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -72,14 +73,14 @@ class DDLSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358996
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -95,7 +96,7 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358967
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -77,7 +79,7 @@ class CatalogImpl(sparkSession: SparkSession)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -953,7 +955,7 @@ case class ShowCreateTableCommand(table:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -66,7 +66,7 @@ case class CreateDatabaseCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358810
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -146,7 +146,7 @@ case class DescribeDatabaseCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358761
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -146,7 +150,7 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358658
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -21,6 +21,7 @@ import scala.collection.JavaConverters._
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358620
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -883,7 +885,7 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358453
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -553,7 +555,7 @@ abstract class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358279
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -883,7 +885,7 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104358192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -131,7 +132,7 @@ class SessionCatalog(
*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104357644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
---
@@ -162,6 +164,28 @@ object CatalogUtils {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104357082
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
---
@@ -162,6 +164,28 @@ object CatalogUtils {
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104266763
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -883,7 +885,7 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104261785
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -565,7 +565,8 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259448
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -340,8 +342,8 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104261105
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -397,7 +398,8 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104261398
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1843,28 +1846,28 @@ class DDLSuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259986
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala ---
@@ -17,6 +17,7 @@
package org.apache.spark.sql.catalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259621
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -365,10 +367,10 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259668
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -508,7 +510,7 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104260144
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -397,7 +398,8 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259181
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -170,7 +170,7 @@ class SessionCatalog(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259863
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -883,7 +885,7 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104260081
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -397,7 +398,8 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r104259724
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -553,21 +555,21 @@ abstract class
60 matches
Mail list logo
