Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17770
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118625817
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -241,7 +241,7 @@ class PlannerSuite extends SharedSQLContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118625651
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -241,7 +241,7 @@ class PlannerSuite extends SharedSQLContext {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118480364
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -241,7 +241,7 @@ class PlannerSuite extends SharedSQLContext {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118479956
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -573,7 +576,7 @@ class Dataset[T] private[sql](
Dataset.ofRows(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118479804
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -522,7 +525,7 @@ class Dataset[T] private[sql](
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118479757
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -435,7 +438,7 @@ class Dataset[T] private[sql](
s"Old column
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118479716
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -413,7 +416,7 @@ class Dataset[T] private[sql](
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118479696
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -203,7 +206,7 @@ class Dataset[T] private[sql](
* `fromRow` method
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118261213
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -174,17 +174,19 @@ class Dataset[T] private[sql](
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118196785
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -174,17 +174,19 @@ class Dataset[T] private[sql](
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118165051
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -174,17 +174,19 @@ class Dataset[T] private[sql](
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118155011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r118150671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117949203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117764494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117764201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117758668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117689370
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1741,7 +1743,8 @@ class Dataset[T] private[sql](
def union(other:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117689132
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1741,7 +1743,8 @@ class Dataset[T] private[sql](
def union(other:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117687980
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1741,7 +1743,8 @@ class Dataset[T] private[sql](
def union(other:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117687634
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1741,7 +1743,8 @@ class Dataset[T] private[sql](
def union(other:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117680064
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117680140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117670112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1066,7 +1071,8 @@ class Analyzer(
case
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117664343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1041,11 +1044,13 @@ class Analyzer(
* The
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117664061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1066,7 +1071,8 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117663936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1041,11 +1044,13 @@ class Analyzer(
* The
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117404393
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -187,6 +187,9 @@ class Dataset[T] private[sql](
}
}
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117404229
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1741,7 +1744,7 @@ class Dataset[T] private[sql](
def union(other:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117404204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2470,6 +2480,13 @@ object CleanupAliases extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117404192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -166,14 +166,15 @@ class Analyzer(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117403987
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,10 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117350209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -166,14 +166,15 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117349872
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -187,6 +187,9 @@ class Dataset[T] private[sql](
}
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117349650
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2470,6 +2480,13 @@ object CleanupAliases extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117349354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -912,3 +913,10 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117344695
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1741,7 +1744,7 @@ class Dataset[T] private[sql](
def union(other:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117344241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1605,6 +1613,8 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117344138
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1545,7 +1551,9 @@ class Analyzer(
*
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117343489
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -187,6 +187,9 @@ class Dataset[T] private[sql](
}
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r117343063
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala
---
@@ -23,8 +23,8 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115913789
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -188,6 +188,9 @@ class Dataset[T] private[sql](
}
}
+
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115913503
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -188,6 +188,9 @@ class Dataset[T] private[sql](
}
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115913413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2456,6 +2467,13 @@ object CleanupAliases extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115913359
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -441,4 +441,17 @@ class AnalysisSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115912958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115912603
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -441,4 +441,17 @@ class AnalysisSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115912383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115912307
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2456,6 +2467,13 @@ object CleanupAliases extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115912123
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1027,8 +1030,9 @@ class Analyzer(
* The
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115644214
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115506818
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115445383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115445109
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -188,6 +188,9 @@ class Dataset[T] private[sql](
}
}
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115445061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -670,7 +671,9 @@ class Analyzer(
* Generate a
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115408985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -670,7 +671,9 @@ class Analyzer(
* Generate
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115408504
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -188,6 +188,9 @@ class Dataset[T] private[sql](
}
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115408432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115115766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1027,7 +1030,7 @@ class Analyzer(
* The HAVING
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r114478656
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1134,7 +1138,7 @@ class Dataset[T] private[sql](
*/
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r114478322
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1134,7 +1138,7 @@ class Dataset[T] private[sql](
*/
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r114478015
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1134,7 +1138,7 @@ class Dataset[T] private[sql](
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r114330723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -906,3 +907,36 @@ case class
64 matches
Mail list logo
