Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r132032062
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -755,6 +755,7 @@ private[spark] class Client(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131907109
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -207,9 +207,16 @@ private[deploy] class SparkSubmitArguments(args:
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131897597
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -754,6 +754,7 @@ private[spark] class Client(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131897551
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -754,6 +754,7 @@ private[spark] class Client(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131857646
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -751,12 +752,14 @@ private[spark] class Client(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131857298
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java ---
@@ -291,24 +291,14 @@ private Properties loadPropertiesFile()
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18880#discussion_r131857192
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -206,13 +206,18 @@ private[deploy] class SparkSubmitArguments(args:
GitHub user vinodkc opened a pull request:
https://github.com/apache/spark/pull/18880
[SPARK-21665][Core]Need to close resources after use
## What changes were proposed in this pull request?
Resources in Core - SparkSubmitArguments.scala, Spark-launcher -
