[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20757 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r182903518 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1615,13 +1616,50 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-04-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r182787533 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1615,13 +1616,50 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173700914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1421,13 +1421,36 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-11 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173683323 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1440,7 +1463,7 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173616654 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1440,7 +1463,7 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-09 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173431522 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1421,13 +1421,36 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173429606 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1421,13 +1421,36 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173361092 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173332356 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173190616 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173159952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173156309 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1416,13 +1417,43 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173150013 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173149690 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1416,13 +1417,43 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173145614 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1416,13 +1417,42 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173132924 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1416,13 +1417,42 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173132852 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1416,13 +1417,42 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173048274 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173010942 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173006281 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172855693 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172845031 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172842808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172842014 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172787179 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172785669 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172784041 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172783686 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172782545 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r172782339 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1408,11 +1409,37 @@ case class

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-06 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20757 [SPARK-23595][SQL] ValidateExternalType should support interpreted execution ## What changes were proposed in this pull request? This pr supported interpreted mode for `ValidateExternalType`.