Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22298
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r216112853
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/JavaDriverFeatureStep.scala
---
@@ -38,7 +39,8 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r216113001
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -72,12
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r216112524
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,13 @@ private[spark] object Config
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214550394
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
I think the concern here is shipping
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214543937
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
That might be a good place for it. But
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214530079
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
shouldn't this be in python tests
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214495391
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -51,6 +51,7 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214492297
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -72,12
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214492080
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/JavaDriverFeatureStep.scala
---
@@ -38,7 +39,8 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214491727
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -51,6 +51,7 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214416261
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
Easiest place to put to be trivially
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214415839
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214411915
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214411462
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -33,6 +32,7 @@ RUN apk add --no-cache python
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214411589
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214411403
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
---
@@ -19,10 +19,10 @@ ARG base_img
FROM $base_img
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214411255
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,6 +58,15 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214411102
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -51,6 +51,7 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214410560
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,13 @@ private[spark] object
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214404961
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,13 @@ private[spark] object Config
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214409455
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -72,12
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214408969
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -72,12
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214409131
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -72,12
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214407418
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -33,6 +32,7 @@ RUN apk add --no-cache python &&
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214405048
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -51,6 +51,7 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214406804
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/JavaDriverFeatureStep.scala
---
@@ -38,7 +39,8 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214405499
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,6 +58,15 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214407357
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
---
@@ -19,10 +19,10 @@ ARG base_img
FROM $base_img
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214407128
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/RDriverFeatureStep.scala
---
@@ -53,7 +54,8 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214405118
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,6 +58,15 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214404764
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
Is examples the right place for this?
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214407013
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -67,7 +68,8
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214243652
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@
GitHub user ifilonenko opened a pull request:
https://github.com/apache/spark/pull/22298
[SPARK-25021][K8S] Add spark.executor.pyspark.memory limit for K8S
## What changes were proposed in this pull request?
Add spark.executor.pyspark.memory limit for K8S
## How
35 matches
Mail list logo
