Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-25 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/ --- (Updated ápr. 25, 2016, 7:48 de) Review request for Ambari, Alejandro Fernandez

Re: Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-25 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46614/#review130359 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Abst

Re: Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-25 Thread Dmitro Lisnichenko
> On April 25, 2016, 10:53 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java, > > line 197 > > > > > > Why to create new function in AbstractUp

Re: Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-25 Thread Dmytro Grinenko
> On April 25, 2016, 7:53 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java, > > line 197 > > > > > > Why to create new function in AbstractUpr

Review Request 46627: Move logic for adding hadoop.proxy.yarn.hosts from UI to BE.

2016-04-25 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46627/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.

Re: Review Request 46627: Move logic for adding hadoop.proxy.yarn.hosts from UI to BE.

2016-04-25 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46627/#review130366 --- Ship it! Ship It! - Andrew Onischuk On April 25, 2016, 8:30

Re: Review Request 46627: Move logic for adding hadoop.proxy.yarn.hosts from UI to BE.

2016-04-25 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46627/#review130367 --- Ship it! Ship It! - Dmytro Sen On Апрель 25, 2016, 8:30 д.п.

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 9:03 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
> On April 23, 2016, 6:35 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 210 > > > > > > Should slider_am_contain

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 9:04 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 9:06 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 9:07 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 9:31 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-25 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45980/#review130376 --- Ship it! Ship It! - Andrew Onischuk On April 9, 2016, 4:46 p

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-25 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/#review130380 --- Ship it! Ship It! - Oliver Szabo On April 25, 2016, 7:48 a.m

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 10:07 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/#review130379 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

2016-04-25 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46592/#review130394 --- Ship it! Ship It! - Di Li On April 22, 2016, 11:17 p.m., Jai

Review Request 46634: AMBARI-16043: version_builder.py fails to run against Python 2.6

2016-04-25 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46634/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-16043 https://issues.

Re: Review Request 46634: AMBARI-16043: version_builder.py fails to run against Python 2.6

2016-04-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46634/#review130401 --- Ship it! Nearly all modern OS are at least 2.7 or 3.0 and surpr

Re: Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46614/#review130403 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-25 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review130407 --- Ship it! Ship It! - Sumit Mohanty On April 22, 2016, 6:02 p.

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review130409 --- Ship it! Ship It! - Robert Nettleton On April 22, 2016, 6:02

Review Request 46619: AMBARI-16085 : Modify Ambari stacks for Ranger (for enabling plugins) to use service keytab for creating repositories and policies

2016-04-25 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46619/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Nat

Re: Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-25 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46614/ --- (Updated April 25, 2016, 5:32 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/#review130420 --- Ship it! Ship It! - Sumit Mohanty On April 25, 2016, 10:07 a

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-25 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/ --- (Updated April 25, 2016, 5:43 p.m.) Review request for Ambari, Alejandro Fernan

Review Request 46638: Issue with stack advisor

2016-04-25 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46638/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-16092 https:

Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46639/ --- Review request for Ambari, Oliver Szabo and Sumit Mohanty. Bugs: AMBARI-16093

Re: Review Request 46619: AMBARI-16085 : Modify Ambari stacks for Ranger (for enabling plugins) to use service keytab for creating repositories and policies

2016-04-25 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46619/#review130424 --- Fix it, then Ship it! ambari-common/src/main/python/resource_m

Re: Review Request 46638: Issue with stack advisor

2016-04-25 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46638/#review130430 --- Ship it! Ship It! - Dmitro Lisnichenko On April 25, 2016, 6:

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46639/#review130431 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46639/#review130432 --- Ship it! Ship It! - Sumit Mohanty On April 25, 2016, 3:28 p.

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
> On April 25, 2016, 3:34 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java, > > line 29 > > > > > > Is it something that AMS provider loggers can use o

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46639/#review130435 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
> On April 25, 2016, 4 p.m., Oliver Szabo wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java, > > line 29 > > > > > > Utils is too generic for me, can this be more specified

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Oliver Szabo
> On April 25, 2016, 4 p.m., Oliver Szabo wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java, > > line 29 > > > > > > Utils is too generic for me, can this be more specified

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46639/#review130441 --- Ship it! Ship It! - Oliver Szabo On April 25, 2016, 3:28 p.m

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
> On April 25, 2016, 4 p.m., Oliver Szabo wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java, > > line 29 > > > > > > Utils is too generic for me, can this be more specified

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-25 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 25, 2016, 4:29 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-25 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/ --- (Updated April 25, 2016, 4:37 p.m.) Review request for Ambari, Andrii Tkach and

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-25 Thread Keta Patel
> On April 22, 2016, 7:07 p.m., Di Li wrote: > > ambari-web/app/messages.js, line 2842 > > > > > > Message as "Invalid widget name. Only alphanumerics, underscores, > > hyphens, percentage and spaces are allowed."

Re: Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-25 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46614/#review130450 --- Ship it! Ship It! - Mahadev Konar On April 25, 2016, 2:32 p.

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130451 --- Ship it! Ship It! - Goutam Tadi On April 22, 2016, 11:51 p.m

Re: Review Request 46619: AMBARI-16085 : Modify Ambari stacks for Ranger (for enabling plugins) to use service keytab for creating repositories and policies

2016-04-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46619/#review130454 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 46398: Name in create Alert Notification should be restricted to use only alphanumerics, hyphens, spaces and underscores

2016-04-25 Thread Anita Jebaraj
> On April 20, 2016, 9:46 a.m., Alexandr Antonenko wrote: > > Ship It! Can you please push the code to trunk, I don't have the priviledge for that. - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review130469 --- Ship it! Ship It! - Alejandro Fernandez On April 25, 2016, 2

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/#review130470 --- Ship it! Ship It! - Alejandro Fernandez On April 25, 2016, 1

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-25 Thread Tim Thorpe
> On April 22, 2016, 11:19 p.m., Matt wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 434 > > > > > > If component A of service SA is co-located based on how component B of > > service SB i

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review130471 --- Ship it! Ship It! - Nate Cole On April 25, 2016, 10:43 a.m.,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-25 Thread Tim Thorpe
> On April 22, 2016, 11:19 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 44 > > > > > > *return componentName in ('HAWQMASTER', 'HAWQSTANDBY')* That w

Review Request 46648: Add show_available property to dry_run directive

2016-04-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46648/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 46648: Add show_available property to dry_run directive

2016-04-25 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46648/#review130475 --- Ship it! Ship It! - Zhe (Joe) Wang On April 25, 2016, 5:50 p

Re: Review Request 46648: Add show_available property to dry_run directive

2016-04-25 Thread Zhe (Joe) Wang
> On April 25, 2016, 5:51 p.m., Zhe (Joe) Wang wrote: > > Ship It! Works as FE expects. - Zhe (Joe) --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46648/#review130475 ---

Review Request 46649: Upgrade catalog 220 in not idempotent again

2016-04-25 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46649/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi Brod

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-25 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/#review130483 --- Ship it! Ship It! - Di Li On April 25, 2016, 4:37 p.m., Keta

Re: Review Request 46128: AMBARI-15724 Integrate Version Registration in Select Stack Page

2016-04-25 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46128/ --- (Updated April 25, 2016, 6:36 p.m.) Review request for Ambari, Jaimin Jetly, Ri

Review Request 46651: AMBARI-16102: Inconsistency between grid and list view of roles page

2016-04-25 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46651/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-16102 https://is

Re: Review Request 46128: AMBARI-15724 Integrate Version Registration in Select Stack Page

2016-04-25 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46128/#review130486 --- Ship it! Ship It! - Richard Zang On April 25, 2016, 6:36 p.m

Review Request 46652: Tez View : Equip the tez view shim to work with both version 1 & 2 of Tez UI

2016-04-25 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46652/ --- Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha. Bugs: AMBA

Review Request 46653: HBase service check fails on an HA cluster deployed via blueprint

2016-04-25 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46653/ --- Review request for Ambari and Dmytro Sen. Bugs: AMBARI-16104 https://issues

Re: Review Request 46653: HBase service check fails on an HA cluster deployed via blueprint

2016-04-25 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46653/#review130487 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 25, 2016,

Re: Review Request 46653: HBase service check fails on an HA cluster deployed via blueprint

2016-04-25 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46653/#review130488 --- Ship it! Ship It! - Mahadev Konar On April 25, 2016, 6:56 p.

Re: Review Request 46653: HBase service check fails on an HA cluster deployed via blueprint

2016-04-25 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46653/#review130489 --- Ship it! Ship It! - Mahadev Konar On April 25, 2016, 6:56 p.

Re: Review Request 46653: HBase service check fails on an HA cluster deployed via blueprint

2016-04-25 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46653/ --- (Updated April 25, 2016, 6:53 p.m.) Review request for Ambari and Dmytro Sen.

Review Request 46654: Auth-to-local rule generation duplicates default rules when adding case-insensitive default rules

2016-04-25 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46654/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Laszlo Puskas, a

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130491 --- Ship it! Ship It! - Lav Jain On April 22, 2016, 11:51 p.m.,

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-25 Thread Keta Patel
> On April 25, 2016, 6:27 p.m., Di Li wrote: > > Ship It! Thank you Di! - Keta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/#review130483

Re: Review Request 46651: AMBARI-16102: Inconsistency between grid and list view of roles page

2016-04-25 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46651/#review130499 --- Ship it! Ship It! - Zhe (Joe) Wang On April 25, 2016, 6:39 p

Re: Review Request 46562: View Configuration Simplification

2016-04-25 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46562/#review130498 --- Did a quick pass through - could we add JavaDoc for methods with d

Re: Review Request 46398: Name in create Alert Notification should be restricted to use only alphanumerics, hyphens, spaces and underscores

2016-04-25 Thread Alexandr Antonenko
> On April 20, 2016, 9:46 a.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > Can you please push the code to trunk, I don't have the priviledge for > that. yes, ofc - Alexandr --- This is an automatically gene

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-25 Thread Amruta Borkar
> On April 19, 2016, 8:47 p.m., Robert Nettleton wrote: > > I've taken a quick look at this, and I have a few concerns with this patch: > > > > 1. I'm not sure there is that much utility in replacing the secret tokens > > with the "default_password" value specified in the Cluster Creation > >

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- (Updated April 25, 2016, 11:37 p.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/#review130520 --- Ship it! Ship It! - Alejandro Fernandez On April 25, 2016, 1

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130524 --- Ship it! Ship It! - bhuvnesh chaudhary On April 22, 2016, 11

Review Request 46667: Ambari agent changes to push hive metrics to AMS

2016-04-25 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46667/ --- Review request for Ambari, Sumit Mohanty and Sid Wagle. Bugs: AMBARI-16108

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130523 --- ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js (

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130526 --- Ship it! Ship It! - jun aoki On April 22, 2016, 11:51 p.m.,

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread Matt
> On April 25, 2016, 5:12 p.m., jun aoki wrote: > > ambari-web/app/views/main/dashboard/widgets/pxf_live.js, line 87 > > > > > > How about ```isAnyMetricsNA()``` ? Will keep it as is to follow same format as DATANODE