Re: Review Request 53030: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53030/#review153379 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 19, 2016,

Re: Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53050/#review153375 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:33

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/#review153377 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:35

Re: Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/#review153378 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:36

Re: Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/#review153376 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:34

Re: Review Request 50803: [Ambari-17981] Integrate Druid With Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/ --- (Updated Oct. 20, 2016, 7:47 a.m.) Review request for Ambari, Renjith Kamath

Re: Review Request 50803: [Ambari-17981] Integrate Druid With Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/ --- (Updated Oct. 20, 2016, 8:08 a.m.) Review request for Ambari, Renjith Kamath

Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18644

Re: Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/#review153366 --- Ship it! Ship It! - Dmytro Sen On Окт. 20, 2016, 9:36 д.п.,

Re: Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53050/#review153363 --- Ship it! Ship It! - Dmytro Sen On Окт. 20, 2016, 9:33 д.п.,

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/#review153365 --- Ship it! Ship It! - Dmytro Sen On Окт. 20, 2016, 9:35 д.п.,

Re: Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/#review153364 --- Ship it! Ship It! - Dmytro Sen On Окт. 20, 2016, 9:34 д.п.,

Re: Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53050/#review153367 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016,

Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18646

Re: Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/#review153368 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016,

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/#review153369 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016,

Re: Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/#review153370 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016,

Review Request 53052: Move ATLAS role command order to common-services/ATLAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18645

Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53050/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18643

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review153387 ---

Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53060/ --- Review request for Ambari, Aleksandr Kovalenko, DIPAYAN BHOWMICK, Jonathan

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 20, 2016, 3:50 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

> On Oct. 20, 2016, 7:25 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java, > > line 127 > > > > > > ComponentInfo refers to

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 20, 2016, 3:54 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53060/#review153412 --- Fix it, then Ship it!

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

> On Oct. 20, 2016, 2:01 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 686 > > > > > > 1. Why %.user=% vs op=% ? > > 2. I

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/#review153403 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016,

Review Request 53068: Alert Targets Cannot Be Updated Due To Transaction / Cache Timing Issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53068/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18652

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/ --- (Updated Oct. 20, 2016, 7:24 p.m.) Review request for Ambari, Jonathan Hurley

Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-18651

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153414 --- Ship it! Ship It! - Jonathan Hurley On Oct. 18, 2016, 2:17

Re: Review Request 53068: Alert Targets Cannot Be Updated Due To Transaction / Cache Timing Issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53068/#review153421 --- Ship it! Ship It! - Nate Cole On Oct. 20, 2016, 1:02 p.m.,

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

> On Oct. 20, 2016, 2:01 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 686 > > > > > > 1. Why %.user=% vs op=% ? > > 2. I

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153406 --- This is preliminary version of the patch. Basically to have the

Review Request 53070: Add ability to configure sink configs for external AMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53070/ --- Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Sid Wagle, and

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/#review153418 --- Ship it!

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/ --- (Updated Oct. 20, 2016, 3:42 p.m.) Review request for Ambari and Dmitro

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/#review153424 ---

Re: Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

> On Oct. 20, 2016, 12:44 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java, > > line 337 > > > > > > containsKey() could have

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/ --- (Updated Oct. 20, 2016, 7:26 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153416 ---

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

> On Oct. 20, 2016, 2:01 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 686 > > > > > > 1. Why %.user=% vs op=% ? > > 2. I

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

> On Oct. 20, 2016, 6:11 p.m., Andrew Onischuk wrote: > > The blacklisting logic we previously were implementing is not needed now > > (as disscussed with Sid). > > > > Reasons for that: > > 1. If command takes more than 5 seconds, the executor will just restart > > itself and continue to

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/#review153439 ---

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153434 --- The blacklisting logic we previously were implementing is not

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 20, 2016, 1:34 p.m., Jonathan Hurley wrote: > > Ship It! branch-feature-AMBARI-18456 and trunk are in-sync - feel free to commit to trunk and branch-2.5. - Jonathan --- This is an automatically generated e-mail. To reply,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

> On Oct. 20, 2016, 4:52 p.m., Sid Wagle wrote: > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py, line 56 > > > > > > This looks weird I would think you would need a > >

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153444 ---

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review153428 --- Ship it! Ship It! - Jonathan Hurley On Oct. 7, 2016, 4:21

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/#review153440 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 20, 2016,

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/ --- (Updated Oct. 20, 2016, 10:08 p.m.) Review request for Ambari, Jonathan

Re: Review Request 52999: Incorporate database consistency check into main Ambari process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52999/ --- (Updated Жов. 20, 2016, 8:42 після полудня) Review request for Ambari, Dmytro

Re: Review Request 52999: Incorporate database consistency check into main Ambari process

> On Жов. 18, 2016, 10:43 після полудня, Sid Wagle wrote: > > ambari-server/src/main/python/ambari_server_main.py, line 105 > > > > > > This should be configurable if it isn't. I don't think we need to make this

Re: Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53060/ --- (Updated Oct. 20, 2016, 4:06 p.m.) Review request for Ambari, Aleksandr

Re: Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

> On Oct. 20, 2016, 12:44 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java, > > line 375 > > > > > > I like StringUtils() here

Review Request 53075: Fix JSHint errors in Workflow Manager view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/ --- Review request for Ambari, Di Li and Yusaku Sako. Bugs: AMBARI-18615

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153457 ---

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153451 --- Fix it, then Ship it! Pending unit tests for the patch, +1 for

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 8:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 50 > > > > > > There should be a default prefix > > Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/ --- (Updated Oct. 20, 2016, 10:20 p.m.) Review request for Ambari, Jonathan

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/ --- (Updated Oct. 20, 2016, 8:41 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/#review153452 --- Ship it! Ship It! - Sid Wagle On Oct. 20, 2016, 8:41 p.m.,

Re: Review Request 52999: Incorporate database consistency check into main Ambari process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52999/#review153454 --- Ship it! Ship It! - Sid Wagle On Oct. 20, 2016, 8:42 p.m.,

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

> On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js, > > line 1 > > > > > > Why a new file ? The changes are just the different way to

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 20, 2016, 6:36 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java, > > lines 171-189 > > > > > > There should be

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 7, 2016, 10:55 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java, > > line 817 > > > > > > Since this is called each time Ambari starts

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 7, 2016, 10:55 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java, > > line 817 > > > > > > Since this is called each time Ambari starts

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Oct. 20, 2016, 6:01 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

> On Oct. 20, 2016, 2:01 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TopNDownSampler.java, > > line 96 > >

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review153389 ---

Re: Review Request 52456: Modify HTTP headers to follow best security practices

> On Oct. 9, 2016, 6:39 p.m., Robert Levas wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Robert. > Can you please help push the fix? > > Robert Levas wrote: > Pushed to trunk: > > ``` > commit 34c5686c3a0f80a5c7b78ddf05bb41cb13202438 > Author:

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153397 --- Ship it! Ship It! - Laszlo Puskas On Oct. 18, 2016, 6:17

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153396 --- Ship it! Ship It! - Sebastian Toader On Oct. 18, 2016, 8:17