/HAWQ/2.0.0/configuration/hawq-site.xml
d3aa0ed
Diff: https://reviews.apache.org/r/44868/diff/
Testing
---
manual.
Thanks,
Alexander Denissov
--
Ran 253 tests in 7.111s
OK
--
Total run:927
Total errors:0
Total failures:0
OK
Thanks,
Alexander Denissov
stant, but not for the whole file, but rather within the method. I
feel that exposing the constant for the whole file is too intrusive.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews
--
Ran 253 tests in 7.111s
OK
--
Total run:927
Total errors:0
Total failures:0
OK
Thanks,
Alexander Denissov
ver/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
(line 45)
<https://reviews.apache.org/r/44987/#comment186493>
plural, so perhaps "..they should be.." instead of "..it should be.."
- Alexander Denissov
On Marc
/stack_advisor.py (line
691)
<https://reviews.apache.org/r/44915/#comment186279>
did you run the tests ? I believe test_stack_advisor.py will need to get
updated.
- Alexander Denissov
On March 16, 2016, 9:46 p.m., Goutam Tadi
directory descriptions
Diffs (updated)
-
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
d3aa0ed
Diff: https://reviews.apache.org/r/44868/diff/
Testing
---
manual.
Thanks,
Alexander Denissov
/r/45012/diff/
Testing
---
manual
--
Ran 253 tests in 7.111s
OK
--
Total run:927
Total errors:0
Total failures:0
OK
Thanks,
Alexander Denissov
--
Manual.
--
Ran 246 tests in 7.028s
OK
--
Total run:911
Total errors:0
Total failures:0
Thanks,
Alexander Denissov
Diff: https://reviews.apache.org/r/45188/diff/
Testing
---
manual
Thanks,
Alexander Denissov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45255/#review125206
---
Ship it!
Ship It!
- Alexander Denissov
On March 24, 2016
7.045s
OK
--
Total run:911
Total errors:0
Total failures:0
Thanks,
Alexander Denissov
:
--
Total run:933
Total errors:0
Total failures:0
OK
Thanks,
Alexander Denissov
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45705/#review127007
---
On April 4, 2016, 9:48 p.m., Alexander Denissov wrote:
>
>
--
Total run:921
Total errors:0
Total failures:0
Thanks,
Alexander Denissov
/
Testing
---
Tested manually and updates python tests:
--
Ran 246 tests in 7.061s
OK
--
Total run:923
Total errors:0
Total failures:0
Thanks,
Alexander
--
Total run:925
Total errors:0
Total failures:0
Thanks,
Alexander Denissov
t is running.
- Alexander Denissov
On April 13, 2016, 12:50 a.m., bhuvnesh chaudhary wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
--
Total run:959
Total errors:0
Total failures:0
Thanks,
Alexander Denissov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46181/#review128799
---
Ship it!
Ship It!
- Alexander Denissov
On April 13, 2016
/package/scripts/common.py
(line 92)
<https://reviews.apache.org/r/46186/#comment192278>
I think this function should only take a name of component and use utility
to get process name and port number based on metadata. Maybe refactor that
function from status into utils ?
- Alexander De
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129025
---
Ship it!
Ship It!
- Alexander Denissov
On April 14, 2016, 9
<https://reviews.apache.org/r/46186/#comment192490>
do we need unit test for this function ?
- Alexander Denissov
On April 14, 2016, 9:20 p.m., jun aoki wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46253/#review129069
---
Ship it!
Ship It!
- Alexander Denissov
On April 15, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46283/#review129196
---
Ship it!
Ship It!
- Alexander Denissov
On April 15, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46294/#review129412
---
Ship it!
Ship It!
- Alexander Denissov
On April 16, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/#review129485
---
Ship it!
Ship It!
- Alexander Denissov
On April 19, 2016, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46350/#review129627
---
Ship it!
Ship It!
- Alexander Denissov
On April 19, 2016, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/#review130162
---
Ship it!
Ship It!
- Alexander Denissov
On April 21, 2016
016, 6:27 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBAR
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46742/#review130816
---
Please add unit tests.
- Alexander Denissov
On April 27, 2016
visor should be called only when the service is installed or
is chosen to be installed, do we really need the extra check here ?
- Alexander Denissov
On April 28, 2016, 4:36 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatic
(line 46)
<https://reviews.apache.org/r/44210/#comment194952>
we have a case (not coded yet) that might require more flexible lgoic here
for which we will need more metadata. When we do thin, we might extend the
interface to take a list of current component layout.
- Alexander Denissov
On
HAWQ and PXF
with this new logic ? After testing the branch can be merged to trunk and we
will avoid any major surprises.
- Alexander Denissov
On April 28, 2016, 4:36 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically ge
> On April 28, 2016, 10:54 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> > line 110
> > <https://reviews.apache.org/r/44210/diff/3-5/?file=1363971#file1363971line110>
> >
> >
> On April 29, 2016, 12:11 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java,
> > line 56
> > <https://reviews.apache.org/r/44210/diff/5/?file=1364835#file1364835line56>
> >
> >
> On April 29, 2016, 12:11 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java,
> > line 65
> > <https://reviews.apache.org/r/44210/diff/5/?file=1364838#file1364838line65>
> >
> > In
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46800/#review131181
---
Ship it!
Ship It!
- Alexander Denissov
On April 29, 2016, 8
> On April 29, 2016, 8:59 p.m., Alexander Denissov wrote:
> > Ship It!
Do we also need to move PXF to the new namenode host ?
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46742/#review131183
---
Ship it!
Ship It!
- Alexander Denissov
On April 29, 2016, 6
> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote:
> > Do we have a branch cut with these changes in so that we can test HAWQ and
> > PXF with this new logic ? After testing the branch can be merged to trunk
> > and we will avoid any major surprises.
>
> Ti
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46852/#review131348
---
Ship it!
Ship It!
- Alexander Denissov
On April 29, 2016, 8
> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote:
> > Do we have a branch cut with these changes in so that we can test HAWQ and
> > PXF with this new logic ? After testing the branch can be merged to trunk
> > and we will avoid any major surprises.
>
> Ti
/functions/namenode_ha_utils.py
(line 142)
<https://reviews.apache.org/r/46949/#comment195735>
The code in line 57 is:
raise Fail('No active NameNode was found.')
Should the same be done here for consistency ?
- Alexander Denissov
On May 3, 2016, 11:05 p.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131752
---
Ship it!
Ship It!
- Alexander Denissov
On May 4, 2016, 9:28
]
[INFO] Total time: 45.229 s
[INFO] Finished at: 2016-05-04T16:25:14-08:00
Thanks,
Alexander Denissov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132347
---
Ship it!
Ship It!
- Alexander Denissov
On May 9, 2016, 7:55
single, then we don't need 1 at the end of variable
name.
ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js (line
111)
<https://reviews.apache.org/r/47252/#comment197209>
we don't have orange here, do we ?
- Alexander Denissov
sor.py (line
2041)
<https://reviews.apache.org/r/47328/#comment197444>
should HAWQ/PXF tests be now moved to separate service advisor tests files,
perhaps as a separate effort ?
- Alexander Denissov
On May 13, 2016, 12:58 a.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47328/#review133154
---
Ship it!
Ship It!
- Alexander Denissov
On May 13, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47434/#review133471
---
Ship it!
Ship It!
- Alexander Denissov
On May 17, 2016, 12
/wizard_view.js
(line 64)
<https://reviews.apache.org/r/47573/#comment198536>
does this single fix solves both issues ?
- Alexander Denissov
On May 19, 2016, 1:29 a.m., bhuvnesh chaudhary wrote:
>
> ---
> This is a
<https://reviews.apache.org/r/47580/#comment198659>
here as well, just check for the jar
ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py
(line 86)
<https://reviews.apache.org/r/47580/#comment198660>
pxf-hbase.jar -- h is missing
- Alexander Denissov
dition.
Also, merging 2 ifs into 1 with && will be more readable.
- Alexander Denissov
On May 20, 2016, 10:11 p.m., bhuvnesh chaudhary wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
c/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
(line 55)
<https://reviews.apache.org/r/47642/#comment199135>
why just not say availableHosts[0] as it is the same as availableHosts[:1]
but less awkward ?
- Alexander Denissov
On May 21, 2016, 12:07 a.m.
<https://reviews.apache.org/r/47656/#comment199138>
a lot of commented out code here
- Alexander Denissov
On May 20, 2016, 7:03 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47749/#review134514
---
Ship it!
Ship It!
- Alexander Denissov
On May 23, 2016, 11
themes/theme.json
(line 201)
<https://reviews.apache.org/r/47802/#comment199566>
can this be a slider between 0 ad 100 ? Should we also have validation that
the value is within that range if user manually enters the number ?
- Alexander Denissov
On May 25, 2016, 12:17 a.m., bhuvnesh cha
> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json,
> > line 201
> > <https://reviews.apache.org/r/47802/diff/1/?file=1392948#file1392948line201>
> >
> > can this b
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134924
---
Ship it!
Ship It!
- Alexander Denissov
On May 26, 2016, 4
g/r/48235/#comment201141>
are we repeating default values already defined in .xml file ? Would be
better not to do that, if possible.
- Alexander Denissov
On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48290/#review136358
---
Ship it!
Ship It!
- Alexander Denissov
On June 6, 2016, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49362/#review140036
---
Ship it!
Ship It!
- Alexander Denissov
On June 29, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50086/#review142449
---
Ship it!
Ship It!
- Alexander Denissov
On July 15, 2016, 9
ambari-server/src/main/resources/stacks/stack_advisor.py 47f4500
ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
780370d
Diff: https://reviews.apache.org/r/50097/diff/
Testing
---
Tested manually, updated unit tests.
Thanks,
Alexander Denissov
---
Tested manually, updated unit tests.
Thanks,
Alexander Denissov
/service_advisor.py
(line 213)
<https://reviews.apache.org/r/50198/#comment208504>
this property has no impact on the logic inside this if, maybe move it out
of the if statement ?
- Alexander Denissov
On July 19, 2016, 7:15 p.m., Matt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142834
---
Ship it!
Ship It!
- Alexander Denissov
On July 19, 2016, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50544/#review143868
---
Ship it!
Ship It!
- Alexander Denissov
On July 27, 2016, 11
/
Testing
---
tested manually and update unit tests:
--
Ran 66 tests in 0.285s
OK
Thanks,
Alexander Denissov
/test_stack_advisor.py ff87adb
Diff: https://reviews.apache.org/r/50547/diff/
Testing
---
tested manually and update unit tests:
--
Ran 66 tests in 0.285s
OK
Thanks,
Alexander Denissov
n/resources/stacks/stack_advisor.py (line 900)
<https://reviews.apache.org/r/50731/#comment210676>
in names.keys() ?
- Alexander Denissov
On Aug. 3, 2016, 1:01 a.m., Matt wrote:
>
> ---
> This is an automatically generated
---
--
Ran 16 tests in 0.050s
OK
Thanks,
Alexander Denissov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50731/#review144720
---
Ship it!
Ship It!
- Alexander Denissov
On Aug. 4, 2016, 1
_DIR is a
bit too general name for HAWQ specific directory
ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py
(line 28)
<https://reviews.apache.org/r/50965/#comment211631>
PXF_ALERTS_DIR_PATH would be a better name
- Alexander Denissov
On Aug. 10, 2016, 8
a few suggestions for
naming.
- Alexander Denissov
On Aug. 10, 2016, 8:30 p.m., Lav Jain wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review149208
---
Ship it!
Ship It!
- Alexander Denissov
On Sept. 9, 2016, 1
77 matches
Mail list logo
