Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136242 --- Ship it! Ship It! - Di Li On June 3, 2016, 10:47 p.m

Re: Review Request 48702: Add ability to set GET request directives

2016-06-15 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137721 --- Ship it! Ship It! - Di Li On June 14, 2016, 11:12 p.m

Re: Review Request 47746: Update Moment.js to latest stable version 2.13.0

2016-06-07 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47746/#review136501 --- Ship it! Ship It! - Di Li On June 7, 2016, 5:23 p.m

Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

2016-05-27 Thread Di Li
properties are changed when I enabled CPU isolation on the Yarn config tab. Thanks, Di Li

Review Request 47955: AmbariAMBARI-16906 Express upgrade: Oozie failed to start when user name and group are none-default values

2016-05-27 Thread Di Li
successfully during the EU. Thanks, Di Li

Re: Review Request 47955: AMBARI-16906 Express upgrade: Oozie failed to start when user name and group are none-default values

2016-05-27 Thread Di Li
--- patch a trunk cluster (Oozie use is non-default myoozie, group is non-default myhadoop) with the change, run express upgrade, verify that with the change, oozie restarted successfully during the EU. Thanks, Di Li

Review Request 48136: AMBARI-16973 Print out configType has malformed json text as part of the ambari server startup error handling

2016-06-01 Thread Di Li
or message also shows the config_id Thanks, Di Li

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-16 Thread Di Li
> On June 16, 2016, 6:34 p.m., Di Li wrote: > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js, > > line 146 > > <https://reviews.apache.org/r/48734/diff/1/?file=1420112#file1420112line146> > > > > I am under the i

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-17 Thread Di Li
. As a safeguard against offline active NN, the check should eventually timeout to unblock the rest of the start sequence. - Di Li On June 15, 2016, 4:41 p.m., Victor Galgo wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-17 Thread Di Li
previous comment to Victor about my investigation and why I think the fix should happen at the NameNode Python code level? Let me know if it's a reasonable statement... - Di Li On June 15, 2016, 4:41 p.m., Victor Galgo wrote

Review Request 49150: AMBARI-17379: set verbose on HostCleanup.py does not work

2016-06-23 Thread Di Li
/python/ambari_agent/HostCleanup.py 1655fbd Diff: https://reviews.apache.org/r/49150/diff/ Testing --- unit test for HostCleanup.py Patch a cluster with the new script and run HostCleanup.py with -v option Thanks, Di Li

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-16 Thread Di Li
e some logic to check if NameNode is out of the safemode? On a cluster with terabytes of data in HDFS, it may take NN quite some time (a few minutes, depending on the cluster's performenace) to exit the safemode. - Di Li On June 15, 2016, 4:41 p.m., Victor Galgo

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-06-17 Thread Di Li
rg/r/48855/diff/ Testing --- 1. patch a trunk cluster with the code change, ran express upgrades, express downgrades, rolling upgrades and rolling downgrades. Check upgrade and downgrade history displayed on the UI 2. new unit tests Thanks, Di Li

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-06-17 Thread Di Li
submitted? - Di Li On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-06-17 Thread Di Li
Testing --- 1. patch a trunk cluster with the code change, ran express upgrades, express downgrades, rolling upgrades and rolling downgrades. Check upgrade and downgrade history displayed on the UI 2. new unit tests Thanks, Di Li

Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Di Li
Diff: https://reviews.apache.org/r/49267/diff/ Testing --- Build ambari rpms with the changes and run install, verify on the host registration step, the messages displayed are built at the view level. Thanks, Di Li

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Di Li
just as well as the one I proposed. Thanks. Di - Di --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49267/#review139580 --- On June

Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

2016-03-18 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/#review124176 --- Ship it! Ship It! - Di Li On March 17, 2016, 6:11 p.m

Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-14 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44457/#review123464 --- Ship it! Ship It! - Di Li On March 11, 2016, 8:08 p.m

Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-15 Thread Di Li
> On March 14, 2016, 5:47 p.m., Di Li wrote: > > Ship It! > > Keta Patel wrote: > Thank you Di! can you reattach the latest build via the "Update Diff" option? Your AMBARI-15310_Mar10.patch is not up to downl

Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-19 Thread Di Li
://reviews.apache.org/r/45054/diff/ Testing --- unit test patch a trunk cluster with code change, verify the host bulk command list shown for DataNode, HBase Region server, storm supervisor, etc. Thanks, Di Li

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-29 Thread Di Li
server, storm supervisor, etc. Thanks, Di Li

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-29 Thread Di Li
h. - Di --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45054/#review124303 --- On March 29, 2016, 5:03 p.m., Di Li wrote: > > --- > This is an automaticall

Re: Review Request 45744: AMBARI-15696: BulkCommand stop NodeManagers stops the wrong component

2016-04-06 Thread Di Li
manager stops nodemanagers across the cluster. Thanks, Di Li

Review Request 45753: AMBARI-15470: List of decommission-allowed components should be stack driven

2016-04-05 Thread Di Li
to both front and backend code patch a trunk cluster with front and backend code change and test the decommission command shown on the UI Thanks, Di Li

Review Request 45928: AMBARI-15719: Make list of reassignable components stack driven instead of hardcoding them in the UI code

2016-04-08 Thread Di Li
end and backend code changes. 2. Patched a trunk cluster with code change and verified the Move menu item for components was shown/hidden based on the flag set in the corresponding metainfo.xml. Thanks, Di Li

Re: Review Request 44724: AMBARI-12906: Alert notifications are created even if credential fields are left empty

2016-03-20 Thread Di Li
/manage_alert_notifications_controller.js (line 530) <https://reviews.apache.org/r/44724/#comment186616> same question as Jonathan, make sure to check falsy - Di Li On March 15, 2016, 7:17 p.m., Qin Liu wrote: > > --- > This is an automatica

Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

2016-03-19 Thread Di Li
it should go into? Thanks. - Di Li On March 18, 2016, 6:32 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 45744: AMBARI-15696: BulkCommand stop NodeManagers stops the wrong component

2016-04-05 Thread Di Li
://reviews.apache.org/r/45744/diff/ Testing --- patch a cluster with latest metainfo.xml change, restart cluster and verify now the bulk command for stop node manager stops nodemanagers across the cluster. Thanks, Di Li

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-31 Thread Di Li
enerated e-mail. To reply, visit: https://reviews.apache.org/r/45054/#review126240 ------- On March 29, 2016, 5:03 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-31 Thread Di Li
--- unit test patch a trunk cluster with code change, verify the host bulk command list shown for DataNode, HBase Region server, storm supervisor, etc. Thanks, Di Li

Review Request 45052: AMBARI-15478:Clearer manual step messages for Oozie and hive database backup and restore

2016-03-28 Thread Di Li
/upgrades/nonrolling-upgrade-2.4.xml fe05d91 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 4ad5d6d Diff: https://reviews.apache.org/r/45052/diff/ Testing (updated) --- patch cluster and run upgrades Thanks, Di Li

Review Request 46144: AMBARI-15844: Add conf property UI to show warning of potential duplications among all confType for the service

2016-04-13 Thread Di Li
a warning this time, about a same-named property is defined in hbase-site.xml. This is to test the new behavior introduced via this JIRA. Thanks, Di Li

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-25 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/#review130483 --- Ship it! Ship It! - Di Li On April 25, 2016, 4:37 p.m

Review Request 46745: AMBARI-16140: ambari-agent RPM yum update should backup both stack and common-services

2016-04-27 Thread Di Li
cluster, verify /var/lib/ambari-agent/cache/stack and /var/lib/ambari-agent/cache/common-services are backed up. Thanks, Di Li

Re: Review Request 46745: AMBARI-16140: ambari-agent RPM yum update should backup both stack and common-services

2016-04-27 Thread Di Li
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46745/#review130833 ----------- On April 27, 2016, 6:19 p.m., Di Li wrote: > > --- &g

Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

2016-04-25 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46592/#review130394 --- Ship it! Ship It! - Di Li On April 22, 2016, 11:17 p.m

Review Request 46634: AMBARI-16043: version_builder.py fails to run against Python 2.6

2016-04-25 Thread Di Li
ux box with only Pyton 2.6 installed, verifies it has the same content as one generated on a linux box with Python 2.7. Thanks, Di Li

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-22 Thread Di Li
d input. Only alphanumerics, underscores, hyphens, percentage and spaces are allowed." - Di Li On April 21, 2016, 10:51 p.m., Keta Patel wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 47480: AMBARI-16714: Pull 'Groups' txt shown on Alert details filters from the messages.js file

2016-05-17 Thread Di Li
Diff: https://reviews.apache.org/r/47480/diff/ Testing --- Manually patch a trunk cluster with UI change, verify the label is displayed correctly. Thanks, Di Li

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-02 Thread Di Li
/controllers/clusters/UserAccessListCtrl.js (line 75) <https://reviews.apache.org/r/46808/#comment195266> what happens when permission_label is not None? - Di Li On April 29, 2016, 12:41 a.m., Keta Patel

Re: Review Request 46394: Can not save roles assigned to users and groups on Manage Ambari -> Roles -> Block view

2016-04-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46394/#review129558 --- Ship it! Ship It! - Di Li On April 19, 2016, 4:33 p.m

Review Request 46199: AMBARI-15866: Renew kerberos keyfile rest API returnes a malformed /request URL

2016-04-14 Thread Di Li
Verify the existing href behavior is still correct. 3. Submit a rest api that does not need to return /requests url, like get stack details REST API Veriy the existing href behavior is still correct. On a non-kerberized trunk cluster, patch the cluster with fix, Repeat the 3 tests mentioned above. Thanks, Di Li

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-21 Thread Di Li
play instead of the single warning display at the top of the page ? ambari-web/app/templates/main/service/widgets/create/step3.hbs <https://reviews.apache.org/r/46475/#comment193455> Can you restore inline error display instead of the single warning display at the top of the page ? - D

Re: Review Request 49912: Blueprint registration step uses wrong format for property-attributes in Configuration

2016-07-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49912/#review142077 --- Ship it! Ship It! - Di Li On July 11, 2016, 6:43 p.m., Keta

Review Request 50392: AMBARI-17856: quicklink url protocol type check should allow type specified as HTTP and HTTPS

2016-07-25 Thread Di Li
-web/app/views/common/quick_view_link_view.js 17d7c04 ambari-web/test/views/common/quick_link_view_test.js f9a52b1 Diff: https://reviews.apache.org/r/50392/diff/ Testing --- updated unit tests Thanks, Di Li

Re: Review Request 49912: Blueprint registration step uses wrong format for property-attributes in Configuration

2016-07-22 Thread Di Li
> On July 13, 2016, 4:53 p.m., Di Li wrote: > > Ship It! committed, please close the record. - Di --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49912/#rev

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50539/#review143925 --- Ship it! Ship It! - Di Li On July 27, 2016, 11:06 p.m

Re: Review Request 50350: Config changes for Atlas in HDP 2.5 related to atlas.rest.address, atlas.cluster.name, etc

2016-07-26 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50350/#review143539 --- Ship it! Ship It! - Di Li On July 26, 2016, 1:22 a.m

Re: Review Request 51017: Error message displays mesage key instead of actual message

2016-08-12 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51017/#review145653 --- Ship it! Ship It! - Di Li On Aug. 12, 2016, 3:19 p.m

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-07-13 Thread Di Li
committed. Thanks. Di - Di Li On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-07-13 Thread Di Li
committed. Thanks. Di - Di Li On June 27, 2016, 11:20 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-28 Thread Di Li
python script against a cluster with only ambari server and agents installed. the python script prints out the same check results as the UI on the host registration page. Thanks, Di Li

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Di Li
ly, visit: https://reviews.apache.org/r/48855/#review140829 ----------- On July 5, 2016, 7:53 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Di Li
des. Check upgrade and downgrade history displayed on the UI 2. new unit tests 3. existing unit tests Thanks, Di Li

Re: Review Request 49387: Support password type for custom properties

2016-07-08 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review141280 --- please add Jonathan Hurley to the review - Di Li On June 29

Review Request 49895: AMBARI-17631: preinstall-check script should use AMBARI-AGENT REST API for the list of agents

2016-07-11 Thread Di Li
://reviews.apache.org/r/49895/diff/ Testing --- Run the script against a cluster just Ambari server and Ambari Agent nodes installed.verify the script can get the correct list of ambari agents. Thanks, Di Li

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Di Li
displayed on the UI 2. new unit tests Thanks, Di Li

Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-09 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50870/#review145255 --- Ship it! Ship It! - Di Li On Aug. 9, 2016, 5:15 p.m

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-06-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49287/#review139767 --- Ship it! Ship It! - Di Li On June 27, 2016, 11:20 p.m

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-06-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140043 --- Ship it! Ship It! - Di Li On June 29, 2016, 7:31 p.m

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-29 Thread Di Li
://reviews.apache.org/r/49324/diff/ Testing --- run python script against a cluster with only ambari server and agents installed. the python script prints out the same check results as the UI on the host registration page. Thanks, Di Li

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-29 Thread Di Li
i. - Di --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49324/#review140035 --- On June 29, 2016, 8:49 p.m., Di

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51055/#review145773 --- Ship it! Ship It! - Di Li On Aug. 12, 2016, 11:48 p.m

Re: Review Request 56235: findLatestServiceConfigsByStack query returns deleted config group

2017-02-03 Thread Di Li
> On Feb. 3, 2017, 1:28 p.m., Di Li wrote: > > Ship It! pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=ecfc951b5c8589b9225684c3ad2660cdb4ef4445 - Di --- This is an automatically generat

Review Request 56167: AMBARI-19804: Typo in preinstall_checker util script in the contrib project

2017-02-01 Thread Di Li
--- patched a cluster with the change, run preinstall_check.py script Thanks, Di Li

Re: Review Request 56235: findLatestServiceConfigsByStack query returns deleted config group

2017-02-03 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56235/#review164118 --- Ship it! Ship It! - Di Li On Feb. 2, 2017, 8:01 p.m

Review Request 55847: AMBARI-19657: Downgrade button does not work after restart Ambari server when upgrade wizard was left open

2017-01-23 Thread Di Li
ade wizard is opened and paused at a menu step. existing web UI unit tests. Thanks, Di Li

Re: Review Request 55789: Deleted configuration groups are displayed along with active group with is_current value set to true using Ambari API's

2017-01-23 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55789/#review162649 --- Please add Nate Cole for the review. - Di Li On Jan. 20, 2017

Re: Review Request 55789: Deleted configuration groups are displayed along with active group with is_current value set to true using Ambari API's

2017-01-23 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55789/#review162648 --- Ship it! Ship It! - Di Li On Jan. 20, 2017, 11:49 p.m

Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits

2017-01-23 Thread Di Li
d finalize the upgrade. Thanks, Di Li

Re: Review Request 55310: AMBARI-13324 automate creating Flume Keytab and principal

2017-01-24 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55310/#review162848 --- Ship it! Ship It! - Di Li On Jan. 24, 2017, 7:50 p.m., Shi

Re: Review Request 55935: When hiveserver2 LDAP authentication is enabled hive.server2.authentication.ldap.url property gets exported with hardcoded hostname

2017-01-26 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55935/#review163131 --- Ship it! Ship It! - Di Li On Jan. 25, 2017, 8:58 p.m

Review Request 55960: AMBARI-19715: HostCleanup remove ambari.repo when ambari.repo has repo ID that doesn't begin with word AMBARI

2017-01-25 Thread Di Li
as my ambari repo id. Thanks, Di Li

Re: Review Request 55993: On Capacity Scheduler view, click "*" button for "Node label Access" the 2nd time should de-select all node labels, but it doesn't

2017-01-26 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55993/#review163165 --- Ship it! Ship It! - Di Li On Jan. 26, 2017, 7:44 p.m

Re: Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.

2017-01-26 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55992/#review163164 --- Ship it! Ship It! - Di Li On Jan. 26, 2017, 7:19 p.m

Re: Review Request 56051: Workflow Manager View : Separate log file into its own directory similar to other views

2017-01-30 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56051/#review163523 --- Ship it! Ship It! - Di Li On Jan. 28, 2017, 8:32 a.m

Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits

2017-01-25 Thread Di Li
"IN_PROGESS". then be able to click the finalize and finalize the upgrade. Thanks, Di Li

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

2017-02-17 Thread Di Li
> On Feb. 17, 2017, 1:46 p.m., Di Li wrote: > > Hello Yuan Bo, Please add JIRA ID to the Bugs field and specify the proper > > branch for the fix. nm branch, just the JIRA ID - Di --- This is an automatically g

Re: Review Request 55817: AMBARI-19618 Make cohosted components configurable in metainfo.xml instead of hardcoding in UI

2017-02-22 Thread Di Li
A2 UI code needs updates accordingly. - Di Li On Feb. 22, 2017, 1:52 a.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

2017-02-17 Thread Di Li
the proper branch for the fix. - Di Li On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

2017-02-21 Thread Di Li
> On Feb. 14, 2017, 8 p.m., Di Li wrote: > > Ship It! pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=9e5c57e3e7ae4a8b3df51efcbddcdb97a1f7b398 Yuanbo, please close this rb reques

Re: Review Request 55817: AMBARI-19618 Make cohosted components configurable in metainfo.xml instead of hardcoding in UI

2017-02-22 Thread Di Li
> On Feb. 22, 2017, 9:21 p.m., Di Li wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml, > > line 109 > > <https://reviews.apache.org/r/55817/diff/3/?file=1641784#file1641784line109> > > > > Hello Yao, > >

Re: Review Request 56503: Cannot change user passwords

2017-02-09 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56503/#review164987 --- Ship it! Ship It! - Di Li On Feb. 9, 2017, 6:31 p.m

Re: Review Request 56627: Cluster deployment fails if cluster template has fewer host_groups than that in blueprint

2017-02-14 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56627/#review165566 --- Ship it! Ship It! - Di Li On Feb. 14, 2017, 12:37 a.m

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

2017-02-14 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56636/#review165564 --- Ship it! Ship It! - Di Li On Feb. 14, 2017, 3 a.m., Yuanbo

Re: Review Request 55586: Cannot change group/user privileges in list view if the user has VIEW.USER privilege

2017-01-23 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55586/#review162664 --- Ship it! Ship It! - Di Li On Jan. 23, 2017, 5:44 p.m

Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

2017-01-17 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review161901 --- Ship it! Ship It! - Di Li On Jan. 17, 2017, 5:53 p.m

Re: Review Request 55523: When viewing details of a group, the group type is sometimes empty

2017-01-16 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55523/#review161730 --- Ship it! Ship It! - Di Li On Jan. 13, 2017, 9:43 p.m

Review Request 55584: AMBARI-19537: Provide default value for yarn leveldb state store path

2017-01-16 Thread Di Li
/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py 23a25a0 Diff: https://reviews.apache.org/r/55584/diff/ Testing --- existing unit tests build rpms off trunk source code and deploy a cluster. Thanks, Di Li

Re: Review Request 54994: Enable alert scripts from stack extensions

2017-01-16 Thread Di Li
is delivered to trunk ? - Di Li On Dec. 22, 2016, 8:59 p.m., Diego Santesteban wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-18 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162146 --- Ship it! Ship It! - Di Li On Jan. 12, 2017, 12:33 a.m

Review Request 55774: AMBARI-19636: Provide default values for Kafka nofile and nproc limit properties

2017-01-20 Thread Di Li
/55774/diff/ Testing --- existing unit tests build ambari rpms with trunk code, install a trunk cluster. Thanks, Di Li

Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

2017-01-19 Thread Di Li
: https://reviews.apache.org/r/55720/diff/ Testing --- existing unit test patch trunk code build ambari rpms and install a trunk cluster Thanks, Di Li

Review Request 57146: AMBARI-20221 Ambari db schema update should be able to compare Ambari versions with build text

2017-02-28 Thread Di Li
/VersionUtils.java d3d8592 ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 821565e Diff: https://reviews.apache.org/r/57146/diff/ Testing --- existing unit tests, new unit tests, trunk cluster install Thanks, Di Li

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-01 Thread Di Li
nes 44 (patched) <https://reviews.apache.org/r/57168/#comment239412> please refer to my comments about not shipping empty files ambari-server/src/main/assemblies/server.xml Lines 257 (patched) <https://reviews.apache.org/r/57168/#comment239411> please refer to my comments about

Re: Review Request 57060: HostCleaup.py throws exception and exits when hostcheck_custom_actions.result not present

2017-02-27 Thread Di Li
k host operation submitted by the Ambari web UI during Host registration step. Current behavior is a hard fail, but I think it's still the correct behavior nontheless. - Di Li On Feb. 25, 2017, 3 a.m., Amr

Re: Review Request 51017: Error message displays mesage key instead of actual message

2016-09-02 Thread Di Li
> On Aug. 12, 2016, 7:53 p.m., Di Li wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Di. Hello Sangeeta, please close this one if it has been committed. - Di --- This is an automatically generate

Review Request 51604: AMBARI-11639: Ambari Admin View URL does not get properly parsed for custom versions

2016-09-02 Thread Di Li
js 59baf07 ambari-web/test/router_test.js e17c9e2 ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b7df818 Diff: https://reviews.apache.org/r/51604/diff/ Testing --- existing unit test added new unit test Thanks, Di Li

Re: Review Request 51578: AMBARI-18071: Ambari Files View needs to have ability to load security configurations

2016-09-08 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51578/#review148187 --- Ship it! Ship It! - Di Li On Sept. 7, 2016, 4:57 p.m., Keta

  1   2   3   4   5   >