Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136067 --- Ship it! Ship It! - Jonathan Hurley On June 3, 2016, 11:15

Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
/java/org/apache/ambari/server/state/ConfigHelper.java 488603a Diff: https://reviews.apache.org/r/48221/diff/ Testing --- Pending... Thanks, Jonathan Hurley

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
/ Testing (updated) --- mvn clean test Thanks, Jonathan Hurley

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
/JMXHostProviderTest.java 58975f7 Diff: https://reviews.apache.org/r/48221/diff/ Testing --- mvn clean test Thanks, Jonathan Hurley

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136108 --- On June 3, 2016, 5:30 p.m., Jonathan Hurley wrote: > > --- > This is an au

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
config. It was causing a massive amount of JSON and processing and DB hits. Instead, just go directly to the Cluster instance to get that data. - Jonathan Hurley On June 3, 2016, 4:06 p.m., Jonathan Hurley

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-08 Thread Jonathan Hurley
h need to be calculated) - Jonathan Hurley On June 8, 2016, 6:06 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-08 Thread Jonathan Hurley
/ambari_agent/RecoveryManager.py (line 329) <https://reviews.apache.org/r/48096/#comment201771> remove pass ambari-agent/src/main/python/ambari_agent/RecoveryManager.py (line 665) <https://reviews.apache.org/r/48096/#comment201772> remove pass - Jonathan Hurley On June 7, 201

Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-08 Thread Jonathan Hurley
Memory: 38M/645M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-09 Thread Jonathan Hurley
eviews.apache.org/r/48436/#review136800 --- On June 8, 2016, 2:24 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48392: Deadlock While Updating Stale Configuration Cache During Upgrade

2016-06-08 Thread Jonathan Hurley
-06-08T01:10:29-04:00 [INFO] Final Memory: 38M/645M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-06 Thread Jonathan Hurley
ide the loop. - Jonathan Hurley On June 6, 2016, 11:35 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-07 Thread Jonathan Hurley
/controller/jmx/JMXPropertyProvider.java (line 88) <https://reviews.apache.org/r/48284/#comment201515> Let's put some JavaDoc on this so people know what it's used for. - Jonathan Hurley On June 7, 2016, 7:47 a.m., Andrew Onischuk

Re: Review Request 48292: VDF: exception when trying to register -> add versions

2016-06-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48292/#review136465 --- Ship it! Ship It! - Jonathan Hurley On June 6, 2016, 5:34

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 2:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > <https://reviews.apache.org/r/48287/diff/1/?file=1407038#file1407038line664> > > > > I know thi

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-06 Thread Jonathan Hurley
> On June 2, 2016, 10:42 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/RecoveryManager.py, lines 323-334 > > <https://reviews.apache.org/r/48096/diff/1/?file=1402778#file1402778line323> > > > > This logic is getting a bit "i

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
--- > > (Updated June 6, 2016, 1:20 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-17068 > https://issues.apache.org/jira/browse/AMBARI-17068 > > > Repository: ambari > > > Description > ---

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
tically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48287/ > --- > > (Updated June 6, 2016, 1:20 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-17

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-06 Thread Jonathan Hurley
- 33) <https://reviews.apache.org/r/48273/#comment201332> Doesn't Ranger start before HDFS? - Jonathan Hurley On June 6, 2016, 11:26 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Jonathan Hurley
> On June 12, 2016, 7:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > <https://reviews.apache.org/r/48589/diff/1/?file=1415725#file1415725line410> > > > > This still seems

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Jonathan Hurley
> On June 12, 2016, 7:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > <https://reviews.apache.org/r/48589/diff/1/?file=1415725#file1415725line410> > > > > This still seems

Re: Review Request 48562: Allow option to skip duplicate URL checking when creating VDF

2016-06-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48562/#review137056 --- Ship it! Ship It! - Jonathan Hurley On June 10, 2016, 2:26

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Jonathan Hurley
-services/FALCON/0.5.0.2.1/package/scripts/falcon.py (lines 146 - 149) <https://reviews.apache.org/r/48561/#comment202193> Instead of executing this under "supports_falcon_extensions" should it be under an `if not params.supports_data_mirroring:` - Jonathan Hur

Re: Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48498/#review136870 --- Ship it! Ship It! - Jonathan Hurley On June 9, 2016, 12:49

Re: Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-09 Thread Jonathan Hurley
Memory: 38M/645M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48205/#review136135 --- Ship it! Ship It! - Jonathan Hurley On June 3, 2016, 9:56

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-03 Thread Jonathan Hurley
ms_linux.py (line 73) <https://reviews.apache.org/r/48234/#comment201151> Maybe use os.path.join here for these? - Jonathan Hurley On June 3, 2016, 6:47 p.m., Alejandro Fernandez wrote: > > --- > This is an automatical

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48162/#review136059 --- Ship it! Ship It! - Jonathan Hurley On June 2, 2016, 12:38

Re: Review Request 48181: Service admin and cluster operator can't modify service configs through API

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48181/#review136060 --- Ship it! Ship It! - Jonathan Hurley On June 2, 2016, 2:34

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-25 Thread Jonathan Hurley
urces/Ambari-DDL-SQLServer-CREATE.sql (line 1296) <https://reviews.apache.org/r/47783/#comment199737> The description says that both the cluster operator and the admin need this permission, but I only see if for the operator. Does the admin have it by default already? - Jonathan Hurley

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-11 Thread Jonathan Hurley
rg/r/48549/#review137042 --- On June 10, 2016, 8:47 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48549/ > -----

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Jonathan Hurley
<https://reviews.apache.org/r/48589/#comment202320> This still seems like a warning which we want. It means that there was a name service defined, but no alias properties. If a name service is defined, then shouldn't there always be valid aliases? - Jonathan Hurley On June 11, 2016

Re: Review Request 48657: Allow option to skip duplicate URL checking when creating VDF (part 2)

2016-06-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48657/#review137342 --- Ship it! Ship It! - Jonathan Hurley On June 13, 2016, 1:57

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

2016-06-13 Thread Jonathan Hurley
n the method? - Jonathan Hurley On June 13, 2016, 1:34 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-14 Thread Jonathan Hurley
is will be the first time that we've ever special-cased anything in the alerts framework. There has to be a better way. If you want to check for a specific property, then we should extend the alert definition's `uri` element to indicate that there is a value which can be checked for HA mode.

Re: Review Request 48629: AMBARI-17189 : Change in Atlas authorization from class based to value based

2016-06-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48629/#review137500 --- Ship it! Ship It! - Jonathan Hurley On June 13, 2016, 6:47

Re: Review Request 48690: org.apache.ambari.server.state.cluster.ClusterTest.testTransitionNonReportableHost fails intermittently on trunk.

2016-06-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48690/#review137511 --- Ship it! Ship It! - Jonathan Hurley On June 14, 2016, 10:33

Re: Review Request 48730: AMBARI-17250 : Use right principals for Hbase Master in Kerberos enabled Ranger Hbase Plugin

2016-06-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48730/#review137741 --- Ship it! Ship It! - Jonathan Hurley On June 15, 2016, 10:26

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

2016-06-13 Thread Jonathan Hurley
; Review request for Ambari, Dmytro Sen and Jonathan Hurley. > > > Bugs: AMBARI-17202 > https://issues.apache.org/jira/browse/AMBARI-17202 > > > Repository: ambari > > > Description > --- > > When upgrading from earlier versions of Ambari, the alert defini

Re: Review Request 48640: Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to SERVICE.ADMINISTRATOR role and above

2016-06-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48640/#review137361 --- Ship it! Ship It! - Jonathan Hurley On June 13, 2016, 2:50

Re: Review Request 48557: Fixed implementation of on-ambari-upgrade support. Patch 2: add logic for ambari-upgrade

2016-06-13 Thread Jonathan Hurley
/state/PropertyUpgradeBehavior.java (line 36) <https://reviews.apache.org/r/48557/#comment202507> Can we initialie these in their declaration since they are optional? - Jonathan Hurley On June 13, 2016, 9:22 a.m., Dmitro Lisnichenko

Re: Review Request 48204: HDP-UTILs Repo URL validation/save fails

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48204/#review136061 --- Ship it! Ship It! - Jonathan Hurley On June 3, 2016, 8:43

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Jonathan Hurley
s line seems to indicate that you're also packaging up the original com.google.common.* classes in your uber JAR. I would think that this is not desired since you're already relocating (shading) them. - Jonathan Hurley On June 3, 2016, 9:54 a.m., Dmytro Sen

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48273/#review136503 --- Ship it! Ship It! - Jonathan Hurley On June 6, 2016, 11:26

Re: Review Request 48415: Authorizations given to role-based principals must be dereferenced upon user login

2016-06-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48415/#review136645 --- Ship it! Ship It! - Jonathan Hurley On June 8, 2016, 9:53

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Jonathan Hurley
t want to make sure we can't possible be deleting ZK data more than once. - Jonathan Hurley On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

2016-05-26 Thread Jonathan Hurley
/ambari/server/state/cluster/ClusterImpl.java (lines 1222 - 1224) <https://reviews.apache.org/r/47867/#comment199987> Nice catch on this one - Jonathan Hurley On May 26, 2016, 6:47 a.m., Nate Cole

Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
bari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
024f ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
rver/controller/metrics/RestMetricsPropertyProviderTest.java f78024f ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
024f ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
024f ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
, visit: https://reviews.apache.org/r/47961/#review135268 --- On May 27, 2016, 1:27 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
not sure how I failed to find the class. RB's fault... it wasn't showing it unless I did a different kind of patch. - Jonathan ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47961/#re

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
rver/controller/metrics/RestMetricsPropertyProviderTest.java f78024f ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
rver/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java f47068c ambari-server/src/test/java/org/apache/ambari/server/utils/SynchronousThreadPoolExecutor.java PRE-CREATION Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
il. To reply, visit: https://reviews.apache.org/r/47961/#review135301 ------- On May 27, 2016, 3:18 p.m., Jonathan Hurley wrote: > > --- > This is an automat

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
values because they are quite important, then changing it at-will is very frowned upon. I would like to keep this test, but I can also add tests for "smart" values. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47961/#review135316 --

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
E [INFO] [INFO] Total time: 44:21 min [INFO] Finished at: 2016-05-27T17:18:06-04:00 [INFO] Final Memory: 37M/658M [INFO] Thanks, Jonathan Hurley

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Jonathan Hurley
java f47068c ambari-server/src/test/java/org/apache/ambari/server/utils/SynchronousThreadPoolExecutor.java PRE-CREATION Diff: https://reviews.apache.org/r/47961/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

2016-05-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47783/#review135246 --- Ship it! Ship It! - Jonathan Hurley On May 27, 2016, 9:52

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-02 Thread Jonathan Hurley
org/r/48096/#comment200961> Not needed. - Jonathan Hurley On May 31, 2016, 6:23 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jonathan Hurley
/HDP/2.0.6/configuration/cluster-env.xml (lines 155 - 165) <https://reviews.apache.org/r/48157/#comment200954> I thought we had a way of saying that you can't override a property ... marking it final? - Jonathan Hurley On June 2, 2016, 3:36 a.m., Jayush Luniya

Re: Review Request 48036: Service name shown instead of Host name on popup

2016-06-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48036/#review135932 --- Ship it! Ship It! - Jonathan Hurley On June 1, 2016, 12:01

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47871/#review135055 --- Ship it! Ship It! - Jonathan Hurley On May 26, 2016, 4:03

Re: Review Request 47913: VDF builder script and XSD should be updated for package-version changes

2016-05-26 Thread Jonathan Hurley
) <https://reviews.apache.org/r/47913/#comment200030> Maybe explain that it must be before, otherwise the XSD validation will fail. - Jonathan Hurley On May 26, 2016, 3:46 p.m., Nate Cole wrote: > > --- > This is a

Re: Review Request 47978: VDF should use package-version for the os, not the release

2016-06-01 Thread Jonathan Hurley
> On June 1, 2016, 9:03 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java, > > lines 113-114 > > <https://reviews.apache.org/r/47978/diff/1/?file=1399678#file1399678line113> > > >

Re: Review Request 47978: VDF should use package-version for the os, not the release

2016-06-01 Thread Jonathan Hurley
e node has a different OS (like Suse12) then this will fail. ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java (lines 113 - 114) <https://reviews.apache.org/r/47978/#comment200839> m_ - Jonathan Hurley On May 31, 2016, 4:13 p.m., Nat

Review Request 48708: Namenode start step failed during EU with RetriableException

2016-06-14 Thread Jonathan Hurley
ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py 18e61fb ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 635f159 Diff: https://reviews.apache.org/r/48708/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

2016-06-14 Thread Jonathan Hurley
<https://reviews.apache.org/r/48708/#comment202772> Because we're writing out directories on startup no matter what, we need to ensure NN is out of SafeMode - that's the major logic change. - Jonathan Hurley On June 14, 2016, 5:33 p.m., Jonathan

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

2016-06-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48685/#review137735 --- Ship it! Ship It! - Jonathan Hurley On June 15, 2016, 10:18

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

2016-06-22 Thread Jonathan Hurley
/controller/internal/ClusterKerberosDescriptorResourceProvider.java (line 247) <https://reviews.apache.org/r/49029/#comment204231> isBlank instead? - Jonathan Hurley On June 22, 2016, 10:17 a.m., Robert Levas

Review Request 49093: Unable To Delete A Service After Upgrade Due To Foreign Key Violation

2016-06-22 Thread Jonathan Hurley
/reviews.apache.org/r/49093/diff/ Testing --- mvn clean test Thanks, Jonathan Hurley

Review Request 49086: hiveserver2-site.xml not created

2016-06-22 Thread Jonathan Hurley
Total errors:0 Total failures:0 OK Thanks, Jonathan Hurley

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49072/#review139062 --- Can we get some unit tests to cover this case? - Jonathan Hurley

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/#review137632 --- Ship it! Ship It! - Jonathan Hurley On June 14, 2016, 10:15

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137633 --- Ship it! Ship It! - Jonathan Hurley On June 14, 2016, 7:12

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Jonathan Hurley
/{jdbc_jar_name}") if hive2_jdbc_target is not None else None ``` Basically, if you're in an upgrade, write out the JDBC connector to the "versioned" location (and don't use current) - Jonathan Hurley On June 16, 2016, 5:

Re: Review Request 48805: AMBARI-17280. RU to write out client configs that are dependencies of Hive, ATS, and Oozie during upgrades that change configs

2016-06-17 Thread Jonathan Hurley
s 188 - 193) <https://reviews.apache.org/r/48805/#comment203424> I'm a little worried about this kind of logic. You're saying that Oozie requires tez-site configs to be updated. Yet, the execute-stage is scoped for a TEZ/TEZ_CLIENT. This actually needs to run on Oozie, no? - Jonatha

Re: Review Request 48844: Operations during upgrade are permitted by all roles

2016-06-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48844/#review138590 --- Ship it! Ship It! - Jonathan Hurley On June 17, 2016, 6:16

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-21 Thread Jonathan Hurley
the socket command to send. ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py (lines 133 - 135) <https://reviews.apache.org/r/48972/#comment204037> We don't hardcode specific workarounds into the alerts framework. It's not maintainable. - Jonathan Hurley On June 20, 2016

Re: Review Request 49028: Alert mapreduce_history_server_process fails after enabling SSL

2016-06-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49028/#review138858 --- Ship it! Ship It! - Jonathan Hurley On June 21, 2016, 11:40

Re: Review Request 48805: AMBARI-17280. RU to write out client configs that are dependencies of Hive, ATS, and Oozie during upgrades that change configs

2016-06-21 Thread Jonathan Hurley
ain/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml (line 153) <https://reviews.apache.org/r/48805/#comment204043> The SERVICE/COMPONENT string is too easy to mess up; we should have distinct service and component attributes - Jonathan Hurley On June 20, 2016, 9:12 p

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-21 Thread Jonathan Hurley
> On June 3, 2016, 11:20 a.m., Jonathan Hurley wrote: > > Ship It! Ping. This review is about ~ 3 weeks old. Was it committed? Can we close it out? - Jonathan --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 48805: AMBARI-17280. RU to write out client configs that are dependencies of Hive, ATS, and Oozie during upgrades that change configs

2016-06-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48805/#review138932 --- Ship it! Ship It! - Jonathan Hurley On June 21, 2016, 4:02

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48734/#review138935 --- Ship it! Ship It! - Jonathan Hurley On June 17, 2016, 6:45

Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

2016-06-22 Thread Jonathan Hurley
--- Used a mixture of file:// and normal paths. Thanks, Jonathan Hurley

Re: Review Request 49106: AuthorizationHelperTest.testAuthName may fail due to residual SecurityContext from previously executed test cases.

2016-06-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49106/#review139140 --- Ship it! Ship It! - Jonathan Hurley On June 22, 2016, 5:22

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

2016-06-22 Thread Jonathan Hurley
/test_alert_datanode_unmounted_data_dir.py c9bd187 Diff: https://reviews.apache.org/r/49104/diff/ Testing --- Used a mixture of file:// and normal paths. Thanks, Jonathan Hurley

Re: Review Request 48817: Hive Metastore Upgrade Fails Because Of Missing Hive Interactive Directory

2016-06-16 Thread Jonathan Hurley
errors:0 Total failures:0 OK Thanks, Jonathan Hurley

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-17 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48549/#review138238 --- Ship it! Ship It! - Jonathan Hurley On June 16, 2016, 7:57

Review Request 49213: Ambari Is Initializing the Metastore Using the Wrong schematool Binary on HDP 2.5

2016-06-24 Thread Jonathan Hurley
2.1.0 | ++++ 1 row in set (0.00 sec) Thanks, Jonathan Hurley

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-06-25 Thread Jonathan Hurley
nclude this optional information. - Jonathan Hurley On June 25, 2016, 9:54 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44597: Postgres And c3p0 Queries Can Hang Ambari On Large Queries

2016-03-09 Thread Jonathan Hurley
emory: 51M/740M [INFO] Thanks, Jonathan Hurley

Re: Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

2016-03-18 Thread Jonathan Hurley
g from/to? - Jonathan Hurley On March 16, 2016, 5:15 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

2016-03-18 Thread Jonathan Hurley
/services/stackadvisor/StackAdvisorBlueprintProcessor.java (line 224) <https://reviews.apache.org/r/44916/#comment186261> How can this ever be null? An empty config type!? - Jonathan Hurley On March 16, 2016, 4:55 p.m., Robert Levas

Re: Review Request 44983: Service version display should be based on Version Definition

2016-03-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44983/#review124177 --- Ship it! Ship It! - Jonathan Hurley On March 17, 2016, 5:53

Re: Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

2016-03-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44886/#review124008 --- Ship it! Ship It! - Jonathan Hurley On March 17, 2016, 6:13

  1   2   3   4   5   6   7   8   9   10   >