---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47730/#review136067
---
Ship it!
Ship It!
- Jonathan Hurley
On June 3, 2016, 11:15
/java/org/apache/ambari/server/state/ConfigHelper.java
488603a
Diff: https://reviews.apache.org/r/48221/diff/
Testing
---
Pending...
Thanks,
Jonathan Hurley
/
Testing (updated)
---
mvn clean test
Thanks,
Jonathan Hurley
/JMXHostProviderTest.java
58975f7
Diff: https://reviews.apache.org/r/48221/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/48221/#review136108
---
On June 3, 2016, 5:30 p.m., Jonathan Hurley wrote:
>
> ---
> This is an au
config.
It was causing a massive amount of JSON and processing and DB hits.
Instead, just go directly to the Cluster instance to get that data.
- Jonathan Hurley
On June 3, 2016, 4:06 p.m., Jonathan Hurley
/ambari_agent/RecoveryManager.py (line 329)
<https://reviews.apache.org/r/48096/#comment201771>
remove pass
ambari-agent/src/main/python/ambari_agent/RecoveryManager.py (line 665)
<https://reviews.apache.org/r/48096/#comment201772>
remove pass
- Jonathan Hurley
On June 7, 201
eviews.apache.org/r/48436/#review136800
---
On June 8, 2016, 2:24 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To re
/controller/jmx/JMXPropertyProvider.java
(line 88)
<https://reviews.apache.org/r/48284/#comment201515>
Let's put some JavaDoc on this so people know what it's used for.
- Jonathan Hurley
On June 7, 2016, 7:47 a.m., Andrew Onischuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48292/#review136465
---
Ship it!
Ship It!
- Jonathan Hurley
On June 6, 2016, 5:34
> On June 6, 2016, 2:04 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py,
> > lines 664-666
> > <https://reviews.apache.org/r/48287/diff/1/?file=1407038#file1407038line664>
> >
> > I know thi
> On June 6, 2016, 1:31 p.m., Nate Cole wrote:
> > I only see two changes here, and it's just logging. Was there some missed
> > files?
>
> Jonathan Hurley wrote:
> Same - only 2 changes and they are for logging.
>
> Dmytro Grinenko wrote:
> no
tically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48287/
> ---
>
> (Updated June 6, 2016, 1:20 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-17
- 33)
<https://reviews.apache.org/r/48273/#comment201332>
Doesn't Ranger start before HDFS?
- Jonathan Hurley
On June 6, 2016, 11:26 a.m., Gautam Borad wrote:
>
> ---
> This is an automatically generated e-mai
> On June 12, 2016, 7:06 a.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines
> > 410-411
> > <https://reviews.apache.org/r/48589/diff/1/?file=1415725#file1415725line410>
> >
> > This still seems
> On June 12, 2016, 7:06 a.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines
> > 410-411
> > <https://reviews.apache.org/r/48589/diff/1/?file=1415725#file1415725line410>
> >
> > This still seems
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48562/#review137056
---
Ship it!
Ship It!
- Jonathan Hurley
On June 10, 2016, 2:26
-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
(lines 146 - 149)
<https://reviews.apache.org/r/48561/#comment202193>
Instead of executing this under "supports_falcon_extensions" should it be
under an
`if not params.supports_data_mirroring:`
- Jonathan Hur
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48498/#review136870
---
Ship it!
Ship It!
- Jonathan Hurley
On June 9, 2016, 12:49
Memory: 38M/645M
[INFO] ----
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48205/#review136135
---
Ship it!
Ship It!
- Jonathan Hurley
On June 3, 2016, 9:56
ms_linux.py
(line 73)
<https://reviews.apache.org/r/48234/#comment201151>
Maybe use os.path.join here for these?
- Jonathan Hurley
On June 3, 2016, 6:47 p.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatical
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/#review136059
---
Ship it!
Ship It!
- Jonathan Hurley
On June 2, 2016, 12:38
urces/Ambari-DDL-SQLServer-CREATE.sql (line 1296)
<https://reviews.apache.org/r/47783/#comment199737>
The description says that both the cluster operator and the admin need this
permission, but I only see if for the operator. Does the admin have it by
default already?
- Jonathan Hurley
rg/r/48549/#review137042
---
On June 10, 2016, 8:47 a.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> -----
<https://reviews.apache.org/r/48589/#comment202320>
This still seems like a warning which we want. It means that there was a
name service defined, but no alias properties. If a name service is defined,
then shouldn't there always be valid aliases?
- Jonathan Hurley
On June 11, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48657/#review137342
---
Ship it!
Ship It!
- Jonathan Hurley
On June 13, 2016, 1:57
n the method?
- Jonathan Hurley
On June 13, 2016, 1:34 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
is will be the first time that we've ever special-cased anything
in the alerts framework. There has to be a better way. If you want to check for
a specific property, then we should extend the alert definition's `uri` element
to indicate that there is a value which can be checked for HA mode.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48629/#review137500
---
Ship it!
Ship It!
- Jonathan Hurley
On June 13, 2016, 6:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48690/#review137511
---
Ship it!
Ship It!
- Jonathan Hurley
On June 14, 2016, 10:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48730/#review137741
---
Ship it!
Ship It!
- Jonathan Hurley
On June 15, 2016, 10:26
; Review request for Ambari, Dmytro Sen and Jonathan Hurley.
>
>
> Bugs: AMBARI-17202
> https://issues.apache.org/jira/browse/AMBARI-17202
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When upgrading from earlier versions of Ambari, the alert defini
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48640/#review137361
---
Ship it!
Ship It!
- Jonathan Hurley
On June 13, 2016, 2:50
/state/PropertyUpgradeBehavior.java
(line 36)
<https://reviews.apache.org/r/48557/#comment202507>
Can we initialie these in their declaration since they are optional?
- Jonathan Hurley
On June 13, 2016, 9:22 a.m., Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48204/#review136061
---
Ship it!
Ship It!
- Jonathan Hurley
On June 3, 2016, 8:43
s line seems to indicate that you're also packaging up the
original com.google.common.* classes in your uber JAR. I would think that this
is not desired since you're already relocating (shading) them.
- Jonathan Hurley
On June 3, 2016, 9:54 a.m., Dmytro Sen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48273/#review136503
---
Ship it!
Ship It!
- Jonathan Hurley
On June 6, 2016, 11:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48415/#review136645
---
Ship it!
Ship It!
- Jonathan Hurley
On June 8, 2016, 9:53
t want to
make sure we can't possible be deleting ZK data more than once.
- Jonathan Hurley
On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/ambari/server/state/cluster/ClusterImpl.java
(lines 1222 - 1224)
<https://reviews.apache.org/r/47867/#comment199987>
Nice catch on this one
- Jonathan Hurley
On May 26, 2016, 6:47 a.m., Nate Cole
bari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
f47068c
Diff: https://reviews.apache.org/r/47961/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
024f
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
f47068c
Diff: https://reviews.apache.org/r/47961/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
rver/controller/metrics/RestMetricsPropertyProviderTest.java
f78024f
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
f47068c
Diff: https://reviews.apache.org/r/47961/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
024f
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
f47068c
Diff: https://reviews.apache.org/r/47961/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
, visit:
https://reviews.apache.org/r/47961/#review135268
---
On May 27, 2016, 1:27 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
not sure how I failed to find the class.
RB's fault... it wasn't showing it unless I did a different kind of patch.
- Jonathan
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47961/#re
rver/controller/metrics/RestMetricsPropertyProviderTest.java
f78024f
ambari-server/src/test/java/org/apache/ambari/server/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
f47068c
Diff: https://reviews.apache.org/r/47961/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
rver/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java
f47068c
ambari-server/src/test/java/org/apache/ambari/server/utils/SynchronousThreadPoolExecutor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47961/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
il. To reply, visit:
https://reviews.apache.org/r/47961/#review135301
-------
On May 27, 2016, 3:18 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automat
values because they are quite
important, then changing it at-will is very frowned upon. I would like to keep
this test, but I can also add tests for "smart" values.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47961/#review135316
--
E
[INFO]
[INFO] Total time: 44:21 min
[INFO] Finished at: 2016-05-27T17:18:06-04:00
[INFO] Final Memory: 37M/658M
[INFO]
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47783/#review135246
---
Ship it!
Ship It!
- Jonathan Hurley
On May 27, 2016, 9:52
org/r/48096/#comment200961>
Not needed.
- Jonathan Hurley
On May 31, 2016, 6:23 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail
/HDP/2.0.6/configuration/cluster-env.xml
(lines 155 - 165)
<https://reviews.apache.org/r/48157/#comment200954>
I thought we had a way of saying that you can't override a property ...
marking it final?
- Jonathan Hurley
On June 2, 2016, 3:36 a.m., Jayush Luniya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48036/#review135932
---
Ship it!
Ship It!
- Jonathan Hurley
On June 1, 2016, 12:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135055
---
Ship it!
Ship It!
- Jonathan Hurley
On May 26, 2016, 4:03
)
<https://reviews.apache.org/r/47913/#comment200030>
Maybe explain that it must be before, otherwise the XSD validation will
fail.
- Jonathan Hurley
On May 26, 2016, 3:46 p.m., Nate Cole wrote:
>
> ---
> This is a
> On June 1, 2016, 9:03 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java,
> > lines 113-114
> > <https://reviews.apache.org/r/47978/diff/1/?file=1399678#file1399678line113>
> >
>
e node has a
different OS (like Suse12) then this will fail.
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
(lines 113 - 114)
<https://reviews.apache.org/r/47978/#comment200839>
m_
- Jonathan Hurley
On May 31, 2016, 4:13 p.m., Nat
ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py
18e61fb
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
635f159
Diff: https://reviews.apache.org/r/48708/diff/
Testing
---
PENDING
Thanks,
Jonathan Hurley
<https://reviews.apache.org/r/48708/#comment202772>
Because we're writing out directories on startup no matter what, we need to
ensure NN is out of SafeMode - that's the major logic change.
- Jonathan Hurley
On June 14, 2016, 5:33 p.m., Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48685/#review137735
---
Ship it!
Ship It!
- Jonathan Hurley
On June 15, 2016, 10:18
/controller/internal/ClusterKerberosDescriptorResourceProvider.java
(line 247)
<https://reviews.apache.org/r/49029/#comment204231>
isBlank instead?
- Jonathan Hurley
On June 22, 2016, 10:17 a.m., Robert Levas
/reviews.apache.org/r/49093/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review139062
---
Can we get some unit tests to cover this case?
- Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48589/#review137632
---
Ship it!
Ship It!
- Jonathan Hurley
On June 14, 2016, 10:15
/{jdbc_jar_name}") if hive2_jdbc_target
is not None else None
```
Basically, if you're in an upgrade, write out the JDBC connector to the
"versioned" location (and don't use current)
- Jonathan Hurley
On June 16, 2016, 5:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48844/#review138590
---
Ship it!
Ship It!
- Jonathan Hurley
On June 17, 2016, 6:16
the socket command to
send.
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py (lines 133 - 135)
<https://reviews.apache.org/r/48972/#comment204037>
We don't hardcode specific workarounds into the alerts framework. It's not
maintainable.
- Jonathan Hurley
On June 20, 2016
ain/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml (line
153)
<https://reviews.apache.org/r/48805/#comment204043>
The SERVICE/COMPONENT string is too easy to mess up; we should have
distinct service and component attributes
- Jonathan Hurley
On June 20, 2016, 9:12 p
> On June 3, 2016, 11:20 a.m., Jonathan Hurley wrote:
> > Ship It!
Ping. This review is about ~ 3 weeks old. Was it committed? Can we close it out?
- Jonathan
---
This is an automatically generated e-mail. To reply, vis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48805/#review138932
---
Ship it!
Ship It!
- Jonathan Hurley
On June 21, 2016, 4:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48734/#review138935
---
Ship it!
Ship It!
- Jonathan Hurley
On June 17, 2016, 6:45
---
Used a mixture of file:// and normal paths.
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49106/#review139140
---
Ship it!
Ship It!
- Jonathan Hurley
On June 22, 2016, 5:22
/test_alert_datanode_unmounted_data_dir.py
c9bd187
Diff: https://reviews.apache.org/r/49104/diff/
Testing
---
Used a mixture of file:// and normal paths.
Thanks,
Jonathan Hurley
errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138238
---
Ship it!
Ship It!
- Jonathan Hurley
On June 16, 2016, 7:57
2.1.0 |
++++
1 row in set (0.00 sec)
Thanks,
Jonathan Hurley
nclude this optional information.
- Jonathan Hurley
On June 25, 2016, 9:54 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
g from/to?
- Jonathan Hurley
On March 16, 2016, 5:15 a.m., Gautam Borad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 224)
<https://reviews.apache.org/r/44916/#comment186261>
How can this ever be null? An empty config type!?
- Jonathan Hurley
On March 16, 2016, 4:55 p.m., Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44983/#review124177
---
Ship it!
Ship It!
- Jonathan Hurley
On March 17, 2016, 5:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45030/#review124205
---
Ship it!
Ship It!
- Jonathan Hurley
On March 18, 2016, 11
test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
17c52d2
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 2dceccc
ambari-web/app/utils/ajax/ajax.js 29d0715
Diff: https://reviews.apache.org/r/45035/diff/
Testing
---
Pending...
.py
> e4c8c9c
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
> 02905ec
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
> 905802f
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
> 2dceccc
> ambari-web/app/utils/ajax/ajax.js 29d0715
>
> Diff: https://reviews.apache.org/r/45035/diff/
>
>
> Testing
> ---
>
> Pending...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
/controller/internal/BlueprintConfigurationProcessor.java
(line 135)
<https://reviews.apache.org/r/45030/#comment186639>
Instead of 'special' can we call this something more meaningful; like
`BIND_ALL_IP_ADDRESS`?
- Jonathan Hurley
On March 18, 2016, 9:45 a.m., Dmytro Sen
ff: https://reviews.apache.org/r/44831/diff/
Testing
---
--
Total run:924
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
n/java/org/apache/ambari/server/api/query/JpaSortBuilder.java
8021346
Diff: https://reviews.apache.org/r/44597/diff/
Testing
---
Executed problematic queries against a massive database. Problem is resolved in
test environment.
Unit Tests Pending
Thanks,
Jonathan Hurley
g
Thanks,
Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45432/#review125901
---
Ship it!
Ship It!
- Jonathan Hurley
On March 29, 2016, 11
<https://reviews.apache.org/r/45347/#comment189043>
Expensive to construct; use an injected singleton since they are
thread-safe.
- Jonathan Hurley
On March 29, 2016, 10:17 p.m., Nahappan Somasundaram wrote:
>
> ---
> Thi
clean test
Thanks,
Jonathan Hurley
inject it.
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java
(line 99)
<https://reviews.apache.org/r/45893/#comment191039>
Same as above; inject.
- Jonathan Hurley
On April 7, 2016, 4:26 p.m., Alejandro Fer
> On April 11, 2016, 8:25 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> > lines 1148-1161
> > <https://reviews.apache.org/r/45914/diff/2/?file=1337550#file1337550line1148>
> >
>
/test/java/org/apache/ambari/server/state/services/CachedAlertFlushServiceTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/46136/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
llib2 handles more for you automatically, like redirects and stuff.
If there's a good reason or you don't think urllib2 is a good fit, then you
can disregard this.
- Jonathan Hurley
On April 7, 2016, 11:24 a.m.
1 - 100 of 1355 matches
Mail list logo