Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

--- On March 9, 2016, 8:59 p.m., Shantanu Mundkur wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44525/ > -

Review Request 44594: Fix ordering of Alter table calls which could result in Region Close issue

/diff/ Testing --- Unit tests passed. No funtional change. Thanks, Sid Wagle

Re: Review Request 44594: Fix ordering of Alter table calls which could result in Region Close issue

/ITPhoenixHBaseAccessor.java e3e037a Diff: https://reviews.apache.org/r/44594/diff/ Testing --- Unit tests passed. No funtional change. Thanks, Sid Wagle

Re: Review Request 44597: Postgres And c3p0 Queries Can Hang Ambari On Large Queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44597/#review122845 --- Ship it! Ship It! - Sid Wagle On March 9, 2016, 10:30 p.m

Re: Review Request 44594: Fix ordering of Alter table calls which could result in Region Close issue

funtional change. Thanks, Sid Wagle

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122872 --- Ship it! Ship It! - Sid Wagle On March 9, 2016, 8:59 p.m

Re: Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44811/#review123545 --- Ship it! Ship It! - Sid Wagle On March 14, 2016, 11:47 p.m

Review Request 44816: Fix new HDFS AMS alerts to account for NN rpc ports

://reviews.apache.org/r/44816/diff/ Testing --- Manually verified, python unit tests passed. Thanks, Sid Wagle

Review Request 44817: Grafana password is required field after upgrade from 2.2.0 to 2.2.2

-- Total run:908 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

OK -- Total run:12 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

/44941/diff/ Testing --- Manually verified. -- Ran 12 tests in 0.020s OK -- Total run:12 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

code? - Sid Wagle On March 16, 2016, 4:59 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 44916: StackAdvisor needs to set config map for ams-grafana-env to meet non-null expectations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44916/#review123893 --- Ship it! Ship It! - Sid Wagle On March 16, 2016, 4:59 p.m

Re: Review Request 45125: 'ambari-server check-database' has errors after upgrade to ambari 2.2.2.0 [grafana errors]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45125/#review124647 --- Ship it! Ship It! - Sid Wagle On March 21, 2016, 8:12 p.m

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

end. Add a config to disable interpolation all together. - Sid Wagle On March 22, 2016, 5:08 a.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45150/#review124866 --- Ship it! Ship It! - Sid Wagle On March 22, 2016, 7:44 p.m

Re: Review Request 45215: HDFS Alerts for AMS Throw 'invalid literal for int() with base 10: '50.0''

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45215/#review125036 --- Ship it! Ship It! - Sid Wagle On March 23, 2016, 3:08 p.m

Re: Review Request 45250: AMBARI-15540 : NAMENODE critical alert is present [Percentage standard deviation] after upgrade from 2.0.2/ 2.2.1.0 etc to 2.2.2.0 and disabling security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45250/#review125116 --- Ship it! Ship It! - Sid Wagle On March 23, 2016, 8:26 p.m

Re: Review Request 45395: Ambari API does not return HDFS RPC metrics based on ports

81) <https://reviews.apache.org/r/45395/#comment188660> Decription doesn't match function. - Sid Wagle On March 28, 2016, 6:19 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 45465: Support distributed aggregation for multiple AMS instances

tainfo.xml b06f55b ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 7b2d797 Diff: https://reviews.apache.org/r/45465/diff/ Testing --- Manually verified. Thanks, Sid Wagle

Re: Review Request 45465: Support distributed aggregation for multiple AMS instances

printed has well defined tracebility of which thread it came from. I have done same thing for jstack so we can differentiate based on thread name. - Sid --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request 45447: AMBARI-15621 : Cluster Second aggregator taking more than 2 mins to execute on large clusters, thereby causing lag.

-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregator.java (line 105) <https://reviews.apache.org/r/45447/#comment189037> Should be consistent time use for cal and logged. - Sid Wagle On March 29, 2016, 9:

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

c/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java (line 242) <https://reviews.apache.org/r/45518/#comment190031> This should be skipped if the denomintor is not incremented. - Sid Wagle On March

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45518/#review127000 --- Ship it! Ship It! - Sid Wagle On April 5, 2016, 12:11 a.m

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

isit: > https://reviews.apache.org/r/45739/ > --- > > (Updated April 5, 2016, 11:09 a.m.) > > > Review request for Ambari, Dmytro Sen and Sid Wagle. > > > Bugs: AMBARI-15710 > https://issues.apache.org/jira/browse/AMBARI-15710 > >

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45739/#review127113 --- Ship it! Ship It! - Sid Wagle On April 5, 2016, 11:09 a.m

Re: Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java (line 245) <https://reviews.apache.org/r/45772/#comment190382> No need to braces. - Sid Wagle On April 5, 2016, 8:14 p.m., Aravindan V

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45845/#review127511 --- No unit test changes ? - Sid Wagle On April 6, 2016, 11:39 p.m

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45845/#review127512 --- Ship it! Ship It! - Sid Wagle On April 6, 2016, 11:39 p.m

Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

Test.java e8ecd09 Diff: https://reviews.apache.org/r/45904/diff/ Testing --- All alert unit test passed. mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Sid Wagle

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

n clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Sid Wagle

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

ll alert unit test passed. mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Sid Wagle

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

Test.java 10f099e Diff: https://reviews.apache.org/r/45904/diff/ Testing --- Manually verified on 1 node repro cluster. All alert unit test passed. mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Sid Wagle

Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/#review127694 --- Ship it! Ship It! - Sid Wagle On April 7, 2016, 11:38 p.m

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45845/#review127695 --- Ship it! Ship It! - Sid Wagle On April 7, 2016, 8:21 p.m

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

_agent/alerts/ams_alert.py (line 157) <https://reviews.apache.org/r/45873/#comment191086> OrderedDict support is only 2.7+ - Sid Wagle On April 7, 2016, 3:24 p.m., Dmytro Sen wrote: > > --- > This is an automatically gener

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127728 --- On April 7, 2016, 11:34 p.m., Sid Wagle wrote: > > ---

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

n the system tests for the use case of delete cluster, etc. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127772 -----------

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45873/ > --- > > (Updated April 7, 2016, 3:24 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle. &

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

his is a very dangerous query. This can literally return 10,000 > > entries. > > Sid Wagle wrote: > Thanks for pointing that out, I will explore an explicit join query as a > workaround to offload it back to the DB. > For the issue regarding reccurence of this situa

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

de repro cluster. All alert unit test passed. mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Sid Wagle

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

/package/scripts/hdfs_namenode.py (line 322) <https://reviews.apache.org/r/45980/#comment191388> Shouldn't the same logic apply for HA scenario ? - Sid Wagle On April 9, 2016, 12:34 p.m., Andrew Onischuk wrote: > > ---

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

> On April 9, 2016, 4:15 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py, > > line 322 > > <https://reviews.apache.org/r/45980/diff/1/?file=1338258#file1338258line322> > > > >

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45980/#review128010 --- Ship it! Ship It! - Sid Wagle On April 9, 2016, 4:46 p.m

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review128140 --- Ship it! Ship It! - Sid Wagle On April 11, 2016, 3:18 p.m

Re: Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

/LogicalRequest.java (line 412) <https://reviews.apache.org/r/46032/#comment191509> Any chance of an NPE here ? - Sid Wagle On April 11, 2016, 3:15 p.m., Sebastian Toader wrote: > > --- > This is an automatically gener

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

ou thing the implementation is fragile. - Sid ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review128100 -

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 10f099e Diff: https://reviews.apache.org/r/45904/diff/ Testing --- Manually verified on 1 node repro cluster. All alert unit test passed. mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Sid Wagle

Re: Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46047/#review128258 --- Ship it! Ship It! - Sid Wagle On April 11, 2016, 9:32 p.m

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46037/#review128583 --- Ship it! Ship It! - Sid Wagle On April 12, 2016, 11:53 p.m

Re: Review Request 46178: AMBARI-15872 : Provide ability to skip WAL file writes for AMS HBase tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46178/#review128792 --- Ship it! Ship It! - Sid Wagle On April 13, 2016, 10:52 p.m

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46219/#review128967 --- Ship it! Ship It! - Sid Wagle On April 14, 2016, 7:40 p.m

Re: Review Request 46218: AlertReceivedListenerTest is Flaky When Running @Before Code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46218/#review128968 --- Ship it! Ship It! - Sid Wagle On April 14, 2016, 7:27 p.m

Review Request 46238: Refactor Metadata manager for supporting distributed collector

-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml e5758bf ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 6f32000 Diff: https://reviews.apache.org/r/46238/diff/ Testing --- All metrics Unit tests passed. Thanks, Sid Wagle

Re: Review Request 46238: Refactor Metadata manager for supporting distributed collector

gt; > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > e5758bf > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 > 6f32000 > > Diff: https://reviews.apache.org/r/46238/diff/ > > > Testing > --- > > All metrics Unit tests passed. > > > Thanks, > > Sid Wagle > >

Review Request 46274: Metrics Unit Tests Failing on b.a.o

/ Testing --- Unit tests pass. Thanks, Sid Wagle

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

(line 67) <https://reviews.apache.org/r/46137/#comment192809> It should not take long enough for upgrade to execute that will allow remote debugging, don't you want a configurable supend action so JVM will pause sufficiently ? - Sid Wagle On April 18, 2016, 5:14 p.m., Nahappan S

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/#review129382 --- Ship it! Ship It! - Sid Wagle On April 18, 2016, 5:39 p.m

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java (line 354) <https://reviews.apache.org/r/46342/#comment192850> This Exception is dangerous to be thrown from the Sink is not handled by the caller. We should be logging the exceotion and moving on. - Sid Wagle On Ap

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

> > (Updated April 18, 2016, 7:04 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Repository: ambari > > > Description > --- > > BUG-55643 Add container

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129445 --- Ship it! Ship It! - Sid Wagle On April 18, 2016, 10:24 p.m

Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

che.org/r/46355/diff/ Testing --- -- Ran 246 tests in 6.541s OK -- Total run:928 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

pdates tomorrow. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46355/#review129475 --- On April 19, 2016, 12:26 a.m.,

Re: Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

Ran 246 tests in 6.541s OK -- Total run:928 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 46413: AMBARI-15982 : AMS metrics gaps/inconsistencies in data

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46413/#review129634 --- Ship it! Ship It! - Sid Wagle On April 19, 2016, 10:08 p.m

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

/scripts/export_ams_metrics.py (line 140) <https://reviews.apache.org/r/45739/#comment193285> Better to set seriesStartTime = valid timstamp like now. - Sid Wagle On April 20, 2016, 1:44 p.m., Andrew Onischuk wrote: > > ---

Re: Review Request 43926: Frameworks support for bulk delete API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43926/#review129829 --- Ship it! Ship It! - Sid Wagle On April 20, 2016, 6:45 p.m

Re: Review Request 46500: Regenerating keytabs on re-imaged hosts results in error during 'Creating Principals'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46500/#review129923 --- Ship it! Ship It! - Sid Wagle On April 21, 2016, 5:01 p.m

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129926 --- Ship it! Ship It! - Sid Wagle On April 21, 2016, 3:51 p.m

Re: Review Request 46508: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics (Patch 2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46508/#review129945 --- Ship it! Ship It! - Sid Wagle On April 21, 2016, 7:10 p.m

Re: Review Request 46602: Delete Service: Deleting Hive fails with 500 error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46602/#review130292 --- Ship it! Ship It! - Sid Wagle On April 24, 2016, 4:40 a.m

Re: Review Request 46697: export_ams_script should save configs into the files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46697/#review130626 --- Ship it! Ship It! - Sid Wagle On April 26, 2016, 1:51 p.m

Re: Review Request 46714: Prevent Views From Causing a Loss of Service For Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46714/#review130710 --- Ship it! Ship It! - Sid Wagle On April 26, 2016, 10:03 p.m

Review Request 46751: Ambari metrics API call should allow for early failure

/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java ce865cf Diff: https://reviews.apache.org/r/46751/diff/ Testing --- Added a unit test. Manually verified the patch works on a cluster. Thanks, Sid Wagle

Re: Review Request 46703: Reduce error logs on the Sink path if AMS is down

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46703/#review130881 --- Ship it! Ship It! - Sid Wagle On April 26, 2016, 3:13 p.m

Re: Review Request 46751: Ambari metrics API call should allow for early failure

364004#file1364004line92> > > > > Typically how long is the delay after which it will throw the exception. 10 seconds. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

based deploy with 0 hosts added to the cluster and thereby it might be possible to have no requests created. Not sure if it is relevant to this change though. - Sid Wagle On April 29, 2016, 11:08 p.m., Nate Cole wrote: > > --- > T

Re: Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46898/#review131440 --- Ship it! Awesome !! We definetly needed this. - Sid Wagle

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

reate? Unless we are always creating CG with configs and no hosts and then update request with hosts. - Sid Wagle On May 5, 2016, 3:55 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/#review131873 --- Ship it! Ship It! - Sid Wagle On May 5, 2016, 3:55 p.m

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

opNCondition.java (line 146) <https://reviews.apache.org/r/47142/#comment196543> Add javadoc for method - Sid Wagle On May 9, 2016, 11:50 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

> On May 10, 2016, 12:27 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java, > > line 308 > > <https://reviews.apache.org/r/47

Re: Review Request 47147: AMBARI-16413: Ambari server does not start because of permission issues on symbolic links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47147/#review132490 --- Ship it! Ship It! - Sid Wagle On May 10, 2016, 12:41 a.m

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java (line 301) <https://reviews.apache.org/r/47142/#comment196716> Is the native timerange hint applicable to both SELECT queries? - Sid Wagle On May 10, 2016, 5:34 p.m., Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132514 --- Ship it! Ship It! - Sid Wagle On May 10, 2016, 6:41 p.m

Re: Review Request 47235: Takeover script on Paypal configs results in conflict message that look wrong

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47235/#review132667 --- Ship it! Ship It! - Sid Wagle On May 11, 2016, 1:54 p.m

Re: Review Request 47244: AMBARI-16440 : Flush metrics to collector if metric system is stopped gracefully in the Sink daemon

/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java (line 395) <https://reviews.apache.org/r/47244/#comment196961> Why not keep the same thread and just submit task to it? - Sid Wagle On May 11, 2016, 5 p.m., Aravindan Vijayan

Re: Review Request 46661: Put HBase master UI into readonly mode for secure deployment for HDP 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46661/#review132801 --- Ship it! Ship It! - Sid Wagle On May 11, 2016, 11:31 p.m

Re: Review Request 47369: AMBARI-16666 : AMS Service check fails because collector takes too long to start up.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47369/#review133280 --- Ship it! Ship It! - Sid Wagle On May 13, 2016, 10:17 p.m

Re: Review Request 47244: AMBARI-16440 : Flush metrics to collector if metric system is stopped gracefully in the Sink daemon

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47244/#review133281 --- Ship it! Ship It! - Sid Wagle On May 13, 2016, 8:23 p.m

Review Request 47420: Support grafana dashboards to be defined based on stack

--- -- Ran 261 tests in 6.699s OK -- Total run:1016 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review133450 --- What about RCA tables not a part of Ambari DB ? - Sid Wagle On

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

run:1016 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

> On May 16, 2016, 9:47 p.m., Sid Wagle wrote: > > What about RCA tables not a part of Ambari DB ? > > Ajit Kumar wrote: > Only postgres-embedded-create.sql has ambarirca db. Users who are facing > this issue have stand alone DB server and don't use postgres-embe

Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

l errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

6.682s OK -- Total run:1016 Total errors:0 Total failures:0 OK Thanks, Sid Wagle

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

subsequent patch. - Sid Wagle On May 17, 2016, 12:51 a.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

/takeover_files_mapping.json (line 2) <https://reviews.apache.org/r/47456/#comment198178> Lets add this for ams-hbase-env, ams-hbase-log4j, - Sid Wagle On May 17, 2016, 2:16 p.m., Andrew Onischuk wrote: > > --- > This is an automatically gener

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

> On May 17, 2016, 1:52 a.m., Sid Wagle wrote: > > Just realized I am missing UpgradeCatalog changes, will add subsequent > > patch. No need for upgrade steps since the Catalog deletes all standard deviation alerts which get added back on server r

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

site.xml (line 557) <https://reviews.apache.org/r/47595/#comment198739> Units should be clear from name or description of property. - Sid Wagle On May 19, 2016, 2:43 p.m., Dmytro Sen wrote: > > --- > This is an automatically

  1   2   3   4   5   6   >