Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 13, 2016, 9:30 a.m., Jonathan Hurley wrote: > > I'm going to +1 this, but I'd still like to know how other commiters feel > > about making the socket commands paramters vs actual parts of the source > > element. > > Jayush Luniya wrote: > Parameters make more sense for script ale

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 12, 2016, 8:30 p.m., Jonathan Hurley wrote: > > I'm going to +1 this, but I'd still like to know how other commiters feel > > about making the socket commands paramters vs actual parts of the source > > element. > > Jayush Luniya wrote: > Parameters make more sense for script ale

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 13, 2016, 12:30 a.m., Jonathan Hurley wrote: > > I'm going to +1 this, but I'd still like to know how other commiters feel > > about making the socket commands paramters vs actual parts of the source > > element. Parameters make more sense for script alerts than port alerts in my opi

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 11, 2016, 9:51 p.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? > > Jonathan Hurley wrote: > That depends; there's no Fix Version on this Jira, so I don't know if > it's only going into trunk or if it's going to into branc

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 12, 2016, 6:51 a.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? > > Jonathan Hurley wrote: > That depends; there's no Fix Version on this Jira, so I don't know if > it's only going into trunk or if it's going to into branc

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141993 --- Ship it! I'm going to +1 this, but I'd still like to know how o

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 11, 2016, 5:51 p.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? That depends; there's no Fix Version on this Jira, so I don't know if it's only going into trunk or if it's going to into branch-2.4. If you get approval to put

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141786 --- Should I UpgradeCatalog250.java as we are readying to release Amba

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 11, 2016, 9:50 p.m.) Review request for Ambari, Florian Barca, Jo

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 11, 2016, 3:46 p.m., Jonathan Hurley wrote: > > Thank you for reviewing! I'm going to fix the issues, and wait till the other reviewers leave comments that we should use `parameters` or not. - Masahiro --- This is an automati

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141703 --- ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py (l

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 8, 2016, 8:45 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 68-71 > > > > > > We use underscore notation in our json, not dotted names. Match for > > cons

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 8, 2016, 4:45 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 68-71 > > > > > > We use underscore notation in our json, not dotted names. Match for > > cons

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 8, 2016, 8:45 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 68-71 > > > > > > We use underscore notation in our json, not dotted names. Match for > > cons

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141332 --- Fix it, then Ship it! Make sure Jonathan reviews this before pu

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 8, 2016, 8:20 p.m.) Review request for Ambari, Florian Barca, Jon

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

On July 4, 2016, 6:58 p.m., Masahiro Tanaka wrote: > > What about existing clusters? We probably need to modify any existing ZK > > alerts with this using the UpgradeCatalog. > > Masahiro Tanaka wrote: > Thank you for reviewing. Which one should we change, > `UpgradeCatalog230.java`, or `U

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 4, 2016, 10:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json, > > line 43 > > > > > > What about a response? In this case, ZK will response wi

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 4, 2016, 6:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json, > > line 43 > > > > > > What about a response? In this case, ZK will response wit

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On July 4, 2016, 10:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json, > > line 43 > > > > > > What about a response? In this case, ZK will response wi

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review140707 --- ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On June 25, 2016, 10:29 p.m., Nate Cole wrote: > > Latest patch still seems like forced solution. Why not just allow the > > alert definition to provide "data" attribute (or whatever) in json that > > port_alert can use? > > Masahiro Tanaka wrote: > Thanks for reviewing. I've tried to c

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 4, 2016, 7:01 p.m.) Review request for Ambari, Florian Barca, Jon

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On June 25, 2016, 6:29 p.m., Nate Cole wrote: > > Latest patch still seems like forced solution. Why not just allow the > > alert definition to provide "data" attribute (or whatever) in json that > > port_alert can use? > > Masahiro Tanaka wrote: > Thanks for reviewing. I've tried to ch

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On June 26, 2016, 1:56 a.m., Jonathan Hurley wrote: > > ambari-agent/conf/unix/ambari-agent.ini, line 40 > > > > > > This is still not supportable as it's based off of a specific alert > > name. Also, it's on a per

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review139466 --- ambari-agent/conf/unix/ambari-agent.ini (line 40)

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On June 25, 2016, 10:29 p.m., Nate Cole wrote: > > Latest patch still seems like forced solution. Why not just allow the > > alert definition to provide "data" attribute (or whatever) in json that > > port_alert can use? Thanks for reviewing. I've tried to chagne the code as you said, but t

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review139457 --- Latest patch still seems like forced solution. Why not just allow

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On June 21, 2016, 3:05 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines > > 133-135 > > > > > > We don't hardcode specific workarounds into the alerts framewor

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated June 25, 2016, 1:54 p.m.) Review request for Ambari, Florian Barca, Jo

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

> On 6月 21, 2016, 3:05 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines > > 133-135 > > > > > > We don't hardcode specific workarounds into the alerts framework.

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review138843 --- None of the hadoop services should dump exceptions to logs on simp