Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary
> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json, > > line 201 > > > > > > can this be a slider between 0 ad 100 ? Should we

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary
> On May 26, 2016, 5:05 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 340 > > > > > > Is this an override? > > I don't see this function being

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134917 ---

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary
> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 207 > > > > > > if user manually puts a value for this field,

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/ --- (Updated May 26, 2016, 4:54 a.m.) Review request for Ambari, Alexander

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-24 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134692 ---

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-24 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134670 --- Ship it! Ship It! - Lav Jain On May 25, 2016, 12:17 a.m.,

Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-24 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: