Re: Review Request 41201: Preserve env variables for tasks in docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110950 --- Master (3e1f823) is green with this patch.

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Dec. 17, 2015, 5:22 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 41486: Deprecate JobUpdateSettings.maxWaitToInstanceRunning and UpdateConfig.restart_threshold

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41486/#review110991 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 17, 2015, 5:55

Review Request 41522: Remove ServerInfo.thriftAPIVersion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41522/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1553

Re: Review Request 41486: Deprecate JobUpdateSettings.maxWaitToInstanceRunning and UpdateConfig.restart_threshold

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41486/ --- (Updated Dec. 17, 2015, 10:52 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/#review110964 ---

Review Request 41486: Deprecate JobUpdateSettings.maxWaitToInstanceRunning and UpdateConfig.restart_threshold

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41486/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Review Request 41521: Force Windows to always use Unix line endings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41521/ --- Review request for Aurora and John Sirois. Bugs: AURORA-1354

Re: Review Request 41486: Deprecate JobUpdateSettings.maxWaitToInstanceRunning and UpdateConfig.restart_threshold

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41486/#review110994 --- Ship it! Ship It! - Joshua Cohen On Dec. 17, 2015, 5:55 p.m.,

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/#review111005 --- Ship it! Master (c912c34) is green with this patch.

Re: Review Request 41522: Remove ServerInfo.thriftAPIVersion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41522/#review110995 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 17, 2015, 6:23

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

> On Dec. 16, 2015, 10:14 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/client/test_config.py, line 187 > > > > > > Kill this comment? It seems superfluous. > > Dmitriy Shirchenko wrote: > I added

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review111023 --- Master (c912c34) is red with this patch.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

> On Dec. 17, 2015, 12:31 p.m., Bill Farner wrote: > > Shape of the API LGTM, end-to-end tests pass. I'm going to commit this. Maxim - if you have any remaining issues, i'm happy to address follow-up comments on Dmitriy's behalf - Bill

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/ --- (Updated Dec. 17, 2015, 1:34 p.m.) Review request for Aurora, Stephan Erb,

Re: Review Request 41523: Remove duplicate ExecutorConfig class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41523/#review111008 --- Ship it! Master (c912c34) is green with this patch.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

> On Dec. 17, 2015, 1:16 a.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py, line 214 > > > > > > Rename this var too? `_end` was never great, but now it's lost all > >

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review111034 --- Ship it! Shape of the API LGTM, end-to-end tests pass. - Bill

Re: Review Request 41521: Force Windows to always use Unix line endings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41521/#review111002 --- Ship it! Ship It! - John Sirois On Dec. 17, 2015, 11:18 a.m.,

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/ --- (Updated Dec. 17, 2015, 7:21 p.m.) Review request for Aurora, Joshua Cohen,

Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1385

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

> On Nov. 15, 2015, 11:34 a.m., John Sirois wrote: > > Brice - this would be nice to land. Are you able to put time towards the > > cleanups suggested by Kevin and style fixes failing the build currently? > > If so - great. If not, I can brush this up and send out a new RB. Brice, I've

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review111037 --- Ship it! Ship It! - Bill Farner On Dec. 17, 2015, 12:34 p.m.,

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/ --- (Updated Dec. 17, 2015, 8:57 p.m.) Review request for Aurora. Changes

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

> On Dec. 17, 2015, 2:53 p.m., Bill Farner wrote: > > Thanks, overall this looks great! > > > > Can you also add a line in the NEWS file to call out the new flag? Doesn't > > need formal documentation, just a brief blurb is fine. Under 0.11.0 or in an unspecified area above that? - R.B.

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

> On Dec. 17, 2015, 1:16 p.m., Bill Farner wrote: > > LGTM once Joshua's final comments are addressed. Oh, actually - can you add a line to the NEWS file about the new argument? - Bill --- This is an automatically generated e-mail. To

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/ --- (Updated Dec. 17, 2015, 3:24 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Dec. 17, 2015, 9:45 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 41201: Preserve env variables for tasks in docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review111056 --- Thanks! This patch LGTM overall, but it would be really nice to

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

> On Dec. 17, 2015, 2:17 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java, line 29 > > > > > > nit: is enough to split paragraphs. Thanks - fixed. I could have

Review Request 41531: Add a NEWS entry about shell health checks and HealthCheckConfig deprecations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41531/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/#review111055 --- Ship it! lgtm modulo a couple of style nits.

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/ --- (Updated Dec. 17, 2015, 9:10 p.m.) Review request for Aurora. Changes

Re: Review Request 41531: Add a NEWS entry about shell health checks and HealthCheckConfig deprecations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41531/#review111053 --- Ship it! Ship It! - Bill Farner On Dec. 17, 2015, 1:09 p.m.,

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

> On Dec. 17, 2015, 12:53 p.m., Bill Farner wrote: > > Thanks, overall this looks great! > > > > Can you also add a line in the NEWS file to call out the new flag? Doesn't > > need formal documentation, just a brief blurb is fine. > > R.B. Boyer wrote: > Under 0.11.0 or in an unspecified

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/#review111063 --- Ship it! lgtm pending the changes Bill requested. - Joshua Cohen

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/#review111060 --- Ship it! LGTM once Joshua's final comments are addressed. - Bill

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/ --- (Updated Dec. 17, 2015, 3:26 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41525: Add flag to set FrameworkInfo.principal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41525/#review111066 ---

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review111069 --- Ship it! Ship It! - Bill Farner On Dec. 17, 2015, 12:38 p.m.,

Review Request 41534: Update leader redirection logic to return an error page if there is no leading scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41534/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository:

Re: Review Request 41201: Preserve env variables for tasks in docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 17, 2015, 12:27 p.m.) Review request for Aurora. Repository:

Re: Review Request 41486: Deprecate JobUpdateSettings.maxWaitToInstanceRunning and UpdateConfig.restart_threshold

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41486/#review111017 --- Ship it! Master (c912c34) is green with this patch.

Re: Review Request 41534: Update leader redirection logic to return an error page if there is no leading scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41534/#review111093 --- Ship it! Master (93fb2c7) is green with this patch.

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review111098 --- Ship it! Master (93fb2c7) is green with this patch.

Re: Review Request 41534: Update leader redirection logic to return an error page if there is no leading scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41534/#review111099 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 17, 2015, 11:03