Review Request 39742: fix client build path in the docs

2015-10-28 Thread Dmitriy Shirchenko
Description --- fix client build path in the docs Diffs - docs/developing-aurora-client.md b662b6f5c3667e195dd04ec7eccdce1a4c070972 Diff: https://reviews.apache.org/r/39742/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

2015-11-09 Thread Dmitriy Shirchenko
r/39958/#review105722 --- On Nov. 5, 2015, 1:26 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 39822: upgrade psutil to 3.2.2

2015-11-02 Thread Dmitriy Shirchenko
it: https://reviews.apache.org/r/39822/#review104661 --- On Oct. 30, 2015, 8:14 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

2015-11-04 Thread Dmitriy Shirchenko
: https://reviews.apache.org/r/39958/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 39958: deleting unused function deprecation_warning adding test coverage to base, job_monitor, quota_check, scheduler_client

2015-11-04 Thread Dmitriy Shirchenko
: https://reviews.apache.org/r/39958/diff/ Testing --- Thanks, Dmitriy Shirchenko

Review Request 39822: upgrade psutil to 3.2.2

2015-10-30 Thread Dmitriy Shirchenko
fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 Diff: https://reviews.apache.org/r/39822/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 39822: upgrade psutil to 3.2.2

2015-10-30 Thread Dmitriy Shirchenko
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 41154: code version of health check

2015-12-09 Thread Dmitriy Shirchenko
, Dmitriy Shirchenko

Review Request 41154: code version of health check

2015-12-09 Thread Dmitriy Shirchenko
/aurora/executor/common/test_health_checker.py 27c71711d52f757ed1552db4accda671a6bdafdd Diff: https://reviews.apache.org/r/41154/diff/ Testing --- Added unit tests. Ran e2e test. Tested expected behavior on virtual Mesos cluster. Thanks, Dmitriy Shirchenko

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review109855 ------- On Dec. 10, 2015, 9:16 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
unit tests. Ran e2e test. Tested expected behavior on virtual Mesos cluster. Thanks, Dmitriy Shirchenko

Re: Review Request 41154: code version of health check

2015-12-10 Thread Dmitriy Shirchenko
.' Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review109848 --- On Dec. 10, 2015, 12:14 a.m., Dmi

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
rocess.check_call doesn't support timeouts. Compare to: https://github.com/google/python-subprocess32/blob/master/subprocess32.py#L577 or 3+ version: https://docs.python.org/3/library/subprocess.html#subprocess.check_call - Dmitriy -----------

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
37f2e9c6ebc4a4bbd6089e821420e5a02179c6b9 Diff: https://reviews.apache.org/r/41428/diff/ Testing --- Added unit tests. Changed end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
rote: > I don't think the alternative schema is *possible*. If it were, I think > that would be ideal, but given that, yes, just renaming the fields/objects > will suffice. > > Bill Farner wrote: > +1 to the renames Joshua proposed. Done. - Dmitriy

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
37f2e9c6ebc4a4bbd6089e821420e5a02179c6b9 Diff: https://reviews.apache.org/r/41428/diff/ Testing --- Added unit tests. Changed end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
maybe we do this when we load the config > > (though I'm not 100% sure). > > > > I'd try loading a config as the above tests do, with `health_checker = > > ShellHealthChecker()` and see what happens, hopefully that will fail with > > an invalid

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
, Dmitriy Shirchenko

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110404 --- @ReviewBot retry - Dmitriy Shirchenko On Dec. 15, 2015, 3:56

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-17 Thread Dmitriy Shirchenko
> On Dec. 16, 2015, 10:14 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/client/test_config.py, line 187 > > <https://reviews.apache.org/r/41428/diff/4/?file=1166716#file1166716line187> > > > > Kill this comment? It seems superfluous. > >

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-17 Thread Dmitriy Shirchenko
----- On Dec. 16, 2015, 10:43 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41428/ >

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-17 Thread Dmitriy Shirchenko
37f2e9c6ebc4a4bbd6089e821420e5a02179c6b9 Diff: https://reviews.apache.org/r/41428/diff/ Testing --- Added unit tests. Changed end to end test. Thanks, Dmitriy Shirchenko

Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Dmitriy Shirchenko
. Thanks, Dmitriy Shirchenko

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
binary might not be found, but it also might not be > > executable by the current user, etc, etc. Done. - Dmitriy ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review1098

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
27c71711d52f757ed1552db4accda671a6bdafdd Diff: https://reviews.apache.org/r/41154/diff/ Testing --- Added unit tests. Ran e2e test. Tested expected behavior on virtual Mesos cluster. Thanks, Dmitriy Shirchenko

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
27c71711d52f757ed1552db4accda671a6bdafdd Diff: https://reviews.apache.org/r/41154/diff/ Testing --- Added unit tests. Ran e2e test. Tested expected behavior on virtual Mesos cluster. Thanks, Dmitriy Shirchenko

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
src.test.python.apache.aurora.common.test_transport . SUCCESS ``` Maybe you can suggest something else? - Dmitriy --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
n creating the > > health checker we at least could exit with an explicit reason that makes it > > clear that the health check config was invalid. > > Dmitriy Shirchenko wrote: > I completely agree, and those are valid concerns. I do feel that since > AFAIK a

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-10 Thread Dmitriy Shirchenko
here instead? Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review109914 --- On Dec. 11, 2015, 2:

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-15 Thread Dmitriy Shirchenko
/diff/ Testing --- Added unit tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-04 Thread Dmitriy Shirchenko
to the docs, `getErrorStream` _may_ return `null`, so we need > > a guard here. > > https://docs.oracle.com/javase/7/docs/api/java/net/HttpURLConnection.html#getErrorStream() Good call. Done. - Dmitriy --- This is an automatical

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-04 Thread Dmitriy Shirchenko
--- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko
/WebhookModule.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko
/WebhookModule.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-03 Thread Dmitriy Shirchenko
he.org/r/47440/#review135233 --- On June 3, 2016, 10:17 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-26 Thread Dmitriy Shirchenko
PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-26 Thread Dmitriy Shirchenko
;https://reviews.apache.org/r/47440/#comment199788> Done. src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java (line 75) <https://reviews.apache.org/r/47440/#comment199789> Done, - Dmitriy Shirchenko On May 25, 2016,

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-26 Thread Dmitriy Shirchenko
, lines 73-74 > > <https://reviews.apache.org/r/47440/diff/8/?file=1395852#file1395852line73> > > > > -4 spaces Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-26 Thread Dmitriy Shirchenko
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-26 Thread Dmitriy Shirchenko
PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 42126: New class to allocate resources of multiple roles from offer.

2016-01-13 Thread Dmitriy Shirchenko
/MesosTaskFactoryImplTest.java (lines 216 - 217) <https://reviews.apache.org/r/42126/#comment175191> Is this intentionally commented out? - Dmitriy Shirchenko On Jan. 13, 2016, 11:50 p.m., Zhitao Li wrote: > > --- > This is an automati

Review Request 42387: working version of jessie builds

2016-01-15 Thread Dmitriy Shirchenko
/provision.sh PRE-CREATION Diff: https://reviews.apache.org/r/42387/diff/ Testing --- New build with a test that starts a Vagrant and following README should lead to a successful job. Thanks, Dmitriy Shirchenko

Re: Review Request 42126: Accept resource offers from multiple framework roles.

2016-01-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114532 --- Ship it! Ship It! - Dmitriy Shirchenko On Jan. 14, 2016, 6:23

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Dmitriy Shirchenko
-CREATION Diff: https://reviews.apache.org/r/42387/diff/ Testing --- New build with a test that starts a Vagrant and following README should lead to a successful job. Thanks, Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Dmitriy Shirchenko
ake it consistent and it was told me to it's better. i am not sure what log_dir was before, but now it's explicit and i see logs going there. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://r

Review Request 42737: fixng reference in table of contents to Docker Object(s)

2016-01-25 Thread Dmitriy Shirchenko
--- fixng reference in table of contents for Docker Object[s] Diffs - docs/configuration-reference.md 02fb4e616d0a58148d07b5ab30e824978f4b0a1a Diff: https://reviews.apache.org/r/42737/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
to a successful job. Thanks, Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
here would be useful I > > think for discovery purposes. Done. - Dmitriy ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115281 --

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
ated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review114903 ----------- On Jan. 19, 2016, 11:23 p.m., Dmitriy Shirchenko wrote: > > --- > This is a

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
/Vagrantfile PRE-CREATION test/deb/debian-jessie/provision.sh PRE-CREATION Diff: https://reviews.apache.org/r/42387/diff/ Testing --- New build with a test that starts a Vagrant and following README should lead to a successful job. Thanks, Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
b6ecace73c69c833ff2267fe95e11cf2f8d > specs/debian/aurora-scheduler.service PRE-CREATION > test/deb/debian-jessie/README.md PRE-CREATION > test/deb/debian-jessie/Vagrantfile PRE-CREATION > test/deb/debian-jessie/provision.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/42387/diff/ > > > Testing > --- > > New build with a test that starts a Vagrant and following README should lead > to a successful job. > > > Thanks, > > Dmitriy Shirchenko > >

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
: https://reviews.apache.org/r/42387/diff/ Testing --- New build with a test that starts a Vagrant and following README should lead to a successful job. Thanks, Dmitriy Shirchenko

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

2016-01-26 Thread Dmitriy Shirchenko
tps://reviews.apache.org/r/42816/#comment177437> this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error. - Dmitriy Shirchenko On J

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

2016-01-26 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116426 --- Ship it! Fair enough. - Dmitriy Shirchenko On Jan. 26, 2016

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

2016-01-26 Thread Dmitriy Shirchenko
> On Jan. 26, 2016, 7:24 p.m., Dmitriy Shirchenko wrote: > > src/test/python/apache/aurora/client/test_config.py, lines 213-223 > > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213> > > > > this test is still relevant thoug

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

2016-03-10 Thread Dmitriy Shirchenko
/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122683 --- @ReviewBot retry - Dmitriy Shirchenko On March 9, 2016, 5:34

Re: Review Request 44827: Do not split the shell command string passed into shell health check script

2016-03-14 Thread Dmitriy Shirchenko
Diff: https://reviews.apache.org/r/44827/diff/ Testing --- Unit tests + end_to_end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-07 Thread Dmitriy Shirchenko
84f717fbf724c11863b4980fd2740dc23fe1404e src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-07 Thread Dmitriy Shirchenko
/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-07 Thread Dmitriy Shirchenko
/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Review Request 44486: export environment variables into the shellchecker command

2016-03-07 Thread Dmitriy Shirchenko
/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 44486: export environment variables into the shellchecker command

2016-03-07 Thread Dmitriy Shirchenko
/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing (updated) --- Unit and end to end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
example the command could be '/usr/bin/health_checker > --port-to-check={{thermos.ports[http]}}'. > > On March 8th, 2016, 11:29 a.m. PST, *Joshua Cohen* wrote: > > I think this is an excellent point, good catch Zameer! > > Dmitriy, is there any reason why this approach won't wor

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122583 ------- On March 8, 2016, 6:32 p.m., Dmitriy Shirchenko wrote: > >

Re: Review Request 44486: Exposing ports to shell health checkers

2016-03-08 Thread Dmitriy Shirchenko
; > processes have like hostname. > > > > For example the command could be '/usr/bin/health_checker > > --port-to-check={{thermos.ports[http]}}'. > > Joshua Cohen wrote: > I think this is an excellent point, good catch Zameer! > > Dmitriy, is there any rea

Re: Review Request 45506: Execute shell-based health checks as the task user.

2016-03-31 Thread Dmitriy Shirchenko
n, my bad. thanks for catching this! - Dmitriy Shirchenko On March 30, 2016, 11:41 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 45506: Execute shell-based health checks as the task user.

2016-03-31 Thread Dmitriy Shirchenko
> On March 31, 2016, 4:20 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 66 > > <https://reviews.apache.org/r/45506/diff/2/?file=1320188#file1320188line66> > > > > why are you doing a sepa

Re: Review Request 45506: Execute shell-based health checks as the task user.

2016-03-31 Thread Dmitriy Shirchenko
> On March 31, 2016, 4:20 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 60 > > <https://reviews.apache.org/r/45506/diff/2/?file=1320188#file1320188line60> > > > > why did you get rid of .format?

Re: Review Request 45506: Execute shell-based health checks as the task user.

2016-03-31 Thread Dmitriy Shirchenko
On March 31, 2016, 6:38 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45506/ > ------

Re: Review Request 45506: Execute shell-based health checks as the task user.

2016-03-31 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126443 --- Ship it! Ship It! - Dmitriy Shirchenko On March 31, 2016, 8

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-24 Thread Dmitriy Shirchenko
's not mixed in with the code. src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java (line 73) <https://reviews.apache.org/r/47440/#comment199485> Done. - Dmitriy Shirchenko On May 22, 2016, 1:29 p.m., Dmitriy Shirchenko w

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-24 Thread Dmitriy Shirchenko
gt; > > > > Would it make sense to move this into WebhookInfo instead? Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134392 -----

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-18 Thread Dmitriy Shirchenko
> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 30 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line30> > > > > Missing javadoc for class and public methods. Done. > On May 17, 2016, 5:09 p.m., Maxim Khu

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-18 Thread Dmitriy Shirchenko
/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-18 Thread Dmitriy Shirchenko
/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-18 Thread Dmitriy Shirchenko
here to a deprecation cycle. It might therefore make > > sense to establish an explicit schema. Good point. Essentially these are IScheduledTask objects which I believe already require a deprecation cycle. Is this correct? - Dmitriy --------

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-17 Thread Dmitriy Shirchenko
/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-17 Thread Dmitriy Shirchenko
nother thread or added to a queue for > > future delivery? AFAICT the distribution of events is synchronous, so it > > seems like operations that might block for any significant amount of time > > could cause issues. > > Dmitriy Shirchenko wrote: > Yea, I'm not sure. Do you have

Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Dmitriy Shirchenko
-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Dmitriy Shirchenko
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133482 ------- On May 17, 2016, 2:10 a.m., Dmitriy Shirchenko wrote: > > --- &g

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Dmitriy Shirchenko
/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Dmitriy Shirchenko
/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Dmitriy Shirchenko
/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Dmitriy Shirchenko
Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

2016-04-18 Thread Dmitriy Shirchenko
ws.apache.org/r/46290/#review129401 --- On April 18, 2016, 6:34 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

2016-04-18 Thread Dmitriy Shirchenko
/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

2016-04-18 Thread Dmitriy Shirchenko
/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

2016-04-18 Thread Dmitriy Shirchenko
/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

2016-04-18 Thread Dmitriy Shirchenko
/health_checker.py d8675beb8f16ebdd2d6946367784411fe84a5cfc src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

2016-04-18 Thread Dmitriy Shirchenko
d8675beb8f16ebdd2d6946367784411fe84a5cfc src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-18 Thread Dmitriy Shirchenko
/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

2016-04-18 Thread Dmitriy Shirchenko
4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Review Request 46361: deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.

2016-04-18 Thread Dmitriy Shirchenko
: https://reviews.apache.org/r/46361/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 50478: Improve `executorLost` error message.

2016-07-27 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50478/#review143764 --- Ship it! Ship It! - Dmitriy Shirchenko On July 27, 2016, 1

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144653 --- Ship it! Ship It! - Dmitriy Shirchenko On Aug. 3, 2016, 12

  1   2   >