f786d1ef9720f
Diff: https://reviews.apache.org/r/48082/diff/
Testing
---
Manual/Explorative: Invoked from CLI-side to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
e if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
f9720f
Diff: https://reviews.apache.org/r/48082/diff/
Testing
---
Manual/Explorative: Invoked from CLI-side to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
f9720f
Diff: https://reviews.apache.org/r/48082/diff/
Testing
---
Manual/Explorative: Invoked from CLI-side to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
de to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
```
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
```
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
then realized that migration scripts are instantiated through reflection by
ibatis and Guice injection did not work on them (or I don't know enough about
Guice to make it work).
Any suggestions?
- Mehrdad Nurolahzade
On June 14, 2016, 9:46 a.m., Mehrdad Nurola
e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48559/#review137553
---
@ReviewBot retry
- Mehrdad Nurolahzade
On June 14, 2016, 10:12
the back fill logic?
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48559/#review137763
---
On June 14, 2016, 10:12 a.m., M
This should be unnecessary as zero is the default value for
> > 'production'.
>
> Mehrdad Nurolahzade wrote:
> Isn't this required to resolve the inconsistencies between the choice of
> ```production``` and ```tier``` in already scheduled jobs?
>
iff: https://reviews.apache.org/r/48796/diff/
Testing
---
```
./build-support/jenkins/build.sh
+ date
Thu Jun 16 08:57:08 PDT 2016
+ ./gradlew -Pq clean build
...
09:03:14 00:03 [complete]
SUCCESS
```
Thanks,
Mehrdad Nurolahzade
This should be unnecessary as zero is the default value for
> > 'production'.
>
> Mehrdad Nurolahzade wrote:
> Isn't this required to resolve the inconsistencies between the choice of
> ```production``` and ```tier``` in already scheduled jobs?
>
start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad Nurolahzade
to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad Nurolahzade
execute_entry
File ".bootstrap/_pex/pex.py", line 442, in execute_pkg_resources
File ".bootstrap/pkg_resources.py", line 2190, in load
File "apache/aurora/executor/bin/thermos_executor_main.py", line 31, in
File "apache/aurora/config/__init__.py", line 28, in
File "apache/aurora/config/thrift.py", line 21, in
ImportError: No module named client.api
```
Not sure if this is the right way to go, please advise.
Thanks,
Mehrdad Nurolahzade
"apache/aurora/config/__init__.py", line 28, in
File "apache/aurora/config/thrift.py", line 21, in
ImportError: No module named client.api
```
Not sure if this is the right way to go, please advise.
The error obviously goes away by adding
```src/main/python/apache/aurora/client``` to executor pants BUILD file. But,
'is that OK if I introduce this dependency?' is what I am asking.
Thanks,
Mehrdad Nurolahzade
ierarchy. Now, I can move back to ```config.py``` again.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review138964
------------
c
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
)
<https://reviews.apache.org/r/49048/#comment204470>
This is left over from refactoring, will remove.
- Mehrdad Nurolahzade
On June 23, 2016, 3:35 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically gener
OK (All tests passed) ***
mesos-master start/running, process 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
ngs
> > in 242.05 seconds [0m
> >
> > FAILURE
> >
> > [32m
> >Waiting for background workers to finish.[0m
> > 16:22:36 04:46 [complete][31m
> >FAILURE[0m
> >
> >
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139596
---
@ReviewBot retry
- Mehrdad Nurolahzade
On June 27, 2016, 9:02
hrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139597
---
On June 27, 2016, 9:02 a.m., Mehrdad Nurolahzade wrote:
&
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139597
-------
On June 27, 2016, 9:02 a.m., Mehrdad Nurolahzade wrote:
>
>
def production_tier_filter(tier):
return not to_bool(tier.settings['preemptible']) and not
to_bool(tier.settings['revocable'])
```
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https:/
/home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
> 17:01:40 04:08 [complete][31m
> >FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
This is passing locally, not sure why it's breaking on the server
c/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
*** OK (All tests passed) ***
mesos-master start/running, process 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
``
0m1.318s
sys 0m0.533s
```
Thanks,
Mehrdad Nurolahzade
e time here I decided to give up. Let me know if you
have any suggestion for testing.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139857
------
> On June 28, 2016, 1:53 p.m., David McLaughlin wrote:
> > config/legacy_untested_classes.txt, line 44
> > <https://reviews.apache.org/r/49334/diff/1/?file=1432053#file1432053line44>
> >
> > Isn't this a fairly easy class to test?
>
> Mehrdad Nu
0m1.318s
sys 0m0.533s
```
Thanks,
Mehrdad Nurolahzade
m0.774s
```
Thanks,
Mehrdad Nurolahzade
g/r/49048/#review139923
---
On June 28, 2016, 4:57 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote:
> >
>
> Mehrdad Nurolahzade wrote:
> Should this be merged with upstream now that 0.15 is released?
>
> Joshua Cohen wrote:
> Yes, we can land this now. Would you mind rebasing? Then I can commit it.
Alright
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review141329
---
@ReviewBot retry
- Mehrdad Nurolahzade
On July 8, 2016, 1:12
ss 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review141698
---
@ReviewBot retry
- Mehrdad Nurolahzade
On July 8, 2016, 4:15
Diff: https://reviews.apache.org/r/50052/diff/
Testing
---
Manual, Jenkins, and end_to_end
Thanks,
Mehrdad Nurolahzade
t; function returns)
Correct, going to refactor all.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50052/#review142326
-----------
://reviews.apache.org/r/50052/diff/
Testing
---
Manual, Jenkins, and end_to_end
Thanks,
Mehrdad Nurolahzade
o reply, visit:
https://reviews.apache.org/r/50052/#review142524
-------
On July 15, 2016, 1:15 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-
m/google/protobuf/util/JsonFormat.java
> > *
> > http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3
>
> Mehrdad Nurolahzade wrote:
> Looking into protobuf util ...
I can see that we already have
[jackson-datatype-protobuf](https://gi
m/google/protobuf/util/JsonFormat.java
> > *
> > http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3
>
> Mehrdad Nurolahzade wrote:
> Looking into protobuf util ...
>
> Mehrdad Nurolahzade wrote:
> I can see that we already ha
Thanks,
Mehrdad Nurolahzade
/files/2016/07/18/50faae5c-45ac-45af-aa3c-d68ca09d2e72__offers-new.json
Thanks,
Mehrdad Nurolahzade
,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142681
---
@ReviewBot retry
- Mehrdad Nurolahzade
On July 8, 2016, 4:15
updates).
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50052/#review142805
-------
On July 18, 2016, 7:12 p.m., Mehrdad Nuro
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142810
---
On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automat
uot;: "job", "value":
"devcluster/www-data/prod/hello"}]
}
}
}
]' \
-X POST http://192.168.33.7:5050/master/reserve
```
- Mehrdad
---
This is an automatically g
://reviews.apache.org/media/uploaded/files/2016/07/19/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json
Thanks,
Mehrdad Nurolahzade
es only.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142828
---
On July 8, 2016, 4:15 p.m., Mehrdad Nurol
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142828
---
On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wrote:
>
> --
-----------
On July 20, 2016, 10:56 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> --
/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json
Rendering of labels by Mesos master /salves endpoint
https://reviews.apache.org/media/uploaded/files/2016/07/20/ea4b6db5-de80-4327-bfb4-6bd965ae21d1__Screen_Shot_2016-07-20_at_12.26.06_PM.png
Thanks,
Mehrdad Nurolahzade
nection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
------
On July 25, 2016, 8:30 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> -
to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
://reviews.apache.org/r/50432/diff/
Testing
---
```
./build-support/jenkins/build.sh
```
Thanks,
Mehrdad Nurolahzade
--
On July 25, 2016, 7:36 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50432/
> ---
> On July 26, 2016, 7:36 a.m., Joshua Cohen wrote:
> > I know this is already landed, but it would be nice to follow this up with
> > a test case if possible?
>
> Mehrdad Nurolahzade wrote:
> The logic has two test cases:
> (https://gi
Diff: https://reviews.apache.org/r/50530/diff/
Testing
---
Thanks,
Mehrdad Nurolahzade
/multitenancy.md 62bcd535d3bf39c9ea7e6d5958f6ae8ba0867c0d
docs/reference/configuration.md 64c076d862453545652fbaa2d3e29f284ddd164d
Diff: https://reviews.apache.org/r/50530/diff/
Testing
---
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50530/#review144167
---
Can we git this merged?
- Mehrdad Nurolahzade
On July 27, 2016
/python/apache/aurora/client/test_config.py
4742fa28e3156e5b20791b80f2db8392f7f2f4bf
Diff: https://reviews.apache.org/r/50432/diff/
Testing
---
```
./build-support/jenkins/build.sh
```
Thanks,
Mehrdad Nurolahzade
://reviews.apache.org/r/50432/#review144191
-------
On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50432/#review144191
-----------
On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote:
>
> ---
/
Testing
---
`./pants test src/test/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
.
I'll sibmit a new version shortly.
- Mehrdad Nurolahzade
On July 29, 2016, 2:21 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
4742fa28e3156e5b20791b80f2db8392f7f2f4bf
Diff: https://reviews.apache.org/r/50617/diff/
Testing
---
`./pants test src/test/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50819/#review144823
---
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Aug. 4, 2016, 2
docs/reference/configuration.md 16b31be5bf3021eb2f646e7a4361d5b614bd1164
Diff: https://reviews.apache.org/r/50902/diff/
Testing
---
Manual testing
Thanks,
Mehrdad Nurolahzade
do.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50902/#review145364
---
On Aug. 8, 2016, 10:13 a.m., Mehrdad Nu
> On Aug. 10, 2016, 10:36 a.m., Maxim Khutornenko wrote:
> > The easiest way to validate doc changes like this is to push your branch to
> > your github remote and post a link here for review. Care to give it a try?
>
> Mehrdad Nurolahzade wrote:
> Will do.
Here i
ically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50819/
> ---
>
> (Updated Aug. 4, 2016, 2:10 p.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
&
/OfferManagerImplTest.java
(lines 50 - 54)
<https://reviews.apache.org/r/52074/#comment217400>
We should start disallowing or limiting import static. It causes poor
readability.
I was looking for a makeTask() method on this file.
- Mehrdad Nurolahzade
On Sept. 20, 2016, 12:14 p.m., D
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52074/#review149715
---
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Sept. 20, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53829/#review156206
---
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Nov. 16, 2016, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53862/#review156243
---
Ship it!
Thanks for doing this.
- Mehrdad Nurolahzade
On
/scheduler/storage/db/AttributeMapper.xml
(line 78)
<https://reviews.apache.org/r/53918/#comment226709>
Remind me why are explicitly setting fetch size?
- Mehrdad Nurolahzade
On Nov. 19, 2016, 1:36 a.m., Stephan Erb wrote:
>
> --
r/storage/db/InstrumentingInterceptorTest.java
(lines 71 - 72)
<https://reviews.apache.org/r/54107/#comment228033>
Nit: Expectations can also be cascaded, like
`expect(clock.nowNanos()).andReturn(0L).andReturn(1000L);`
- Mehrdad Nurolahzade
On Nov. 29, 2016, 10:14 p.m., R
---
On Nov. 29, 2016, 10:14 p.m., Reza Motamedi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54107/
> ---
>
> (Updated Nov. 29,
/InstrumentingInterceptorTest.java
(lines 152 - 156)
<https://reviews.apache.org/r/54107/#comment228038>
Can't we verify the actual values here?
- Mehrdad Nurolahzade
On Nov. 29, 2016, 10:14 p.m., Reza Motamedi wrote:
>
> ---
d
like this are much harder to spot; having name formats extracted out always as
constantsis a great help in faster spotting them.
- Mehrdad Nurolahzade
On Nov. 30, 2016, 5:53 p.m., Reza Motamedi wrote:
>
> ---
> This is an autom
/InstrumentingInterceptor.java
(lines 90 - 94)
<https://reviews.apache.org/r/54107/#comment228252>
Sorry, another nit, we can reduce GC overhead by not generating stat name
with every interception simply by mapping from `Method` to `SlidingStats` here
(see `TimedInterceptor`).
- Mehrdad Nurol
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54107/#review157657
---
Ship it!
Thanks, appreciate it!
- Mehrdad Nurolahzade
On
/TaskStateMachine.java (line 474)
<https://reviews.apache.org/r/54269/#comment228304>
Did you experiment with switching state transition logs off?
https://github.com/apache/aurora/blob/master/commons/src/main/java/org/apache/aurora/common/util/StateMachine.java#L389
- Mehrdad Nurolahzade
On Dec. 1, 2
439/#comment229108>
This lookup seems like something that can be improved by an index? I.e., a
mapping from `instanceId -> IScheduledTask`.
- Mehrdad Nurolahzade
On Dec. 7, 2016, 6:36 a.m., Joshua Cohen wrote:
>
> -
> On Dec. 7, 2016, 8:42 a.m., Mehrdad Nurolahzade wrote:
> > A general side note: SLA metrics calculation is currently the most
> > expensive cpu-bound operation handled by the scheduler (it can take as much
> > as 50% master cpu cycles). The calculators seem like a go
---
>
> (Updated Dec. 7, 2016, 9:50 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham,
> and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The metric is calculated from the time of the `
> On Dec. 7, 2016, 8:42 a.m., Mehrdad Nurolahzade wrote:
> > A general side note: SLA metrics calculation is currently the most
> > expensive cpu-bound operation handled by the scheduler (it can take as much
> > as 50% master cpu cycles). The calculators seem like a go
ther prefer binary state (0/1 value) to counter-like stats here.
See `org.apache.aurora.scheduler.SchedulerLifecycle` as an example.
- Mehrdad Nurolahzade
On Dec. 11, 2016, 5:32 p.m., Jing Chen wrote:
>
> ---
> This is an automat
> On Dec. 12, 2016, 2:15 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java,
> > lines 135-151
> > <https://reviews.apache.org/r/54624/diff/2/?file=1581612#file1581612line135>
> >
> >
> On Dec. 12, 2016, 2:15 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java,
> > lines 135-151
> > <https://reviews.apache.org/r/54624/diff/2/?file=1581612#file1581612line135>
> >
> >
`SnapshotField`
interface: https://github.com/google/guice/wiki/AOP#limitations
- Mehrdad Nurolahzade
On Dec. 18, 2016, 3:51 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
1 - 100 of 248 matches
Mail list logo
