Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Mehrdad Nurolahzade
://reviews.apache.org/r/48082/diff/ Testing --- Manual/Explorative: Invoked from CLI-side to see if the new API call works as intended Integration: ./build-support/jenkins/build.sh E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Mehrdad Nurolahzade

Re: Review Request 48082: AURORA-1624 New thrift API for retrieving tier configuration

2016-06-07 Thread Mehrdad Nurolahzade
://reviews.apache.org/r/48082/diff/ Testing --- Manual/Explorative: Invoked from CLI-side to see if the new API call works as intended Integration: ./build-support/jenkins/build.sh E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Mehrdad Nurolahzade

Re: Review Request 48082: AURORA-1624 New thrift API for retrieving tier configuration

2016-06-07 Thread Mehrdad Nurolahzade
API call works as intended Integration: ./build-support/jenkins/build.sh E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Mehrdad Nurolahzade

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Mehrdad Nurolahzade
as intended Integration: ./build-support/jenkins/build.sh E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Mehrdad Nurolahzade

Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-10 Thread Mehrdad Nurolahzade
/test_end_to_end.sh ... *** OK (All tests passed) *** mesos-master start/running, process 26886 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real17m53.514s user0m1.443s sys 0m0.624s ``` Thanks, Mehrdad

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
/test_end_to_end.sh ... *** OK (All tests passed) *** mesos-master start/running, process 26886 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real17m53.514s user0m1.443s sys 0m0.624s ``` Thanks, Mehrdad

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
tests passed) *** mesos-master start/running, process 26886 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real17m53.514s user0m1.443s sys 0m0.624s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137553 --- @ReviewBot retry - Mehrdad Nurolahzade On June 14, 2016, 10:12

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-14 Thread Mehrdad Nurolahzade
anager``` but then realized that migration scripts are instantiated through reflection by ibatis and Guice injection did not work on them (or I don't know enough about Guice to make it work). Any suggestions? - Mehrdad Nurolahzade On June 14, 2016, 9:46 a.m., Mehrdad Nurolahzade

Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-05-31 Thread Mehrdad Nurolahzade
: https://reviews.apache.org/r/48082/diff/ Testing --- Manual/Explorative: Invoked from CLI-side to see if the new API call works as intended Integration: ./build-support/jenkins/build.sh E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Mehrdad Nurolahzade

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-15 Thread Mehrdad Nurolahzade
Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48559/#review137763 --- On June 14, 2016, 10:12 a.m., Mehrdad Nurolahzade wrote:

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-17 Thread Mehrdad Nurolahzade
+ restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real17m53.514s user0m1.443s sys 0m0.624s ``` Thanks, Mehrdad Nurolahzade

Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-21 Thread Mehrdad Nurolahzade
te_pkg_resources File ".bootstrap/pkg_resources.py", line 2190, in load File "apache/aurora/executor/bin/thermos_executor_main.py", line 31, in File "apache/aurora/config/__init__.py", line 28, in File "apache/aurora/config/thrift.py", line 21, in ImportError: No module named client.api ``` Not sure if this is the right way to go, please advise. Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-21 Thread Mehrdad Nurolahzade
urora/config/thrift.py", line 21, in ImportError: No module named client.api ``` Not sure if this is the right way to go, please advise. The error obviously goes away by adding ```src/main/python/apache/aurora/client``` to executor pants BUILD file. But, 'is that OK if I introduce this dependency?' is what I am asking. Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-21 Thread Mehrdad Nurolahzade
chy. Now, I can move back to ```config.py``` again. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review138964 ---------

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-20 Thread Mehrdad Nurolahzade
) *** mesos-master start/running, process 26886 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real17m53.514s user0m1.443s sys 0m0.624s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Mehrdad Nurolahzade
This should be unnecessary as zero is the default value for > > 'production'. > > Mehrdad Nurolahzade wrote: > Isn't this required to resolve the inconsistencies between the choice of > ```production``` and ```tier``` in already scheduled jobs? > For exa

Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary

2016-06-16 Thread Mehrdad Nurolahzade
iff: https://reviews.apache.org/r/48796/diff/ Testing --- ``` ./build-support/jenkins/build.sh + date Thu Jun 16 08:57:08 PDT 2016 + ./gradlew -Pq clean build ... 09:03:14 00:03 [complete] SUCCESS ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 48559: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - Backfill portion

2016-06-16 Thread Mehrdad Nurolahzade
This should be unnecessary as zero is the default value for > > 'production'. > > Mehrdad Nurolahzade wrote: > Isn't this required to resolve the inconsistencies between the choice of > ```production``` and ```tier``` in already scheduled jobs? > For exa

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-23 Thread Mehrdad Nurolahzade
) <https://reviews.apache.org/r/49048/#comment204470> This is left over from refactoring, will remove. - Mehrdad Nurolahzade On June 23, 2016, 3:35 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically g

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-23 Thread Mehrdad Nurolahzade
/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
'preemptible']) and not to_bool(tier.settings['revocable']) ``` - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139597 -

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139597 ------- On June 27, 2016, 9:02 a.m., Mehrdad Nurolahzade wrote: > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139597 ------- On June 27, 2016, 9:02 a.m., Mehrdad Nurolahzade wrote: > > --- >

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-23 Thread Mehrdad Nurolahzade
ing update for: hello Job update has started. View your update progress at http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b This job update will: add instances: [2-3] update instances: [0-1] Thanks, Mehrdad Nurolahzade

Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Mehrdad Nurolahzade
ache.org/r/47550/diff/ Testing --- Automated: ./pants test.pytest --no-fast src/test/python:: Manual: using vagrant e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Style: ./build-support/hooks/pre-commit Thanks, Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Mehrdad Nurolahzade
03) <https://reviews.apache.org/r/47550/#comment198436> Copy & pasted from DiffCommand.execute() in jobs.py src/main/python/apache/aurora/client/cli/update.py (line 205) <https://reviews.apache.org/r/47550/#comment198437> What should we do if the api.job_update_diff() call fail

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-18 Thread Mehrdad Nurolahzade
tances: [2-3] update instances: [0-1] Thanks, Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-24 Thread Mehrdad Nurolahzade
sit: https://reviews.apache.org/r/47550/#review133966 ------- On May 23, 2016, 9:38 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-20 Thread Mehrdad Nurolahzade
hello Job update has started. View your update progress at http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b This job update will: add instances: [2-3] update instances: [0-1] Thanks, Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-20 Thread Mehrdad Nurolahzade
-42ca-8453-1b172f61a23b This job update will: add instances: [2-3] update instances: [0-1] Thanks, Mehrdad Nurolahzade

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread Mehrdad Nurolahzade
145) <https://reviews.apache.org/r/47550/#comment198676> This is gonna break for update command (which does not supply local_tasks), so it needs to be something like: self.diff_no_update_details([] if local_tasks is None else local_tasks) - Mehrdad Nurolahzade On May 19, 2016

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

2016-05-19 Thread Mehrdad Nurolahzade
local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b This job update will: add instances: [2-3] update instances: [0-1] Thanks, Mehrdad Nurolahzade

Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-25 Thread Mehrdad Nurolahzade
://reviews.apache.org/r/50432/diff/ Testing --- ``` ./build-support/jenkins/build.sh ``` Thanks, Mehrdad Nurolahzade

Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-14 Thread Mehrdad Nurolahzade
Diff: https://reviews.apache.org/r/50052/diff/ Testing --- Manual, Jenkins, and end_to_end Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade

Review Request 50530: AURORA-1656 Document tier concept

2016-07-27 Thread Mehrdad Nurolahzade
Diff: https://reviews.apache.org/r/50530/diff/ Testing --- Thanks, Mehrdad Nurolahzade

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Mehrdad Nurolahzade
/python/apache/aurora/client/test_config.py 4742fa28e3156e5b20791b80f2db8392f7f2f4bf Diff: https://reviews.apache.org/r/50432/diff/ Testing --- ``` ./build-support/jenkins/build.sh ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Mehrdad Nurolahzade
.apache.org/r/50432/#review144191 --- On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 50530: AURORA-1656 Document tier concept

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50530/#review144167 --- Can we git this merged? - Mehrdad Nurolahzade On July 27, 2016

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Mehrdad Nurolahzade
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review144191 ------- On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote: > > --- > T

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
. I'll sibmit a new version shortly. - Mehrdad Nurolahzade On July 29, 2016, 2:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
4742fa28e3156e5b20791b80f2db8392f7f2f4bf Diff: https://reviews.apache.org/r/50617/diff/ Testing --- `./pants test src/test/python/apache/aurora/client/cli:cli` Thanks, Mehrdad Nurolahzade

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
/python/apache/aurora/client/cli:cli` Thanks, Mehrdad Nurolahzade

Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
/ Testing --- `./pants test src/test/python/apache/aurora/client/cli:cli` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
------ On July 25, 2016, 8:30 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > -

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-26 Thread Mehrdad Nurolahzade
-- On July 25, 2016, 7:36 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50432/ > ---

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-26 Thread Mehrdad Nurolahzade
> On July 26, 2016, 7:36 a.m., Joshua Cohen wrote: > > I know this is already landed, but it would be nice to follow this up with > > a test case if possible? > > Mehrdad Nurolahzade wrote: > The logic has two test cases: > (https://gi

Re: Review Request 50530: AURORA-1656 Document tier concept

2016-07-27 Thread Mehrdad Nurolahzade
/multitenancy.md 62bcd535d3bf39c9ea7e6d5958f6ae8ba0867c0d docs/reference/configuration.md 64c076d862453545652fbaa2d3e29f284ddd164d Diff: https://reviews.apache.org/r/50530/diff/ Testing --- Thanks, Mehrdad Nurolahzade

Re: Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-10 Thread Mehrdad Nurolahzade
do. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50902/#review145364 --- On Aug. 8, 2016, 10:13 a.m., Mehrdad Nu

Re: Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-10 Thread Mehrdad Nurolahzade
> On Aug. 10, 2016, 10:36 a.m., Maxim Khutornenko wrote: > > The easiest way to validate doc changes like this is to push your branch to > > your github remote and post a link here for review. Care to give it a try? > > Mehrdad Nurolahzade wrote: > Will do. Here i

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-20 Thread Mehrdad Nurolahzade
/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json Rendering of labels by Mesos master /salves endpoint https://reviews.apache.org/media/uploaded/files/2016/07/20/ea4b6db5-de80-4327-bfb4-6bd965ae21d1__Screen_Shot_2016-07-20_at_12.26.06_PM.png Thanks, Mehrdad Nurolahzade

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-18 Thread Mehrdad Nurolahzade
ly, visit: https://reviews.apache.org/r/50052/#review142524 ------- On July 15, 2016, 1:15 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-18 Thread Mehrdad Nurolahzade
gle/protobuf/util/JsonFormat.java > > * > > http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3 > > Mehrdad Nurolahzade wrote: > Looking into protobuf util ... I can see that we already have [jackson-datatype-protobuf](https://

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-18 Thread Mehrdad Nurolahzade
gle/protobuf/util/JsonFormat.java > > * > > http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3 > > Mehrdad Nurolahzade wrote: > Looking into protobuf util ... > > Mehrdad Nurolahzade wrote: > I can see that we already have &

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-18 Thread Mehrdad Nurolahzade
Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-18 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142681 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 4:15

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-18 Thread Mehrdad Nurolahzade
, Mehrdad Nurolahzade

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-18 Thread Mehrdad Nurolahzade
/files/2016/07/18/50faae5c-45ac-45af-aa3c-d68ca09d2e72__offers-new.json Thanks, Mehrdad Nurolahzade

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-19 Thread Mehrdad Nurolahzade
", "value": "devcluster/www-data/prod/hello"}] } } } ]' \ -X POST http://192.168.33.7:5050/master/reserve ``` - Mehrdad --- This is an automatically generated e-mail. To

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-19 Thread Mehrdad Nurolahzade
generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142810 --- On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automaticall

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142828 --- On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wrote: > > ---

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
----------- On July 20, 2016, 10:56 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
- Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142828 --- On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wro

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-20 Thread Mehrdad Nurolahzade
://reviews.apache.org/media/uploaded/files/2016/07/19/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json Thanks, Mehrdad Nurolahzade

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-15 Thread Mehrdad Nurolahzade
BEAN` > > function returns) Correct, going to refactor all. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142326 ----------

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-15 Thread Mehrdad Nurolahzade
://reviews.apache.org/r/50052/diff/ Testing --- Manual, Jenkins, and end_to_end Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
+ true Connection to 127.0.0.1 closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
[complete] > >FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" This is passing locally, not sure why it's breaking on the server. - Mehrdad -

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
/aurora/e2e/test_end_to_end.sh *** OK (All tests passed) *** mesos-master start/running, process 26868 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad

Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
0m1.318s sys 0m0.533s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
> On June 28, 2016, 1:53 p.m., David McLaughlin wrote: > > config/legacy_untested_classes.txt, line 44 > > <https://reviews.apache.org/r/49334/diff/1/?file=1432053#file1432053line44> > > > > Isn't this a fairly easy class to test? > > Mehrdad

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
0m1.318s sys 0m0.533s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
, Mehrdad Nurolahzade

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
e here I decided to give up. Let me know if you have any suggestion for testing. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139857 -------

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
g/r/49048/#review139923 --- On June 28, 2016, 4:57 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
+ restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real19m46.324s user0m1.496s sys 0m0.774s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141329 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 1:12

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote: > > > > Mehrdad Nurolahzade wrote: > Should this be merged with upstream now that 0.15 is released? > > Joshua Cohen wrote: > Yes, we can land this now. Would you mind rebasing? Then I can commit it. Alright

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-11 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141698 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 4:15

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-04 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144823 --- Ship it! Ship It! - Mehrdad Nurolahzade On Aug. 4, 2016, 2

Review Request 50902: AURORA-1656 Fix broken links in tier documentation

2016-08-08 Thread Mehrdad Nurolahzade
docs/reference/configuration.md 16b31be5bf3021eb2f646e7a4361d5b614bd1164 Diff: https://reviews.apache.org/r/50902/diff/ Testing --- Manual testing Thanks, Mehrdad Nurolahzade

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

2017-01-31 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56131/#review163701 --- Ship it! Ship It! - Mehrdad Nurolahzade On Jan. 31, 2017

Re: Review Request 56265: Move Aurora to v1 Protobufs.

2017-02-04 Thread Mehrdad Nurolahzade
refactoring from `slave` to `agent`? - Mehrdad Nurolahzade On Feb. 3, 2017, 11:38 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56361: Add additional tests for the conversion of TaskStatus.

2017-02-07 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56361/#review164519 --- Ship it! Ship It! - Mehrdad Nurolahzade On Feb. 6, 2017, 6

Re: Review Request 56361: Add additional tests for the conversion of TaskStatus.

2017-02-07 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56361/#review164517 --- @ReviewBot retry - Mehrdad Nurolahzade On Feb. 6, 2017, 6:44

Re: Review Request 55357: AURORA-1867 Consider reserving for multiple tasks per preemption round

2017-01-24 Thread Mehrdad Nurolahzade
in the patch. A more representative cluster setup would be one in which only a subset of potential victims pass `PreemptionVictimFilter.filterPreemptionVictims()` test. Thanks, Mehrdad Nurolahzade

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-25 Thread Mehrdad Nurolahzade
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review163042 ----------- On Dec. 29, 2016, 9:58 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Review Request 56048: Preemption performance improvement and new metrics release notes entry

2017-01-27 Thread Mehrdad Nurolahzade
--- Preemption performance improvement and new metrics release notes entry Diffs - RELEASE-NOTES.md 7d01c90610e2cddf0f0629af669fd3bdb2afa7c5 Diff: https://reviews.apache.org/r/56048/diff/ Testing --- Thanks, Mehrdad Nurolahzade

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-28 Thread Mehrdad Nurolahzade
ine51> > > > > ... should we use `scheduler_` as a prefix here as well? Done. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review163351 --------

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-28 Thread Mehrdad Nurolahzade
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real28m58.389s user0m1.508s sys 0m0.820s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-28 Thread Mehrdad Nurolahzade
/test_end_to_end.sh ... *** OK (All tests passed) *** mesos-master start/running, process 2359 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real28m58.389s user0m1.508s sys 0m0.820s ``` Thanks, Mehrdad Nurolahzade

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-26 Thread Mehrdad Nurolahzade
/test_end_to_end.sh ... *** OK (All tests passed) *** mesos-master start/running, process 2359 + RETCODE=0 + restore_netrc + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc + true Connection to 127.0.0.1 closed. real28m58.389s user0m1.508s sys 0m0.820s ``` Thanks, Mehrdad

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-26 Thread Mehrdad Nurolahzade
> > @ThriftWorkload(result -> > > result.getJobSummaryResult().getSummariesSize()) > > ``` > > Mehrdad Nurolahzade wrote: > I like it! Let me try. Unfortunately, due to language limitations, the elegant lambda expression approach you suggested is not

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-24 Thread Mehrdad Nurolahzade
riables-thread-safe-in-java - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review162893 --- On Dec. 29, 201

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
-- On Feb. 22, 2017, 11:34 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56935/ > ---

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
ibility into heap/GC. - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56935/#review166387 --- On Feb. 22, 2017, 11:3

Re: Review Request 56935: Fix for unnecessary object serializations

2017-02-22 Thread Mehrdad Nurolahzade
/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044 Diff: https://reviews.apache.org/r/56935/diff/ Testing --- ```./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh``` Thanks, Mehrdad Nurolahzade

  1   2   3   >