Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread John Sirois 


> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote:
> > build-support/thrift/Makefile, line 28
> > 
> >
> > The ticket says this patch was committed in 0.9.2. Would it be more 
> > productive to upgrade to 0.9.2+ before complicating our thrift build?
> > 
> > Not a blocker to landing this but I think it would be nice if we didn't 
> > have to download a patch for our vendored thrit.
> 
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.3 are not useable in python, details here: 
> https://issues.apache.org/jira/browse/THRIFT-3388
> In short, thrift folks accepted a patch they never should have that 
> poisened python use for any but the vey simplest structs and service methods.
> 
> John Sirois wrote:
> More info on this from the Aurora point of view is here: 
> https://issues.apache.org/jira/browse/AURORA-1083

I was able to simplify further though for the 2 platforms I'm testing against - 
Arch and OSX 10.10


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
---


On Nov. 17, 2015, 7:56 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 17, 2015, 7:56 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106868
---

Ship it!


Master (86761e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 17, 2015, 2:56 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 17, 2015, 2:56 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 17, 2015, 7:56 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Minimize the compilation fix, only the patch is needed.

 build-support/thrift/.gitignore |  1 -
 build-support/thrift/Makefile   | 29 -
 2 files changed, 4 insertions(+), 26 deletions(-)


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote:
> > Heh, took a few rounds to understand what was going on 
> > here...case-insensitive file system strikes again!
> > ```
> > ...
> > Making install in lib
> > /Library/Developer/CommandLineTools/usr/bin/make  install-am
> > if test no = no; then \
> >   case 'darwin15.0.0' in \
> > darwin[56]*) \
> >   need_charset_alias=true ;; \
> > darwin* | cygwin* | mingw* | pw32* | cegcc*) \
> >   need_charset_alias=false ;; \
> > *) \
> >   need_charset_alias=true ;; \
> >   esac ; \
> > else \
> >   need_charset_alias=false ; \
> > fi ; \
> > if $need_charset_alias; then \
> >   /bin/sh 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/build-aux/install-sh
> >  -d /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib ; \
> > fi ; \
> > if test -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias;
> >  then \
> >   sed -f ref-add.sed 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> >   rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > else \
> >   if $need_charset_alias; then \
> > sed -f ref-add.sed charset.alias > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> > rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   fi ; \
> > fi
> >  ../build-aux/install-sh -c -d 
> > '/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib'
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > File exists
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > Not a directory
> > make[5]: *** [install-libLIBRARIES] Error 1
> > make[4]: *** [install-am] Error 2
> > make[3]: *** [install] Error 2
> > make[2]: *** [install-recursive] Error 1
> > make[1]: *** [install] Error 2
> > ```
> > 
> > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P
> 
> John Sirois wrote:
> Hrm - serves me right for installing OSX on case-sensitive HFS+.
> Fixed; although the AuroraBot will continue to be red due to 
> https://reviews.apache.org/r/40334/

Alright - rebasing against https://reviews.apache.org/r/40334/ so AuroraBot can 
go green.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106597
---


On Nov. 16, 2015, 8:13 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 8:13 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 16, 2015, 8:13 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Fixup BISON_PREFIX to use a unique (case aside) dirent name.

 build-support/thrift/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.

 build-support/thrift/.gitignore |  7 ---
 build-support/thrift/Makefile   | 47 
++-
 2 files changed, 42 insertions(+), 12 deletions(-)


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote:
> > Heh, took a few rounds to understand what was going on 
> > here...case-insensitive file system strikes again!
> > ```
> > ...
> > Making install in lib
> > /Library/Developer/CommandLineTools/usr/bin/make  install-am
> > if test no = no; then \
> >   case 'darwin15.0.0' in \
> > darwin[56]*) \
> >   need_charset_alias=true ;; \
> > darwin* | cygwin* | mingw* | pw32* | cegcc*) \
> >   need_charset_alias=false ;; \
> > *) \
> >   need_charset_alias=true ;; \
> >   esac ; \
> > else \
> >   need_charset_alias=false ; \
> > fi ; \
> > if $need_charset_alias; then \
> >   /bin/sh 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/build-aux/install-sh
> >  -d /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib ; \
> > fi ; \
> > if test -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias;
> >  then \
> >   sed -f ref-add.sed 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> >   rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > else \
> >   if $need_charset_alias; then \
> > sed -f ref-add.sed charset.alias > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> > rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   fi ; \
> > fi
> >  ../build-aux/install-sh -c -d 
> > '/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib'
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > File exists
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > Not a directory
> > make[5]: *** [install-libLIBRARIES] Error 1
> > make[4]: *** [install-am] Error 2
> > make[3]: *** [install] Error 2
> > make[2]: *** [install-recursive] Error 1
> > make[1]: *** [install] Error 2
> > ```
> > 
> > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P

Hrm - serves me right for installing OSX on case-sensitive HFS+.
Fixed; although the AuroraBot will continue to be red due to 
https://reviews.apache.org/r/40334/


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106597
---


On Nov. 15, 2015, 9:13 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 15, 2015, 9:13 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106668
---


Master (7b494f4) is red with this patch.
  ./build-support/jenkins/build.sh

15:29:04 00:00 [ivy-imports]
15:29:04 00:00   [unpack-jars]
15:29:04 00:00 [unpack-jars]
15:29:04 00:00   [deferred-sources]
15:29:04 00:00 [deferred-sources]
15:29:04 00:00   [gen]
15:29:04 00:00 [thrift]
15:29:04 00:00 [protoc]
15:29:04 00:00 [antlr]
15:29:04 00:00 [ragel]
15:29:04 00:00 [jaxb]
15:29:04 00:00 [wire]
15:29:04 00:00   [jvm-platform-validate]
15:29:04 00:00 [jvm-platform-validate]
15:29:04 00:00   [resolve]
15:29:04 00:00 [ivy]
15:29:04 00:00   [bootstrap-nailgun-server]
15:29:05 00:01   [compile]
15:29:05 00:01 [compile]
15:29:05 00:01 [jvm]
15:29:05 00:01   [jvm-compilers]
15:29:05 00:01 [zinc-pre]
15:29:05 00:01 [zinc-post]
15:29:05 00:01 [jvm-dep-check]
15:29:05 00:01   [resources]
15:29:05 00:01 [prepare]
15:29:05 00:01 [services]
15:29:05 00:01   [test]
15:29:05 00:01 [run_prep_command]
15:29:05 00:01 [test]
15:29:05 00:01 [pytest]
15:29:05 00:01   [run]
 
15:29:07 00:03 [chroot]
15:29:11 00:07   [complete]
   FAILURE
Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)




I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 3:28 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 3:28 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 16, 2015, 1:05 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Fixup BISON_PREFIX to use a unique (case aside) dirent name.

 build-support/thrift/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.

 build-support/thrift/.gitignore |  7 ---
 build-support/thrift/Makefile   | 47 
++-
 2 files changed, 42 insertions(+), 12 deletions(-)


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote:
> > build-support/thrift/Makefile, line 28
> > 
> >
> > The ticket says this patch was committed in 0.9.2. Would it be more 
> > productive to upgrade to 0.9.2+ before complicating our thrift build?
> > 
> > Not a blocker to landing this but I think it would be nice if we didn't 
> > have to download a patch for our vendored thrit.

Sadly 0.9.2 and 0.9.3 are not useable in python, details here: 
https://issues.apache.org/jira/browse/THRIFT-3388
In short, thrift folks accepted a patch they never should have that poisened 
python use for any but the vey simplest structs and service methods.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
---


On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 1:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote:
> > build-support/thrift/Makefile, line 28
> > 
> >
> > The ticket says this patch was committed in 0.9.2. Would it be more 
> > productive to upgrade to 0.9.2+ before complicating our thrift build?
> > 
> > Not a blocker to landing this but I think it would be nice if we didn't 
> > have to download a patch for our vendored thrit.
> 
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.3 are not useable in python, details here: 
> https://issues.apache.org/jira/browse/THRIFT-3388
> In short, thrift folks accepted a patch they never should have that 
> poisened python use for any but the vey simplest structs and service methods.

More info on this from the Aurora point of view is here: 
https://issues.apache.org/jira/browse/AURORA-1083


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
---


On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 1:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 16, 2015, 1:11 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description (updated)
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.


Diffs
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106726
---

Ship it!


Master (86761e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 8:11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 8:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106558
---

Ship it!


A working build on Arch, thanks for that\!

- Stephan Erb


On Nov. 15, 2015, 12:44 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 15, 2015, 12:44 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
---



build-support/thrift/.gitignore (line 1)


How about wildcards so we don't trip over this when upgrading bison/thrift?



build-support/thrift/Makefile (line 49)


On OS X 10.11 i get the following from this line:
```
sha256=$(curl -s https://ftp.gnu.org/gnu/bison/bison-2.5.1.tar.gz | tee 
bison-2.5.1.tar.gz |openssl sha256 | cut -d' ' -f2) && \
[ "${sha256}" = 
"48dc3649231b75ac160d73528000ec89b6cd8d3b87cb7d0713f72ef4610442d4" ] && \
tar zxvf bison-2.5.1.tar.gz && \
cd bison-2.5.1 && \
./configure 
--prefix=/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install && \
make clean && make -j4 && \
make install
openssl:Error: 'sha256' is an invalid command.
```

Looks like the command syntax on OS X is `openssl dgst -sha256`, i don't 
suppose that's supported by your version of openssl?

I feel like i've been down this road before, not sure if  i've found a 
universal command.


- Bill Farner


On Nov. 14, 2015, 3:44 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 14, 2015, 3:44 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106588
---


Master (7b494f4) is red with this patch.
  ./build-support/jenkins/build.sh

02:52:16 00:00 [ivy-imports]
02:52:16 00:00   [unpack-jars]
02:52:16 00:00 [unpack-jars]
02:52:16 00:00   [deferred-sources]
02:52:16 00:00 [deferred-sources]
02:52:16 00:00   [gen]
02:52:16 00:00 [thrift]
02:52:16 00:00 [protoc]
02:52:16 00:00 [antlr]
02:52:16 00:00 [ragel]
02:52:16 00:00 [jaxb]
02:52:16 00:00 [wire]
02:52:16 00:00   [jvm-platform-validate]
02:52:16 00:00 [jvm-platform-validate]
02:52:16 00:00   [resolve]
02:52:16 00:00 [ivy]
02:52:16 00:00   [bootstrap-nailgun-server]
02:52:17 00:01   [resources]
02:52:17 00:01 [prepare]
02:52:17 00:01 [services]
02:52:17 00:01   [compile]
02:52:17 00:01 [compile]
02:52:17 00:01 [jvm]
02:52:17 00:01   [jvm-compilers]
02:52:17 00:01 [zinc-pre]
02:52:17 00:01 [zinc-post]
02:52:17 00:01 [jvm-dep-check]
02:52:17 00:01   [test]
02:52:17 00:01 [run_prep_command]
02:52:17 00:01 [test]
02:52:17 00:01 [pytest]
02:52:17 00:01   [run]
 
02:52:19 00:03 [chroot]
02:52:22 00:06   [complete]
   FAILURE
Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)




I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 2:45 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 2:45 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 


> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote:
> > build-support/thrift/.gitignore, line 1
> > 
> >
> > How about wildcards so we don't trip over this when upgrading 
> > bison/thrift?

Sounds good - done.


> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote:
> > build-support/thrift/Makefile, line 50
> > 
> >
> > On OS X 10.11 i get the following from this line:
> > ```
> > sha256=$(curl -s https://ftp.gnu.org/gnu/bison/bison-2.5.1.tar.gz | tee 
> > bison-2.5.1.tar.gz |openssl sha256 | cut -d' ' -f2) && \
> > [ "${sha256}" = 
> > "48dc3649231b75ac160d73528000ec89b6cd8d3b87cb7d0713f72ef4610442d4" ] && \
> > tar zxvf bison-2.5.1.tar.gz && \
> > cd bison-2.5.1 && \
> > ./configure 
> > --prefix=/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install 
> > && \
> > make clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> > 
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i 
> > don't suppose that's supported by your version of openssl?
> > 
> > I feel like i've been down this road before, not sure if  i've found a 
> > universal command.
> 
> John Sirois wrote:
> `openssl dgst -sha256` does work for me.  I'll see if it works on my OSX 
> 10.10.5 machine and in the Vagrant image and report back.

Fixed.  Have not tried on my 10.10.5 yet, I'll update with that result later - 
Vagrant trusty image like it though.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
---


On Nov. 14, 2015, 4:44 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 14, 2015, 4:44 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 15, 2015, 7:45 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Improve thrift 0.9.1 build.

+ Use a more flexible .gitignore with an eye to future thrift upgrades.
+ Use a more portable sha256 hash command.
+ Apply a patch that made it into thrift 0.9.2 that improves the
  robustness of the 0.9.1 build across platforms.

 build-support/thrift/.gitignore |  6 ++
 build-support/thrift/Makefile   | 12 ++--
 2 files changed, 12 insertions(+), 6 deletions(-)


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.

 build-support/thrift/.gitignore |  7 ---
 build-support/thrift/Makefile   | 47 
++-
 2 files changed, 42 insertions(+), 12 deletions(-)


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 


> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote:
> > build-support/thrift/Makefile, line 50
> > 
> >
> > On OS X 10.11 i get the following from this line:
> > ```
> > sha256=$(curl -s https://ftp.gnu.org/gnu/bison/bison-2.5.1.tar.gz | tee 
> > bison-2.5.1.tar.gz |openssl sha256 | cut -d' ' -f2) && \
> > [ "${sha256}" = 
> > "48dc3649231b75ac160d73528000ec89b6cd8d3b87cb7d0713f72ef4610442d4" ] && \
> > tar zxvf bison-2.5.1.tar.gz && \
> > cd bison-2.5.1 && \
> > ./configure 
> > --prefix=/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install 
> > && \
> > make clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> > 
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i 
> > don't suppose that's supported by your version of openssl?
> > 
> > I feel like i've been down this road before, not sure if  i've found a 
> > universal command.

`openssl dgst -sha256` does work for me.  I'll see if it works on my OSX 
10.10.5 machine and in the Vagrant image and report back.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
---


On Nov. 14, 2015, 4:44 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 14, 2015, 4:44 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 


> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote:
> > build-support/thrift/Makefile, line 50
> > 
> >
> > On OS X 10.11 i get the following from this line:
> > ```
> > sha256=$(curl -s https://ftp.gnu.org/gnu/bison/bison-2.5.1.tar.gz | tee 
> > bison-2.5.1.tar.gz |openssl sha256 | cut -d' ' -f2) && \
> > [ "${sha256}" = 
> > "48dc3649231b75ac160d73528000ec89b6cd8d3b87cb7d0713f72ef4610442d4" ] && \
> > tar zxvf bison-2.5.1.tar.gz && \
> > cd bison-2.5.1 && \
> > ./configure 
> > --prefix=/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install 
> > && \
> > make clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> > 
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i 
> > don't suppose that's supported by your version of openssl?
> > 
> > I feel like i've been down this road before, not sure if  i've found a 
> > universal command.
> 
> John Sirois wrote:
> `openssl dgst -sha256` does work for me.  I'll see if it works on my OSX 
> 10.10.5 machine and in the Vagrant image and report back.
> 
> John Sirois wrote:
> Fixed.  Have not tried on my 10.10.5 yet, I'll update with that result 
> later - Vagrant trusty image like it though.

Confirmed diff 3 (forthcoming) works on OSX 10.10.5 / XCode 7.0.1


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
---


On Nov. 15, 2015, 7:45 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 15, 2015, 7:45 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 15, 2015, 9:13 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.

 build-support/thrift/.gitignore |  7 ---
 build-support/thrift/Makefile   | 47 
++-
 2 files changed, 42 insertions(+), 12 deletions(-)


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 


> On Nov. 15, 2015, 7:57 p.m., Aurora ReviewBot wrote:
> > Master (7b494f4) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 02:52:16 00:00 [ivy-imports]
> > 02:52:16 00:00   [unpack-jars]
> > 02:52:16 00:00 [unpack-jars]
> > 02:52:16 00:00   [deferred-sources]
> > 02:52:16 00:00 [deferred-sources]
> > 02:52:16 00:00   [gen]
> > 02:52:16 00:00 [thrift]
> > 02:52:16 00:00 [protoc]
> > 02:52:16 00:00 [antlr]
> > 02:52:16 00:00 [ragel]
> > 02:52:16 00:00 [jaxb]
> > 02:52:16 00:00 [wire]
> > 02:52:16 00:00   [jvm-platform-validate]
> > 02:52:16 00:00 [jvm-platform-validate]
> > 02:52:16 00:00   [resolve]
> > 02:52:16 00:00 [ivy]
> > 02:52:16 00:00   [bootstrap-nailgun-server]
> > 02:52:17 00:01   [resources]
> > 02:52:17 00:01 [prepare]
> > 02:52:17 00:01 [services]
> > 02:52:17 00:01   [compile]
> > 02:52:17 00:01 [compile]
> > 02:52:17 00:01 [jvm]
> > 02:52:17 00:01   [jvm-compilers]
> > 02:52:17 00:01 [zinc-pre]
> > 02:52:17 00:01 [zinc-post]
> > 02:52:17 00:01 [jvm-dep-check]
> > 02:52:17 00:01   [test]
> > 02:52:17 00:01 [run_prep_command]
> > 02:52:17 00:01 [test]
> > 02:52:17 00:01 [pytest]
> > 02:52:17 00:01   [run]
> >  
> > 02:52:19 00:03 [chroot]
> > 02:52:22 00:06   [complete]
> >FAILURE
> > Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
> > pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
> > 
> > 
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

This failure is unrelated to the thrift fix and in fact occurs after thrift is 
compiled by CI.
The fix for this error is here: https://reviews.apache.org/r/40334/


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106588
---


On Nov. 15, 2015, 7:45 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 15, 2015, 7:45 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106591
---


Master (7b494f4) is red with this patch.
  ./build-support/jenkins/build.sh

04:22:02 00:00 [ivy-imports]
04:22:02 00:00   [unpack-jars]
04:22:02 00:00 [unpack-jars]
04:22:02 00:00   [jvm-platform-validate]
04:22:02 00:00 [jvm-platform-validate]
04:22:02 00:00   [deferred-sources]
04:22:02 00:00 [deferred-sources]
04:22:02 00:00   [gen]
04:22:02 00:00 [thrift]
04:22:02 00:00 [protoc]
04:22:02 00:00 [antlr]
04:22:02 00:00 [ragel]
04:22:02 00:00 [jaxb]
04:22:02 00:00 [wire]
04:22:02 00:00   [resolve]
04:22:02 00:00 [ivy]
04:22:02 00:00   [bootstrap-nailgun-server]
04:22:03 00:01   [resources]
04:22:03 00:01 [prepare]
04:22:03 00:01 [services]
04:22:03 00:01   [compile]
04:22:03 00:01 [compile]
04:22:03 00:01 [jvm]
04:22:03 00:01   [jvm-compilers]
04:22:03 00:01 [zinc-pre]
04:22:03 00:01 [zinc-post]
04:22:03 00:01 [jvm-dep-check]
04:22:03 00:01   [test]
04:22:03 00:01 [run_prep_command]
04:22:03 00:01 [test]
04:22:03 00:01 [pytest]
04:22:03 00:01   [run]
 
04:22:05 00:03 [chroot]
04:22:08 00:06   [complete]
   FAILURE
Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)




I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 4:13 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 4:13 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois 


> On Nov. 15, 2015, 9:27 p.m., Aurora ReviewBot wrote:
> > Master (7b494f4) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 04:22:02 00:00 [ivy-imports]
> > 04:22:02 00:00   [unpack-jars]
> > 04:22:02 00:00 [unpack-jars]
> > 04:22:02 00:00   [jvm-platform-validate]
> > 04:22:02 00:00 [jvm-platform-validate]
> > 04:22:02 00:00   [deferred-sources]
> > 04:22:02 00:00 [deferred-sources]
> > 04:22:02 00:00   [gen]
> > 04:22:02 00:00 [thrift]
> > 04:22:02 00:00 [protoc]
> > 04:22:02 00:00 [antlr]
> > 04:22:02 00:00 [ragel]
> > 04:22:02 00:00 [jaxb]
> > 04:22:02 00:00 [wire]
> > 04:22:02 00:00   [resolve]
> > 04:22:02 00:00 [ivy]
> > 04:22:02 00:00   [bootstrap-nailgun-server]
> > 04:22:03 00:01   [resources]
> > 04:22:03 00:01 [prepare]
> > 04:22:03 00:01 [services]
> > 04:22:03 00:01   [compile]
> > 04:22:03 00:01 [compile]
> > 04:22:03 00:01 [jvm]
> > 04:22:03 00:01   [jvm-compilers]
> > 04:22:03 00:01 [zinc-pre]
> > 04:22:03 00:01 [zinc-post]
> > 04:22:03 00:01 [jvm-dep-check]
> > 04:22:03 00:01   [test]
> > 04:22:03 00:01 [run_prep_command]
> > 04:22:03 00:01 [test]
> > 04:22:03 00:01 [pytest]
> > 04:22:03 00:01   [run]
> >  
> > 04:22:05 00:03 [chroot]
> > 04:22:08 00:06   [complete]
> >FAILURE
> > Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
> > pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
> > 
> > 
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

I'll wait until https://reviews.apache.org/r/40334/ is in to update this diff.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106591
---


On Nov. 15, 2015, 9:13 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 15, 2015, 9:13 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>