Review Request 21253: AURORA-392: Add apache- to source distribution name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21253/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-392

Review Request 21247: Add config grouping visualisation to job page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/ --- Review request for Aurora, Suman Karumuri and Bill Farner. Bugs: AURORA-378

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

> On May 7, 2014, 9:01 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml, > > line 8 > > > > > > Re: style, for some reason the lack of indent here doesn't sit well

Re: Review Request 21407: Add JSHint to our build

> On May 14, 2014, 7:29 p.m., Bill Farner wrote: > > build.gradle, line 241 > > > > > > convention is single quotes unless double is needed for interpolation ack. - David -

Re: Review Request 21253: AURORA-392: Add apache- to source distribution name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21253/#review42598 --- Ship it! Ship It! - Bill Farner On May 9, 2014, 2:25 a.m., Jake

Re: Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/#review43026 --- Ship it! Ship It! - Kevin Sweeney On May 14, 2014, 2:27 p.m., Su

Re: Review Request 21247: Add config grouping visualisation to job page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/#review42980 --- Ship it! Ship It! - Suman Karumuri On May 14, 2014, 3:46 p.m., D

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review43048 --- src/main/python/apache/aurora/client/config.py

Re: Review Request 21349: Starting SLA calculations on SchedulerActive event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21349/#review43055 --- Ship it! src/main/java/org/apache/aurora/scheduler/sla/MetricCalcu

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/ --- (Updated May 14, 2014, 8:01 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43012 --- Heads up: this has high likelihood of conflicting with https://revi

Re: Review Request 21460: Removed trailing / from /api end point.

> On May 14, 2014, 9:58 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 42 > > > > > > You definitely don't need two lines, since this is a servlet URL > > pattern.

Re: Review Request 21297: Adding UpdateConfig value checks.

> On May 14, 2014, 8:32 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/config.py, lines 131-133 > > > > > > Rather than spell out a formula which may be a little intimidating, > > could you say

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43046 --- a few high level comments. still need to wade through the semantics

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/ --- (Updated May 14, 2014, 10:35 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21349: Starting SLA calculations on SchedulerActive event.

> On May 15, 2014, 12:09 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 97 > > > > > > It would be nice to change this to Amount to make it harder > > to misuse.

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review43056 --- src/main/python/apache/aurora/client/config.py

Re: Review Request 21242: Added tooltip to a disabled task sandbox link.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21242/#review42584 --- Ship it! Ship It! - David McLaughlin On May 8, 2014, 10:34 p.m.,

Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review43043 --- Ship it! Ship It! - Brian Wickman On May 14, 2014, 10:35 p.m., M

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review43060 --- Ship it! Code looks good to me. Please seriously consider adding do

Re: Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/#review43031 --- src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java

Review Request 21144: Always show resource consumption table on Job page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21144/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-386

Review Request 21223: Bugfix: make "restart" command generate a correct error message in some cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21223/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora

Re: Review Request 19767: CronScheduler based on Quartz

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19767/#review43061 --- Ship it! Ship It! - Maxim Khutornenko On May 15, 2014, 12:08 a.m

Review Request 21252: AURORA-393: release candidate script doesn't need to create checksums for signature files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21252/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-393

Re: Review Request 21188: Fix broken test build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21188/ --- (Updated May 7, 2014, 9:19 p.m.) Review request for Aurora and Maxim Khutornenk

Review Request 21188: Fix broken test build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21188/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/ --- (Updated May 14, 2014, 9:42 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 21297: Adding UpdateConfig value checks.

> On May 14, 2014, 10:55 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/config.py, line 161 > > > > > > How about adding a couple-second delay to account for executor bootup > > time. Ideally we'd

Re: Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/#review43035 --- Ship it! Ship It! - Bill Farner On May 14, 2014, 9:42 p.m., Suma

Re: Review Request 19767: CronScheduler based on Quartz

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19767/ --- (Updated May 14, 2014, 5:08 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 21247: Add config grouping visualisation to job page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/#review42626 --- I think we should show the config bar even when there is one config.

Review Request 21455: Opt-in for code quality checks to speed up development iteration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21455/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 21242: Added tooltip to a disabled task sandbox link.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21242/#review42596 --- Ship it! Ship It! - Bill Farner On May 8, 2014, 10:34 p.m., Suma

Re: Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/#review43034 --- src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java

Re: Review Request 21349: Starting SLA calculations on SchedulerActive event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21349/ --- (Updated May 14, 2014, 9:58 p.m.) Review request for Aurora and Bill Farner.

Review Request 21268: Add a "config" noun with a "list" verb to list jobs defined in a config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21268/ --- Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-40

Re: Review Request 21407: Add JSHint to our build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/ --- (Updated May 14, 2014, 10:22 p.m.) Review request for Aurora, Suman Karumuri an

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/ --- (Updated May 14, 2014, 11:46 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21252: AURORA-393: release candidate script doesn't need to create checksums for signature files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21252/#review42597 --- Ship it! Ship It! - Bill Farner On May 9, 2014, 2:15 a.m., Jake

Re: Review Request 21460: Removed trailing / from /api end point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21460/ --- (Updated May 14, 2014, 9:27 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 21145: Changed sandbox link from span2 to span3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21145/ --- (Updated May 8, 2014, 8:23 p.m.) Review request for Aurora and David McLaughlin

Re: Review Request 21297: Adding UpdateConfig value checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review43014 --- src/main/python/apache/aurora/client/config.py