---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/
---
(Updated March 23, 2015, 12:14 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77449
---
Ship it!
Master (3bb1372) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/#review77289
---
Thanks, this is already much easier to follow.
One general
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/#review77448
---
~All minor stuff.
config/pmd/custom.xml
On March 22, 2015, 11:04 a.m., Stephan Erb wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
line 107
https://reviews.apache.org/r/32352/diff/1/?file=902121#file902121line107
Slotes computed here might have overlapping victims. A simple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review77474
---
Ship it!
Ship It!
- Stephan Erb
On March 21, 2015, 3:19 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/#review77471
---
Ship it!
- Stephan Erb
On March 23, 2015, 7:10 p.m., Maxim
On March 22, 2015, 10:04 a.m., Stephan Erb wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
line 107
https://reviews.apache.org/r/32352/diff/1/?file=902121#file902121line107
Slotes computed here might have overlapping victims. A simple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32369/#review77417
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 21, 2015, 5:49
On March 23, 2015, 5:43 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77
https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77
This method also appears to be used here:
On March 23, 2015, 10:43 a.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
line 61
https://reviews.apache.org/r/32377/diff/1/?file=902302#file902302line61
Can you push the lazy instantiation logic to ModuleParser and
On March 23, 2015, 5:43 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77
https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77
This method also appears to be used here:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77423
---
src/main/java/org/apache/aurora/scheduler/app/Modules.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review77425
---
Ship it!
Ship It!
- Zameer Manji
On March 20, 2015, 7:19 p.m.,
On March 23, 2015, 6:22 p.m., Aurora ReviewBot wrote:
Master (a3a35e9) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.factory
. SUCCESS
On March 23, 2015, 5:43 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 99
https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line99
Can you push this to ModuleParser?
Good call, done.
On March 23, 2015, 5:43 p.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/
---
(Updated March 23, 2015, 6:10 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/#review77436
---
Master (a3a35e9) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/
---
(Updated March 23, 2015, 6:51 p.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77424
---
src/main/java/org/apache/aurora/scheduler/app/Modules.java
On March 21, 2015, 12:14 p.m., Stephan Erb wrote:
src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java,
line 66
https://reviews.apache.org/r/32359/diff/1/?file=902147#file902147line66
The description should state the intent of the option more explicitly.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77447
---
Ship it!
On March 23, 2015, 8:59 p.m., Joshua Cohen wrote:
Thanks, this is already much easier to follow.
One general question on the overall approach: do you think the DRY benefits
of using composed `StructFieldGetter`s to generate the functions that allow
walking from the starting type to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32372/#review77501
---
Ship it!
Ship It!
- David McLaughlin
On March 21, 2015, 9:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/
---
(Updated March 24, 2015, 12:31 a.m.)
Review request for Aurora and Kevin
On March 23, 2015, 6:56 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 99
https://reviews.apache.org/r/32377/diff/2/?file=903369#file903369line99
consider adding a Class? extends Module... overload.
-1 on the overload, +1 on the switch
26 matches
Mail list logo
