Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-08 Thread Bill Farner
/scheduler/storage/StorageBackfillTest.java 724188bfa037caccaf91cf57d82de1777ab5de8e Diff: https://reviews.apache.org/r/16740/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Bill Farner
(serviceEndpoint:Endpoint(host:192.168.33.1, port:8082), additionalEndpoints:{http=Endpoint(host:192.168.33.1, port:8081)}, status:ALIVE) Thanks, Bill Farner

Re: Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16743/#review31416 --- Thanks, folks. This is now on master. - Bill Farner On Jan. 8

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-09 Thread Bill Farner
e89e60afc107b299d572a07140d010040b2c7545 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 724188bfa037caccaf91cf57d82de1777ab5de8e Diff: https://reviews.apache.org/r/16740/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Bill Farner
On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote: In the interest of avoiding a proliferation of broken documentation links/links to drafts, would everyone be all right with committing this as-is and continuing to iterate in later reviews? Normally I prefer to review small changes in

Re: Review Request 16629: Client quota check (server side)

2014-01-13 Thread Bill Farner
the stub? I would find that easier to follow, anyhow, given that the class is purely a container. - Bill Farner On Jan. 10, 2014, 9:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16740/#review31667 --- Post-weekend ping. Waiting on Kevin and Suman here. - Bill Farner

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-13 Thread Bill Farner
--- On Jan. 9, 2014, 10:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16740/ --- (Updated

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-13 Thread Bill Farner
e89e60afc107b299d572a07140d010040b2c7545 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 724188bfa037caccaf91cf57d82de1777ab5de8e Diff: https://reviews.apache.org/r/16740/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Bill Farner
, and for some reason git/apache combined it into one massive lump. Bill Farner wrote: I'll be okay without 100% consensus, but i would like to clean up some of the formatting issues to avoid proliferation of those. Specifically, the trailing newlines and trailing whitespace. Tom Galloway wrote

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-13 Thread Bill Farner
is probably to install SchedulerzRole and SchedulerzJob in a separate helper function that doesn't create this pattern overlap. - Bill Farner On Jan. 13, 2014, 11:58 p.m., Suman Karumuri wrote: --- This is an automatically generated e

Review Request 16868: Fix build break caused by a584410.

2014-01-14 Thread Bill Farner
://reviews.apache.org/r/16868/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-15 Thread Bill Farner
it out locally? The binary files prevent me from pulling down a patch. - Bill Farner On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16528

Re: Review Request 16741: Converting py source dist versions to upper() for consistency with java side.

2014-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16741/#review31923 --- Ship it! Ship It! - Bill Farner On Jan. 8, 2014, 11:06 p.m

Re: Review Request 16265: Script for creating tags

2014-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review31960 --- Ship it! Ship It! - Bill Farner On Jan. 15, 2014, 10:57 p.m

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

2014-01-15 Thread Bill Farner
/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/16528/#comment60733 I find this behavior jarring (clicking anywhere in a row takes you to a new page). Since the data in the table cell is already a link, can this be removed? - Bill Farner On Jan. 15, 2014, 7

Re: Review Request 16945: AURORA-41: Fix broken test in client.cli.job

2014-01-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16945/#review32041 --- Ship it! Ship It! - Bill Farner On Jan. 16, 2014, 4:29 a.m

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Bill Farner
://reviews.apache.org/r/16983/#comment60766 Logic does not seem correct here. Can they both be 'falsey'? I'm probably ignorant to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable? - Bill Farner On Jan. 16, 2014, 7:59 p.m., Joe Smith wrote

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Bill Farner
On Jan. 16, 2014, 8:36 p.m., Bill Farner wrote: src/main/python/apache/aurora/client/commands/admin.py, line 38 https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38 Logic does not seem correct here. Can they both be 'falsey'? I'm probably ignorant

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

2014-01-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32077 --- On Jan. 16, 2014, 8:34 p.m., Bill Farner wrote: --- This is an automatically

Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

2014-01-16 Thread Bill Farner
da7a1678d734ddc7b513b1d0797cb097fa2ee537 Diff: https://reviews.apache.org/r/16995/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Review Request 17095: Only export counters in TaskVars after SchedulerActive event.

2014-01-18 Thread Bill Farner
/apache/aurora/scheduler/TaskVarsTest.java dde053c3173c84425d27c892b40bd38a21600357 Diff: https://reviews.apache.org/r/17095/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17086: Aurora-57: Aurora should include a DISCLAIMER

2014-01-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17086/#review32273 --- Ship it! Ship It! - Bill Farner On Jan. 18, 2014, 2:26 a.m

Re: Review Request 17086: Aurora-57: Aurora should include a DISCLAIMER

2014-01-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17086/#review32274 --- Thanks! This is now on master as 172b7e2. - Bill Farner On Jan

Re: Review Request 17106: AURORA-60:Commit e1aee67 re-creates src/main/python/twitter after namespace change occurring

2014-01-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17106/#review32275 --- Ship it! Thanks! This is now on master as b03696a. - Bill Farner

Re: Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)

2014-01-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17110/#review32279 --- Ship it! Thanks! This is now on master as d7a82dc - Bill Farner

Review Request 17131: Improve test coverage for CronJobManager.

2014-01-20 Thread Bill Farner
Diff: https://reviews.apache.org/r/17131/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Review Request 17133: Improve test coverage for TaskAssignerImpl.

2014-01-20 Thread Bill Farner
/scheduler/state/TaskAssignerImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17133/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

2014-01-20 Thread Bill Farner
/#review32096 --- On Jan. 16, 2014, 11 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16995

Re: Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

2014-01-20 Thread Bill Farner
c3aa69c1e1bf3e301806fe20fb4d8686ca941e37 src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java ce9b3934df5406659bfa2a1fac4490df6e7d7d00 Diff: https://reviews.apache.org/r/16995/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15

2014-01-21 Thread Bill Farner
dependency conflicts. Thanks, Bill Farner

Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15

2014-01-21 Thread Bill Farner
--- On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32502 --- Ping - Bill Farner On Jan. 14, 2014, 11:27 p.m., Bill Farner

Re: Review Request 17088: Cache hashCode in generated immutable classes.

2014-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17088/#review32503 --- Kevin — just waiting on a review from you. - Bill Farner On Jan

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-22 Thread Bill Farner
--- On Jan. 20, 2014, 9:01 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-22 Thread Bill Farner
e9886cdb279cc42a961d6c964e2cfae3c4c13f61 Diff: https://reviews.apache.org/r/17131/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-22 Thread Bill Farner
/aurora/scheduler/state/CronJobManagerTest.java e9886cdb279cc42a961d6c964e2cfae3c4c13f61 Diff: https://reviews.apache.org/r/17131/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15

2014-01-22 Thread Bill Farner
- build.gradle 00cabb00b81b320ef2c474da759281b3fda24967 Diff: https://reviews.apache.org/r/17161/diff/ Testing --- ./gradlew build I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts. Thanks, Bill Farner

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

2014-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17014/#review32520 --- Ship it! Ship It! - Bill Farner On Jan. 22, 2014, 7:22 p.m

Re: Review Request 17088: Cache hashCode in generated immutable classes.

2014-01-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17088/#review32660 --- On Jan. 18, 2014, 7:19 p.m., Bill Farner wrote

Re: Review Request 17088: Cache hashCode in generated immutable classes.

2014-01-23 Thread Bill Farner
-7720868a3964__by_role_cached.png Thanks, Bill Farner

Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-01-24 Thread Bill Farner
the configuration of a job, and i would prefer to not add use cases to that. It would be much tidier to compose this information _with_ JobConfiguration objects in another struct. - Bill Farner On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote

Review Request 17351: Use only a single write transaction to save HostAttributes in resourceOffers.

2014-01-24 Thread Bill Farner
2e7d7f7a6ccf3b52881d92e7d7495a261f578540 Diff: https://reviews.apache.org/r/17351/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Review Request 17353: Add a stat that tracks the number of threads waiting for the storage lock.

2014-01-25 Thread Bill Farner
eb6f9569e089858e27c2b8db15ebb66b5c6b61e7 Diff: https://reviews.apache.org/r/17353/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17353: Add a stat that tracks the number of threads waiting for the storage lock.

2014-01-25 Thread Bill Farner
--- On Jan. 25, 2014, 5:15 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17353

Review Request 17359: Avoid using protobuf equals().

2014-01-25 Thread Bill Farner
--- Avoid using protobuf equals(). Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java e4a22594f7f0288afd38d88ba32f4beff6028510 Diff: https://reviews.apache.org/r/17359/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-26 Thread Bill Farner
f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Bill Farner
, 2014, 9:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/ --- (Updated Jan. 26, 2014, 9:52 p.m

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Bill Farner
. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32894 --- On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Bill Farner
/scheduler/storage/mem/MemTaskStore.java f418c6ced6d5fc865a904ae1a93199e78abb40de src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java a1c535f1be7f53eb41d469b24e90b8bd36545e3e Diff: https://reviews.apache.org/r/17372/diff/ Testing --- ./gradlew build Thanks, Bill

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Bill Farner
of 1. - Bill Farner On Jan. 27, 2014, 11:45 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

2014-01-27 Thread Bill Farner
need to adhere to a stable API at that point. - Bill Farner On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32947 --- Can you also attach the JIRA issue please? - Bill Farner On Jan

Re: Review Request 17270: Bridge framework for client v2.

2014-01-27 Thread Bill Farner
of dead code. Can/should this be removed until it's ready to really be executed? - Bill Farner On Jan. 23, 2014, 11:10 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Bill Farner
This task needs to be different from task1 in some way, otherwise this test could deceivingly pass if the two tasks are ever placed into a Set. - Bill Farner On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote

Re: Review Request 17464: Upgrade RBTools to 0.5.5.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17464/#review33045 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2014, 9:13 p.m

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
-ship-blocks. - Bill Farner On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 14, 2014, 11:27 p.m.) Review request

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
-138 - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32551 --- On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32511 --- On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
--- ./gradlew build Thanks, Bill Farner

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33074 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2014, 10:17 p.m

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Bill Farner
--- On Jan. 31, 2014, 2:17 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17578

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Bill Farner
., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17578/ --- (Updated Jan. 31, 2014, 2:17 a.m.) Review request

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Bill Farner
/TaskAssignerImplTest.java 154ccc4716168ad966b246280370600de92d5d7f Diff: https://reviews.apache.org/r/17578/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Bill Farner
/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 154ccc4716168ad966b246280370600de92d5d7f Diff: https://reviews.apache.org/r/17578/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Bill Farner
not be needed? Bill Farner wrote: In the spirit of the interfaces, you're correct. In practice, though, it's going to be exceedingly rare that we don't do this query at least once in a scheduling round. It would only happen if there are no resource offers, or if all offer/task

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-30 Thread Bill Farner
cpu ram[MGT] disk[MGT] at least, that matches man page convention. - Bill Farner On Jan. 31, 2014, 6:26 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581

Re: Review Request 17579: AURORA-136: SchedulerLifecycle ACTIVE state is unused

2014-01-30 Thread Bill Farner
as a6f78b2. - Bill Farner On Jan. 31, 2014, 4:43 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17579

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Bill Farner
. Thanks again! - Bill Farner On Jan. 31, 2014, 7:52 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Bill Farner
/#comment62887 Please limit to 100 cols throughout src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh https://reviews.apache.org/r/17457/#comment62890 extra newline - Bill Farner On Feb. 3, 2014, 4:30 p.m., Mark Chu-Carroll wrote

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33453 --- Ship it! LGTM mod formatting nits - Bill Farner On Feb. 3, 2014

Re: Review Request 17270: Bridge framework for client v2.

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2014, 9:03 p.m

Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-03 Thread Bill Farner
85bd0a63da122e7daf2f4a12938fef043136f461 Diff: https://reviews.apache.org/r/17672/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Bill Farner
/ --- (Updated Feb. 3, 2014, 8:16 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-125 and aurora-80 https://issues.apache.org/jira/browse/aurora-125 https://issues.apache.org/jira/browse/aurora-80

Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-02-03 Thread Bill Farner
a lot more through for more broad usage. - Bill Farner On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303

Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-03 Thread Bill Farner
f2473929f501559c4f5e366d96c05fa22597bfe6 Diff: https://reviews.apache.org/r/17680/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-03 Thread Bill Farner
/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6 Diff: https://reviews.apache.org/r/17680/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Bill Farner
://reviews.apache.org/r/17562/ --- (Updated Jan. 30, 2014, 10:27 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-120 https://issues.apache.org/jira/browse/AURORA-120 Repository: aurora

Re: Review Request 17683: change max backoff timeout to be compatible with the preemption_wait hardcoded.

2014-02-03 Thread Bill Farner
of this configurable? - Bill Farner On Feb. 4, 2014, 12:28 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17683

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-04 Thread Bill Farner
. 3, 2014, 8:43 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17672/ --- (Updated Feb. 3, 2014, 8:43 p.m

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-04 Thread Bill Farner
/OfferQueue.java 85bd0a63da122e7daf2f4a12938fef043136f461 Diff: https://reviews.apache.org/r/17672/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-04 Thread Bill Farner
--- On Feb. 3, 2014, 11:20 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17680

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-04 Thread Bill Farner
/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6 Diff: https://reviews.apache.org/r/17680/diff/ Testing --- ./gradlew build Thanks, Bill Farner

Re: Review Request 17715: Added THROTTLED state to scheduler UI.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17715/#review33623 --- Ship it! Ship It! - Bill Farner On Feb. 4, 2014, 7 p.m., Suman

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-04 Thread Bill Farner
/RescheduleCalculatorImplTest.java https://reviews.apache.org/r/17717/#comment63166 Thanks for catching the incorrect org. Would it make sense to revert to 2014, though, since that's the inception date of the file? Ditto for TaskAssignerImplTest.java. - Bill Farner On Feb. 4, 2014, 7:27 p.m., Jake Farrell

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-04 Thread Bill Farner
, visit: https://reviews.apache.org/r/17672/#review33625 --- On Feb. 4, 2014, 6:41 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-04 Thread Bill Farner
On Feb. 4, 2014, 7:22 p.m., Suman Karumuri wrote: The logic is much cleaner now. Since no new tests are added, what is the code coverage of this class before and after this change? Bill Farner wrote: I will check on this and report back. By the numbers, coverage is slightly

Re: Review Request 17562: Added cluster name to page title.

2014-02-04 Thread Bill Farner
that? - Bill Farner On Feb. 4, 2014, 8:15 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-04 Thread Bill Farner
+dev, bcc reviews -=Bill On Tue, Feb 4, 2014 at 1:25 PM, Toby Weingartner tweingart...@twopensource.com wrote: As a possible extension, I could see something like: aurora quota get smf1/* = return quota information for all users -Toby. On Tue, Feb 4, 2014 at 1:24 PM, Toby

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/#review33652 --- Ship it! Ship It! - Bill Farner On Feb. 4, 2014, 10:25 p.m

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Bill Farner
Thief! You stole my idea! On Thursday, February 6, 2014, Kevin Sweeney kevi...@apache.org wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17823/

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Bill Farner
that as confirmation that schedulerActive now succeeds? - Bill Farner On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Bill Farner
. 11, 2014, 7:40 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-11 Thread Bill Farner
expect AbstractCronIT to be published for external consumption. My personal preference is to nuke AbstractCronIT with https://reviews.apache.org/r/17750, obviating the need for this reshuffling. - Bill Farner On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-12 Thread Bill Farner
, consider dropping. - Bill Farner On Feb. 12, 2014, 11:26 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34394 --- Ship it! Ship It! - Bill Farner On Feb. 12, 2014, 2:16 a.m

Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-14 Thread Bill Farner
--- $ ./gradlew build Thanks, Bill Farner

Re: Review Request 18149: Cron predictor conformance test.

2014-02-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18149/#review34555 --- Ship it! This is great, thanks!! - Bill Farner On Feb. 14, 2014

Review Request 18157: Compute task host attribute aggregates once when scheduling tasks.

2014-02-14 Thread Bill Farner
56de3aae4e08138a66a587e2a43d64a2310079f1 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java f0fdd571f273be8dad1f9410b0e70e3a11e8133b Diff: https://reviews.apache.org/r/18157/diff/ Testing --- ./gradlew build Thanks, Bill Farner

  1   2   3   4   5   6   7   8   9   10   >