the stub? I
would find that easier to follow, anyhow, given that the class is purely a
container.
- Bill Farner
On Jan. 10, 2014, 9:23 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/#review31667
---
Post-weekend ping. Waiting on Kevin and Suman here.
- Bill Farner
, and for some reason git/apache combined it into one massive lump.
Bill Farner wrote:
I'll be okay without 100% consensus, but i would like to clean up some of
the formatting issues to avoid proliferation of those. Specifically, the
trailing newlines and trailing whitespace.
Tom Galloway wrote
://reviews.apache.org/r/16868/diff/
Testing
---
Thanks,
Bill Farner
it out
locally? The binary files prevent me from pulling down a patch.
- Bill Farner
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528
On Jan. 16, 2014, 8:36 p.m., Bill Farner wrote:
src/main/python/apache/aurora/client/commands/admin.py, line 38
https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38
Logic does not seem correct here. Can they both be 'falsey'?
I'm probably ignorant
da7a1678d734ddc7b513b1d0797cb097fa2ee537
Diff: https://reviews.apache.org/r/16995/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
/apache/aurora/scheduler/TaskVarsTest.java
dde053c3173c84425d27c892b40bd38a21600357
Diff: https://reviews.apache.org/r/17095/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17086/#review32273
---
Ship it!
Ship It!
- Bill Farner
On Jan. 18, 2014, 2:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17086/#review32274
---
Thanks! This is now on master as 172b7e2.
- Bill Farner
On Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17106/#review32275
---
Ship it!
Thanks! This is now on master as b03696a.
- Bill Farner
Diff: https://reviews.apache.org/r/17131/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
/scheduler/state/TaskAssignerImplTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/17133/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
dependency conflicts.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review32502
---
Ping
- Bill Farner
On Jan. 14, 2014, 11:27 p.m., Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32503
---
Kevin — just waiting on a review from you.
- Bill Farner
On Jan
---
On Jan. 20, 2014, 9:01 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17131
/aurora/scheduler/state/CronJobManagerTest.java
e9886cdb279cc42a961d6c964e2cfae3c4c13f61
Diff: https://reviews.apache.org/r/17131/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32520
---
Ship it!
Ship It!
- Bill Farner
On Jan. 22, 2014, 7:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32660
---
On Jan. 18, 2014, 7:19 p.m., Bill Farner wrote
the
configuration of a job, and i would prefer to not add use cases to that.
It would be much tidier to compose this information _with_ JobConfiguration
objects in another struct.
- Bill Farner
On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote
---
On Jan. 25, 2014, 5:15 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17353
---
Avoid using protobuf equals().
Diffs
-
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java
e4a22594f7f0288afd38d88ba32f4beff6028510
Diff: https://reviews.apache.org/r/17359/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
f418c6ced6d5fc865a904ae1a93199e78abb40de
src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java
a1c535f1be7f53eb41d469b24e90b8bd36545e3e
Diff: https://reviews.apache.org/r/17372/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
, 2014, 9:52 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/
---
(Updated Jan. 26, 2014, 9:52 p.m
.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17372/#review32894
---
On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote
of 1.
- Bill Farner
On Jan. 27, 2014, 11:45 p.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430
need to adhere to a stable API at that
point.
- Bill Farner
On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review32947
---
Can you also attach the JIRA issue please?
- Bill Farner
On Jan
This task needs to be different from task1 in some way, otherwise this test
could deceivingly pass if the two tasks are ever placed into a Set.
- Bill Farner
On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17464/#review33045
---
Ship it!
Ship It!
- Bill Farner
On Jan. 28, 2014, 9:13 p.m
-ship-blocks.
- Bill Farner
On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873
., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/
---
(Updated Jan. 14, 2014, 11:27 p.m.)
Review request
-138
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review32551
---
On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review32511
---
On Jan. 14, 2014, 11:27 p.m., Bill Farner wrote
---
./gradlew build
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review33074
---
Ship it!
Ship It!
- Bill Farner
On Jan. 28, 2014, 10:17 p.m
---
On Jan. 31, 2014, 2:17 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17578
as a6f78b2.
- Bill Farner
On Jan. 31, 2014, 4:43 a.m., Dan Norris wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17579
. Thanks again!
- Bill Farner
On Jan. 31, 2014, 7:52 p.m., Dan Norris wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17581
/#comment62887
Please limit to 100 cols throughout
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
https://reviews.apache.org/r/17457/#comment62890
extra newline
- Bill Farner
On Feb. 3, 2014, 4:30 p.m., Mark Chu-Carroll wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/#review33471
---
Ship it!
Ship It!
- Bill Farner
On Jan. 30, 2014, 9:03 p.m
85bd0a63da122e7daf2f4a12938fef043136f461
Diff: https://reviews.apache.org/r/17672/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
f2473929f501559c4f5e366d96c05fa22597bfe6
Diff: https://reviews.apache.org/r/17680/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
---
On Feb. 3, 2014, 11:20 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17680
/SlotSizeCounterTest.java
f2473929f501559c4f5e366d96c05fa22597bfe6
Diff: https://reviews.apache.org/r/17680/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17715/#review33623
---
Ship it!
Ship It!
- Bill Farner
On Feb. 4, 2014, 7 p.m., Suman
/RescheduleCalculatorImplTest.java
https://reviews.apache.org/r/17717/#comment63166
Thanks for catching the incorrect org. Would it make sense to revert to
2014, though, since that's the inception date of the file? Ditto for
TaskAssignerImplTest.java.
- Bill Farner
On Feb. 4, 2014, 7:27 p.m., Jake Farrell
, consider dropping.
- Bill Farner
On Feb. 12, 2014, 11:26 p.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18036
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18149/#review34555
---
Ship it!
This is great, thanks!!
- Bill Farner
On Feb. 14, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18141/#review34542
---
On Feb. 14, 2014, 8:09 p.m., Bill Farner wrote
/scheduler/filter/SchedulingFilterImplTest.java
56de3aae4e08138a66a587e2a43d64a2310079f1
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
f0fdd571f273be8dad1f9410b0e70e3a11e8133b
Diff: https://reviews.apache.org/r/18157/diff/
Testing
---
./gradlew build
Thanks,
Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18244/#review34790
---
Ship it!
Ship It!
- Bill Farner
On Feb. 18, 2014, 10:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18247/#review34813
---
Ship it!
Ship It!
- Bill Farner
On Feb. 18, 2014, 10:50 p.m
, 2014, 12:55 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18241/
---
(Updated Feb. 19, 2014, 12:55 a.m
f0fdd571f273be8dad1f9410b0e70e3a11e8133b
Diff: https://reviews.apache.org/r/18157/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
Diff: https://reviews.apache.org/r/18141/diff/
Testing
---
$ ./gradlew build
Thanks,
Bill Farner
23ea6e137f8d386bf9cea7776dc7bf6849982345
Diff: https://reviews.apache.org/r/18294/diff/
Testing
---
./gradlew clean build
Thanks,
Bill Farner
://reviews.apache.org/r/18294/#review34980
---
On Feb. 20, 2014, 12:24 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/#review34965
---
On Feb. 20, 2014, 1:43 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18297
://reviews.apache.org/r/18345/#comment65599
I learned something new today! I've always used dirname $0, but i landed
at a StackOverflow question [1] that explains why that has gotchas.
[1]
http://stackoverflow.com/questions/59895/can-a-bash-script-tell-what-directory-its-stored-in
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18316/#review35198
---
Ship it!
Ship It!
- Bill Farner
On Feb. 20, 2014, 7:50 p.m
On Feb. 25, 2014, 7:46 p.m., Bill Farner wrote:
build-support/virtualenv, line 19
https://reviews.apache.org/r/18345/diff/3/?file=503119#file503119line19
I may be missing something, but isn't the pushd/popd obviated by the cd?
Kevin Sweeney wrote:
The cd only happens
wire compatibility.
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
https://reviews.apache.org/r/17562/#comment65972
Mind putting some dummy data in ServerInfo fields?
- Bill Farner
On Feb. 25, 2014, 1:22 a.m., Suman Karumuri wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review34866
---
On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review35454
---
On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote
On Feb. 25, 2014, 8:35 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java,
line 113
https://reviews.apache.org/r/18240/diff/1/?file=497125#file497125line113
reads better statically imported (here and elsewhere).
Bill Farner
On Feb. 25, 2014, 2:07 p.m., Mark Chu-Carroll wrote:
Ship It!
Mark, as the last shipper with commit access — can you commit this?
- Bill
---
This is an automatically generated e-mail. To reply, visit:
/
Testing
---
./gradlew build
Thanks,
Bill Farner
d6624f470eadaf0be658db1d87d5863ea6701d94
Diff: https://reviews.apache.org/r/18487/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18490/#review35503
---
Ship it!
Ship It!
- Bill Farner
On Feb. 26, 2014, 12:19 a.m
Description
---
Remove rogue apostrophe.
Diffs
-
docs/configurationreference.md 6fb6b201b1748a34f520bd8ebf2365cc6d33328d
Diff: https://reviews.apache.org/r/18523/diff/
Testing
---
Thanks,
Bill Farner
-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md
Thanks,
Bill Farner
deal with
this separately.
src/test/python/apache/aurora/client/commands/test_diff.py
https://reviews.apache.org/r/18546/#comment66430
Ditto.
- Bill Farner
On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review35719
---
Ship it!
Ship It!
- Bill Farner
On Feb. 26, 2014, 10:06 p.m
On Feb. 27, 2014, 11:19 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java,
line 76
https://reviews.apache.org/r/18526/diff/2/?file=506086#file506086line76
I know why you're doing this here, but mind keeping it out for now?
Ignore
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35737
---
Ship it!
Ship It!
- Bill Farner
On Feb. 27, 2014, 6:53 p.m
/Quotas.java
https://reviews.apache.org/r/18546/#comment66488
s/quota/resource aggregate/
- Bill Farner
On Feb. 28, 2014, 1:32 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
?
- Bill Farner
On Feb. 28, 2014, 2:31 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/
---
(Updated Feb
On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19
https://reviews.apache.org/r/17303/diff/1/?file=447781#file447781line19
Do you think this class scales to multiple consumers? i.e. there's a
bunch of hard-coded
/r/17303/#comment66600
These variable names suggest you're testing different things. Perhaps this
should be split into different cases, with less wordy variable names?
- Bill Farner
On Feb. 26, 2014, 4:18 a.m., Suman Karumuri wrote
in the map. More ideal is to iterate over the
keys. I don't know of a 'multi-get' for Map/Multmap, but i'd support use of
that if it does.
Also, not new, but it's a good idea to wrap this with
Iterables.unmodifiableIterable().
- Bill Farner
On Feb. 28, 2014, 1:18 a.m., Maxim
/
---
(Updated Feb. 28, 2014, 10:53 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-232
https://issues.apache.org/jira/browse/AURORA-232
Repository: aurora
Description
---
The slaveHosts set
/SchedulerThriftInterfaceTest.java
https://reviews.apache.org/r/17347/#comment6
Mind making this a different value, to prove that the implementation treats
them differently?
- Bill Farner
On Feb. 28, 2014, 11:32 p.m., Suman Karumuri wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18654/#review35873
---
Incomplete feature?
- Bill Farner
On March 1, 2014, 12:14 a.m
On March 1, 2014, 12:16 a.m., Bill Farner wrote:
Incomplete feature?
Maxim Khutornenko wrote:
This is needed to unlock two additional CRs I am about to post. One that
follows up on supporting jobKeys in scheduler and the other one that uses it
on the client.
One that follows up
of slaveHosts - one field hides
the other. Please fix.
- Bill Farner
On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18484/#review35983
---
Ping? Suman — waiting on a review from you.
- Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18562/#review35984
---
Ping?
- Bill Farner
On Feb. 27, 2014, 4:06 a.m., Bill Farner
these methods go.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18487/#review35547
---
On Feb. 26, 2014, 12:12 a.m., Bill Farner wrote
/r/18487/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
d6624f470eadaf0be658db1d87d5863ea6701d94
Diff: https://reviews.apache.org/r/18704/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
all of these assertEquals looking more like:
assertEquals(expected, actual);
Where 'actual' is the top-level response rather than the result of peeking
into fields. This gives confidence that the response code and message are also
set appropriately.
- Bill Farner
On March 1
/
---
(Updated March 1, 2014, 12:54 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-235
https://issues.apache.org/jira/browse/AURORA-235
Repository: aurora
Description
---
Added an optional
/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java
359f5d44e030a53cedd612a350b161b392d929c4
Diff: https://reviews.apache.org/r/18714/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review36073
---
Ship it!
Ship It!
- Bill Farner
On March 4, 2014, 1:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18487/#review36247
---
Ping? Kevin — waiting on a review from you.
- Bill Farner
.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18484/#review36397
---
On Feb. 25, 2014, 10:25 p.m., Bill Farner wrote
71d6a9ed943306386dfe88074ee07f69f6ca15d1
Diff: https://reviews.apache.org/r/18484/diff/
Testing
---
./gradlew build
Thanks,
Bill Farner
up in the
commit log, a commit message of Investigate adding is less direct than Add.
build.gradle
https://reviews.apache.org/r/18926/#comment67591
Reason for the extra line break isn't obvious to me - drop?
- Bill Farner
On March 7, 2014, 10:47 p.m., Jake Farrell wrote
1 - 100 of 1375 matches
Mail list logo
