---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/
---
(Updated Sept. 17, 2014, 1:06 p.m.)
Review request for Aurora.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/
---
(Updated Sept. 17, 2014, 2:44 p.m.)
Review request for Aurora.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review53554
---
Ship it!
Mark informed me that he intends for this command to not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review53347
---
src/main/python/apache/aurora/client/cli/standalone_client.py
On Sept. 15, 2014, 12:04 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/standalone_client.py, line 121
https://reviews.apache.org/r/25255/diff/2/?file=685554#file685554line121
I am still not sure why we are going with the top level noun for job
updates.
The choices are:
(1) Action parameter: aurora job update
--action=start/pause/resume/abort.
Pros: it's part of the job noun and the familiar update verb.
Cons:
- the action parameter is ugly,
- we lose automatic parameter checking, since the different actions take
different parameters.
- it's
I guess there is also the option you originally proposed: aurora job
update --start|--pause|--resume|--abort.
If you don't like the option syntax, would it be too much work to
support double verb (or rather double noun) syntax, like aurora
job update start?
On Mon, Sep 15, 2014 at 2:07 PM, Mark
As I said - the version with the sub-actions fouls up parameter checking.
(That's the action parameter option. It doesn't matter whether it's
--action=start or --start; in fact, the --action at least lets the
parameter parser do a little bit of checking.)
It's possible to add another layer of
On Sept. 3, 2014, 3:58 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 667
https://reviews.apache.org/r/25255/diff/1/?file=673959#file673959line667
How about a BROWSER_OPTION for all update commands
(start/pause/resume/abort)?
It will,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review53030
---
I was about to ping about this, when I discovered that my replies
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review52220
---
src/main/python/apache/aurora/client/cli/jobs.py
On Sept. 2, 2014, 1:32 p.m., Joshua Cohen wrote:
Is the command name supdate up for debate? I'm not in love with it ;).
It's a temporary thing. (Came up with it during a discussion with Bill.)
If we start adding this stuff to the existing update command, then existing
users are going to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review52043
---
Is the command name supdate up for debate? I'm not in love with it
13 matches
Mail list logo
