Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 --- Ship it! lgtm! src/main/java/org/apache/aurora/scheduler/http/api

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75959 --- Ship it! Master (48dc4c7) is green with this patch. ./build-suppo

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75954 --- Ship it! Ship It! - Bill Farner On March 10, 2015, 7:45 p.m., Ke

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 12:45 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > lines 59-62 > > > > > > Maybe move this to the ticket and kill the commen

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75839 --- Ship it! Master (1b1931c) is green with this patch. ./build-suppo

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 9, 2015, 6:18 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75827 --- Master (e55113d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 9, 2015, 5:37 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

> On March 9, 2015, 11:36 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 50 > > > > > > Would it be possible to create a Ini parser for Args i

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

> On March 9, 2015, 1:47 p.m., Bill Farner wrote: > > build.gradle, line 260 > > > > > > Holy cow, they're on guava 9!? Hopefully this doesn't burn us, but a > > quick grep through their code suggests they only have

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

> On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: > > Should we add tests for the full scheduler API as well as the admin > > interface? > > > > Also, worth adding a unit test for the interceptor? Added ShiroThriftInterceptorTest. Not sure what you mean by test the full scheduler API - I ch

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75638 --- Overall LGTM mod these and previous comments. build.gradle

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

> On March 9, 2015, 6:36 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 50 > > > > > > Would it be possible to create a Ini parser for Args in

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75736 --- src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecu

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75723 --- Should we add tests for the full scheduler API as well as the admin

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75596 --- Ship it! Master (5aa130e) is green with this patch. ./build-suppo

Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and A