[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: (7 comments)

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9349 ) Change subject: Bump Kudu Java version to 1.7.0 .. Bump Kudu Java version to 1.7.0 Change-Id:

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9349 ) Change subject: Bump Kudu Java version to 1.7.0 .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#4). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. IMPALA-6508: add KRPC test flag This change adds a flag

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#4). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 27: (1 comment)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 5: (I'm assuming that we'll validate

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-16 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#28). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-6526: Fix spilling test for running on local FS

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9354 ) Change subject: IMPALA-6526: Fix spilling test for running on local FS .. IMPALA-6526: Fix spilling test for running on

[Impala-ASF-CR] IMPALA-6526: Fix spilling test for running on local FS

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9354 ) Change subject: IMPALA-6526: Fix spilling test for running on local FS .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#6). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 6: Yes, we will do appropriate tuning

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 6: Code-Review+2 Carry Tim's +2 -- To

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6499: [docs] Fixed formatting errors in split part function

2018-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9275 ) Change subject: IMPALA-6499: [docs] Fixed formatting errors in split_part function .. Patch Set 3: (4 comments)

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-02-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 4: Cherry-picks added -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-16 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#27). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 26: (4 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 6: (4 comments) The overall

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-02-16 Thread Alex Rodoni (Code Review)
Hello Michael Brown, John Russell, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9219 to look at the new patch set (#3). Change subject: [DOCS] Removed the obsolete Llama options files

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-02-16 Thread Alex Rodoni (Code Review)
Hello Michael Brown, John Russell, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9219 to look at the new patch set (#4). Change subject: [DOCS] Removed the obsolete Llama options files

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 25: (35 comments) Thanks for the comments.

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-16 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#26). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-02-16 Thread Alex Rodoni (Code Review)
Hello John Russell, Philip Zeyliger, Sailesh Mukil, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9286 to look at the new patch set (#6). Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-02-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 5: Verified-1 Build

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9306 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 3: (4 comments) > For example, you could add tests for

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-16 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#3). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables ..

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9306 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-16 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#14). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 5: Seems like it was hit by

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: I took the liberty to make the GetIntConstant

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-16 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#8). Change subject: IMPALA-5801: Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 9: > Patch Set 9: Code-Review+1 > > Fyi, its

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell The patch uses a

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc

2018-02-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9347 ) Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. Patch Set 1: Now it is public. -- To view, visit

[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc

2018-02-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9347 Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. [DOCS] Typos fixed in Impala Analytic Functions doc Change-Id:

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: Code-Review+1 lgtm. would anyone with more experience

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 6: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. IMPALA-6258: Uninitialized

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 4: Code-Review+1 (5 comments) thanks for the refactor and

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#8). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ..

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 9: Code-Review+1 Fyi, its nice

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 5: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 7: Thanks for the review, I address the comments in PS8.

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8958 to look at the new patch set (#5). Change subject: IMPALA-5152: Introduce metadata loading phase

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9306 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 3: FYI. I am adding some primary key tests and working

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-16 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#4). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables

[Impala-ASF-CR] IMPALA-6526: Fix spilling test for running on local FS

2018-02-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9354 Change subject: IMPALA-6526: Fix spilling test for running on local FS .. IMPALA-6526: Fix spilling test for running on local FS One

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6526: Fix spilling test for running on local FS

2018-02-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9354 ) Change subject: IMPALA-6526: Fix spilling test for running on local FS .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6526: Fix spilling test for running on local FS

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9354 ) Change subject: IMPALA-6526: Fix spilling test for running on local FS .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#10). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#11). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 10: Please see the tests in PS10. -- To view, visit

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#5). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#5). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] [docs] Removed the obsolete Llama options files

2018-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [docs] Removed the obsolete Llama options files .. Patch Set 2: (1 comment) Now the question is, how do we make sure

[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9347 ) Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. Patch Set 1: Build started:

[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc

2018-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9347 ) Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9341 ) Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. Patch Set 3: Build started:

[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options

2018-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9341 ) Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. Patch Set 3: I'm not familiar with whatever error condition is

[Impala-ASF-CR] [docs] Removed the obsolete Llama options files

2018-02-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [docs] Removed the obsolete Llama options files .. Patch Set 2: > (1 comment) > > Now the question is, how do we

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#6). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] IMPALA-6515: [docs] HAproxy with sticky session requires the check option

2018-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [docs] HAproxy with sticky session requires the check option .. Patch Set 3: Different people from

[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9347 ) Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. [DOCS] Typos fixed in Impala Analytic Functions

[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9347 ) Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9341 ) Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9341 ) Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. [DOCS] Fix in REPLICA_PREFERENCE numeric options

[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters

2018-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters .. Patch Set 5: (3 comments)