[Impala-ASF-CR] IMPALA-6573: Create consistent response on column access failures

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9509 ) Change subject: IMPALA-6573: Create consistent response on column access failures .. Patch Set 2: (4 comments)

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 4: Build started:

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6629: Clean up catalog update logging

2018-03-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9566 Change subject: IMPALA-6629: Clean up catalog update logging .. IMPALA-6629: Clean up catalog update logging IMPALA-5990 introduced some

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

2018-03-09 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 .. Patch Set 11:

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 4: Maybe we could

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (6 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#3). Change subject: IMPALA-6576: Add metrics for data stream service memory usage

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 10: > Patch Set 10: > > (2 comments) I decided to fix the

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: Verified-1 Both builds have failed. Can you

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6629: Clean up catalog update logging

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9566 ) Change subject: IMPALA-6629: Clean up catalog update logging .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6629: Clean up catalog update logging

2018-03-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9566 ) Change subject: IMPALA-6629: Clean up catalog update logging .. IMPALA-6629: Clean up catalog update logging IMPALA-5990 introduced some

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-09 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9395 to look at the new patch set (#2). Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

[Impala-ASF-CR] IMPALA-6629: Clean up catalog update logging

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9566 ) Change subject: IMPALA-6629: Clean up catalog update logging .. Patch Set 1: Code-Review+2 (1 comment) I tried this patch and the new

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 2: (1 comment) > We should also document the

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: Tim, Please take a look at

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Fix test dimensions in test_errorlog.py Bug: The test

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. IMPALA-6627: [DOCS] Hive

[Impala-ASF-CR] IMPALA-5717: Support for ORC data files

2018-03-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for ORC data files .. Patch Set 3: (18 comments)

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. IMPALA-6394: Restart HDFS when blocks are

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 7: (16 comments)

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 ) Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Patch Set 3: Verified+1 -- To

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: (3 comments) Nice work! Thanks for your patience with

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#5). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9534 ) Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9534 ) Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option .. IMPALA-6240: [DOCS] Document

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9570 Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. IMPALA-6621: Improve set lookup performance

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 ) Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6629: Clean up catalog update logging

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9566 ) Change subject: IMPALA-6629: Clean up catalog update logging .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 4: Verified+1 -- To view, visit

[native-toolchain-CR] Bump LLVM to 5.0.1

2018-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8932 ) Change subject: Bump LLVM to 5.0.1 .. Patch Set 2: Code-Review+2 This seems fine to merge at the same time as we switch it over in

[Impala-ASF-CR] IMPALA-6629: Clean up catalog update logging

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9566 ) Change subject: IMPALA-6629: Clean up catalog update logging .. IMPALA-6629: Clean up catalog update logging

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Patch Set 2: -Code-Review New patch? -- To

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

2018-03-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 ) Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution .. Patch Set 1: > Alex, did

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 4: I agree with Bharath that we

[Impala-ASF-CR] IMPALA-6240: [DOCS] Document PARQUET ARRAY RESOLUTION query option

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9534 ) Change subject: IMPALA-6240: [DOCS] Document PARQUET_ARRAY_RESOLUTION query option .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Alex Rodoni (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9563 to look at the new patch set (#2). Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Alex Rodoni (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9563 to look at the new patch set (#3). Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

[Impala-ASF-CR] IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9563 ) Change subject: IMPALA-6627: [DOCS] Hive incompatibility with serialization.null.format .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

2018-03-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 .. Patch Set 11: (9 comments)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-09 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#4). Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717:

[Impala-ASF-CR] IMPALA-6605: Exception hidden on complex types

2018-03-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/9514 ) Change subject: IMPALA-6605: Exception hidden on complex types .. IMPALA-6605: Exception hidden on complex types This patch fixes the

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: Code-Review+1 OK, thank you so much! -- To view, visit

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 3: Fixed and ran the FE tests locally. I also

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-09 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Dimitris Tsirogiannis, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9484 to look at the new patch set (#3). Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6605: Exception hidden on complex types

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9514 ) Change subject: IMPALA-6605: Exception hidden on complex types .. Patch Set 12: Fredy and I discussed this change and we concluded that we

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: (2 comments) There is

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#13). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 13: PS13 was only a

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 2: We should also document the following new

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 3: Code-Review+2 -- To view, visit