[Impala-ASF-CR] IMPALA-5384, part 1: introduce DmlExecState

2018-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9793 ) Change subject: IMPALA-5384, part 1: introduce DmlExecState .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 1: introduce DmlExecState

2018-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9793 ) Change subject: IMPALA-5384, part 1: introduce DmlExecState .. IMPALA-5384, part 1: introduce DmlExecState This change

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#19). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-29 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9799 to look at the new patch set (#4). Change subject: IMPALA-4123 (prep): Parquet column reader cleanup

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: Is there still more coming on

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 19: (2 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-29 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: Yes. Have one last

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: Here's the diff highlighting the issue: diff --git

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9857 Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work Initially I didn't

[Impala-ASF-CR] IMPALA-4835: switch I/O buffers to buffer pool

2018-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9679 ) Change subject: IMPALA-4835: switch I/O buffers to buffer pool .. IMPALA-4835: switch I/O buffers to buffer pool This is the following

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. IMPALA-6587: free buffers before ScanRange::Cancel()

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-4835: switch I/O buffers to buffer pool

2018-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9679 ) Change subject: IMPALA-4835: switch I/O buffers to buffer pool .. Patch Set 10: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 15: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-6739: Exception in ALTER TABLE SET statements

2018-03-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: Exception in ALTER TABLE SET statements .. IMPALA-6739: Exception in ALTER TABLE SET statements The patch

[Impala-ASF-CR] IMPALA-1071: Distributable python package for impala-shell

2018-03-29 Thread David Knupp (Code Review)
Hello Greg Rahn, Tianyi Wang, Michael Brown, Gabor Kaszab, Fredy Wijaya, Jim Apple, Nithya Janarthanan, Philip Zeyliger, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9771 to look at the new patch set (#4). Change subject: IMPALA-1071:

[Impala-ASF-CR] IMPALA-1071: Distributable python package for impala-shell

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9771 ) Change subject: IMPALA-1071: Distributable python package for impala-shell .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#9). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9860 Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. IMPALA-6769: Avoid pulling incoherent Hadoop

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6739: Exception in ALTER TABLE SET statements

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: Exception in ALTER TABLE SET statements .. Patch Set 10: (2 comments) Since these particular statements

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-03-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-6724: Allow creating/dropping functions with the same name as built-ins

2018-03-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins .. IMPALA-6724: Allow creating/dropping

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6649: Add fine-grained ALTER privilege

2018-03-29 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-grained ALTER privilege .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. IMPALA-6719: Reset metadata database name case sensitivity

[Impala-ASF-CR] IMPALA-6724: Allow creating/dropping functions with the same name as built-ins

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins .. Patch Set 11: (8 comments)

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6724: Allow creating/dropping functions with the same name as built-ins

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins .. Patch Set 9: (6 comments)

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9857 to look at the new patch set (#2). Change subject: IMPALA-6389: Make '\0' delimited text files work ..

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9859 Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. IMPALA-6769: Avoid pulling incoherent Hadoop

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6769: Avoid pulling incoherent Hadoop dependencies.

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9860 ) Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. .. Patch Set 1: Jenkins is shutting down at the moment,

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Patch Set 2: Code-Review+2 Carry; simple rebase. -- To view,

[Impala-ASF-CR] IMPALA-6760: Fix for py2.7-ism in run-tests.py.

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9843 ) Change subject: IMPALA-6760: Fix for py2.7-ism in run-tests.py. .. IMPALA-6760: Fix for py2.7-ism in run-tests.py. A

[Impala-ASF-CR] IMPALA-6760: Fix for py2.7-ism in run-tests.py.

2018-03-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9843 ) Change subject: IMPALA-6760: Fix for py2.7-ism in run-tests.py. .. Patch Set 2: Verified+1 Code-Review+2 Carrying reviews and +1. It

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: Are we going to move forward with this patch?

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: I got blocked behind some lib-cache stuff,