[Impala-ASF-CR] IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec()

2018-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10348 ) Change subject: IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec() .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 3: Code-Review+2 Updated commit message.

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-08 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 3: (10 comments)

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10346 ) Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. [DOCS] Removed the

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-05-08 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#19). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: (2 comments)

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10346 ) Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. Patch Set 2: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. IMPALA-6227: reduce window of metric

[Impala-ASF-CR] IMPALA-6980: [DOCS] You can add or change column comment in ALTER TABLE

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10317 ) Change subject: IMPALA-6980: [DOCS] You can add or change column comment in ALTER TABLE .. Patch Set 1: Adam and Fredy, Could you

[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required .. Patch Set 1: Balazs, Could you please review this?

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10346 ) Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 15: (25 comments) Still need to do a pass over the tests.

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10347 Change subject: Fix diagnostics path to not include the parent dir structure .. Fix diagnostics path to not include the parent

[Impala-ASF-CR] IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec()

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10348 ) Change subject: IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec() .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Code-Review+2 Assuming that one change

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: > Assuming that one change is done, this

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on 2.x

2018-05-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on 2.x .. Patch Set 2: Code-Review+2 (1 comment) Note nit about the commit

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Alex Rodoni (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10316 to look at the new patch set (#4). Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-08 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10291 to look at the new patch set (#3). Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10346 ) Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-05-08 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 18: (1 comment)

[Impala-ASF-CR] [DOCS] Fixed a typo in CREATE TABLE syntax

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10350 ) Change subject: [DOCS] Fixed a typo in CREATE TABLE syntax .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Fixed a typo in CREATE TABLE syntax

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10350 ) Change subject: [DOCS] Fixed a typo in CREATE TABLE syntax .. Patch Set 1: Build started:

[Impala-ASF-CR] [DOCS] Fixed a typo in CREATE TABLE syntax

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10350 Change subject: [DOCS] Fixed a typo in CREATE TABLE syntax .. [DOCS] Fixed a typo in CREATE TABLE syntax Change-Id:

[Impala-ASF-CR] IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec()

2018-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10348 Change subject: IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec() .. IMPALA-6993: Don't log stack trace in

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 14: (33 comments) I think this

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10346 ) Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. Patch Set 2: Code-Review+2 Thanks! -- To

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 ) Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Code-Review-2 -- To view, visit

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: This needs another upload before any

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. IMPALA-6908: IsConnResetTException()

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10349 Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. IMPALA-6995: avoid DCHECK in TimestampParse::Parse() The bug

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10313 to look at the new patch set (#2). Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Dan Hecht (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10158 to look at the new patch set (#14). Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-08 Thread Attila Jeges (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9986 to look at the new patch set (#4). Change subject: IMPALA-3307: Add support for IANA time-zone db

[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: Hi Alex, Can you or someone in your

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10346 ) Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Alex Rodoni (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10346 to look at the new patch set (#2). Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Alex Rodoni (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10316 to look at the new patch set (#3). Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 14: I think this is ready for review

[Impala-ASF-CR] [DOCS] Removed the references to YARN as Impala does not support YARN

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10346 Change subject: [DOCS] Removed the references to YARN as Impala does not support YARN .. [DOCS] Removed the references to YARN as Impala

[Impala-ASF-CR] IMPALA-6974: Use CMAKE POSITION INDEPENDENT CODE in backend

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10267 ) Change subject: IMPALA-6974: Use CMAKE_POSITION_INDEPENDENT_CODE in backend .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on 2.x

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on 2.x .. IMPALA-6972: Disable parallel dataload on 2.x There is a Hive bug in

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Removed Code-Review-2 by Joe McDonnell -- To view, visit

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-08 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10306 to look at the new patch set (#3). Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: LGTM. Will there be another change addressing similar

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: > Will there be another change addressing similar

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell

2018-05-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10354 ) Change subject: IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell .. Patch Set 1:

[Impala-ASF-CR] [DOCS] Fixed a typo in CREATE TABLE syntax

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10350 ) Change subject: [DOCS] Fixed a typo in CREATE TABLE syntax .. [DOCS] Fixed a typo in CREATE TABLE syntax Change-Id:

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-08 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#15). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. IMPALA-783: [DOCS] Document SHOW CREATE VIEW

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Dan Hecht (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10158 to look at the new patch set (#15). Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. IMPALA-6802 (part 2): Clean up authorization

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 3: > Hi Dimitris, Philip, > Would you

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 14: (33 comments)

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6635: Enable disk spill encryption by default

2018-05-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10345 ) Change subject: IMPALA-6635: Enable disk spill encryption by default .. Patch Set 3: Is this change a part of the fix for 6635? I was

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10313 to look at the new patch set (#3). Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW

[Impala-ASF-CR] IMPALA-783: [DOCS] Document SHOW CREATE VIEW

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10313 ) Change subject: IMPALA-783: [DOCS] Document SHOW CREATE VIEW .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. IMPALA-6802 (part 2): Clean up authorization tests The second part

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 ) Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-6980: [DOCS] You can add or change column comment in ALTER TABLE

2018-05-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10317 ) Change subject: IMPALA-6980: [DOCS] You can add or change column comment in ALTER TABLE .. Patch Set 1: Code-Review+1 -- To view,

[Impala-ASF-CR] [DOCS] Fixed a typo in CREATE TABLE syntax

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10350 ) Change subject: [DOCS] Fixed a typo in CREATE TABLE syntax .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10351 Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. IMPALA-6781: expand ORDER BY in some TPCH queries Fix determinism

[Impala-ASF-CR] IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec()

2018-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10348 ) Change subject: IMPALA-6993: Don't log stack trace in Coordinator::BackendState::Exec() .. IMPALA-6993: Don't log

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 ) Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests .. Patch Set 3: (6 comments) I'm pretty happy with this test.

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 3: Hi Dimitris, Philip, Would you trigger

[Impala-ASF-CR] IMPALA-6221: [DOCS] Correct syntax for Kudu Partition clause

2018-05-08 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10353 Change subject: IMPALA-6221: [DOCS] Correct syntax for Kudu Partition clause .. IMPALA-6221: [DOCS] Correct syntax for Kudu Partition

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 ) Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-08 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Brown (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10351 to look at the new patch set (#2). Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. IMPALA-6781:

  1   2   >