[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6663: Expose current DDL metrics on WebUI

2020-02-13 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 ) Change subject: IMPALA-6663: Expose current DDL metrics on WebUI .. Patch Set 13: Code-Review+1 (2 comments) Left a small nit, but

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4224: execute separate join builds fragments

2020-02-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14859 ) Change subject: IMPALA-4224: execute separate join builds fragments .. Patch Set 40: Code-Review+1 (5 comments) Went through the

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: > Patch Set 5: Verified-1 > > Build

[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre

2020-02-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 1: Code-Review+1 (9 comments)

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 9: (1 comment)

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. WIP: Asynchronous code generation This commit introduces optional asynchronous

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 2:

[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

2020-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch

[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI ..

[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI ..

[Impala-ASF-CR] IMPALA-5308: Resolve confusing Kudu SHOW TABLE STATS output

2020-02-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15199 ) Change subject: IMPALA-5308: Resolve confusing Kudu SHOW TABLE STATS output .. Patch Set 2: IMO it would be better to format the

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre

2020-02-13 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3343: Make impala-shell compatible with python 3.

2020-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 ) Change subject: IMPALA-3343: Make impala-shell compatible with python 3. .. Patch Set 12: (4 comments) I did a pass over the change

[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre

2020-02-13 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9383: Fix hang in hs2-http server with large, chunks request

2020-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15218 Change subject: IMPALA-9383: Fix hang in hs2-http server with large, chunks request .. IMPALA-9383: Fix hang in hs2-http

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 3:

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 3:

[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI ..

[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: Build failed:

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort

2020-02-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15217 Change subject: IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort .. IMPALA-8909: Fix incorrectly omitting

[Impala-ASF-CR] IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15217 ) Change subject: IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15217 ) Change subject: IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8712: Make ExecQueryFInstances async

2020-02-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15154 ) Change subject: IMPALA-8712: Make ExecQueryFInstances async .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-13 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: The build errors are due

[Impala-ASF-CR] IMPALA-8587: show grant does not produce correct privileges

2020-02-13 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/14356 ) Change subject: IMPALA-8587: show grant does not produce correct privileges .. Abandoned IMPALA-8587 has been merged upstream so we abandon this

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-02-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-02-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 7: Instead of creating a

[Impala-ASF-CR] IMPALA-9383: Fix hang in hs2-http server with large, chunks request

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15218 ) Change subject: IMPALA-9383: Fix hang in hs2-http server with large, chunks request .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-9383: Fix hang in hs2-http server with large, chunks request

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15218 ) Change subject: IMPALA-9383: Fix hang in hs2-http server with large, chunks request .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15217 ) Change subject: IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort .. Patch Set 1: Verified-1 Build

[Impala-ASF-CR] IMPALA-7031: Improve error message for invalid query handle

2020-02-13 Thread Alice Fan (Code Review)
Alice Fan has abandoned this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Improve error message for invalid query handle .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12926 To

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: > Patch Set 5: > > Build failed:

[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive

2020-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 13: Rebased this, nothing has changed. I'm

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 3:

[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI

2020-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by automatically enable live progress in the interactive mode

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode ..

[Impala-ASF-CR] IMPALA-8960 (prep 1): Copy Kudu cache code to be/src/util/cache

2020-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15169 ) Change subject: IMPALA-8960 (prep 1): Copy Kudu cache code to be/src/util/cache .. Patch Set 6: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by automatically enable live progress in the interactive mode

2020-02-13 Thread Alice Fan (Code Review)
Alice Fan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15219 Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode .. IMPALA-9384:

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre

2020-02-13 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre

[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9383: Fix hang in hs2-http server with large, chunks request

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15218 ) Change subject: IMPALA-9383: Fix hang in hs2-http server with large, chunks request .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. IMPALA-9304: Support starting Hive

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort

2020-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15217 ) Change subject: IMPALA-8909: Fix incorrectly omitting implicit cast in pre-insert sort .. Patch Set 1: Code-Review+2 I think this is

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-02-13 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9304: Support starting Hive with Ranger in minicluster

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15189 ) Change subject: IMPALA-9304: Support starting Hive with Ranger in minicluster .. Patch Set 5: Code-Review+2 -- To view,