[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > @Matthew: Would you be needing the ppc64le infra for temporary > usage to test the changes until

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > @Matthew: Would you be needing the ppc64le infra for temporary > > usage to test the changes until

[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports

2017-04-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6515 To

[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports

2017-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6515 To

[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports

2017-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports In

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 6: > Re: gflags - agree we need to look hard at a solution. Do you think > we could do

[Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports

2017-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 16: (1 comment)

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: > Do not use the term 'compatible' or imply it. > >

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe,

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#17). Change subject: IMPALA-5003: Constant propagation in scan nodes .. IMPALA-5003: Constant propagation in scan nodes When conjuncts are pushed into table refs from inline views,

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#18). Change subject: IMPALA-5003: Constant propagation in scan nodes .. IMPALA-5003: Constant propagation in scan nodes When conjuncts are pushed into table refs from inline views,

[Impala-ASF-CR] IMPALA-4817: Populate Parquet Statistics for Strings

2017-04-06 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4817: Populate Parquet Statistics for Strings .. IMPALA-4817: Populate Parquet Statistics for Strings This change adds functionality to populate the new

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 20: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj

2017-04-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5173: crash with hash join feeding directly into nlj .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5173: crash with hash join feeding directly into nlj .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5173: crash with hash join feeding directly into nlj .. IMPALA-5173: crash with hash join feeding directly into nlj The background for this bug is that we

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-06 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6414 to look at the new patch set (#21). Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool ..

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#19). Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. IMPALA-5003: Constant propagation in scan conjuncts Implements constant proopagation within conjuncts and

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. Patch Set 3: (13 comments)

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5124: add tests for scratch read errors .. IMPALA-5124: add tests for scratch read errors Adds tests for read errors from permissions (i.e. open() fails),

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 21: Code-Review+2 Rebase and update free-lists-benchmark to use the changed FreeList

[Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj

2017-04-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5173: crash with hash join feeding directly into nlj .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 18: (4 comments) Basically done, final nits http://gerrit.cloudera.org:8080/#/c/6389/18//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs Previously, exprs used in sorts

[Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj

2017-04-06 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6568 to look at the new patch set (#3). Change subject: IMPALA-5173: crash with hash join feeding directly into nlj ..

[Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5173: crash with hash join feeding directly into nlj .. Patch Set 3: Code-Review+2 (1 comment) Carry +2

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5124: add tests for scratch read errors .. IMPALA-5124: add tests for scratch read errors Adds tests for read errors from permissions (i.e. open() fails),

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: @Matthew: Would you be needing the ppc64le infra for temporary usage to test the changes

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: Matthew, could you let me know the system configuration required on the ppc64le infra ? --

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Anonymous Coward (Code Review)
Anonymous Coward #290 has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: The issue we (HivePMC) are trying dealing with is there are several entities

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Impala and Hive have slightly different SQL they accept. .. Impala and Hive have slightly different SQL they accept.

[Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs .. Patch Set 2: (1 comment)

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: OK, I think the wording in PS1 is as close as we are going to get. MJ, are you OK with

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs Previously, exprs used in sorts

[Impala-ASF-CR] IMPALA-4858: add more info to MemLimitExceeded errors

2017-04-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4858: add more info to MemLimitExceeded errors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6537 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 5: (11 comments)

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Anonymous Coward (Code Review)
Anonymous Coward #290 has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: Do not use the term 'compatible' or imply it.

[Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs

2017-04-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. Patch Set 4: (17 comments)

[Impala-ASF-CR] IMPALA-5182: Explicitly close connection to impalad on error from shell

2017-04-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6587 Change subject: IMPALA-5182: Explicitly close connection to impalad on error from shell .. IMPALA-5182: Explicitly close connection to

[Impala-ASF-CR] IMPALA-5182: Explicitly close connection to impalad on error from shell

2017-04-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5182: Explicitly close connection to impalad on error from shell .. Patch Set 1: (1 comment) Were you able to repro the issue? Do you think it's

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 16: (15 comments)

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#20). Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. IMPALA-3203: Part 2: per-core free lists in buffer pool Add per-core lists of clean pages and free

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 5: (11 comments)

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. IMPALA-4114: Port BufferedBlockMgr tests to buffer pool BufferedBlockMgr had a number of interesting

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-04-06 Thread Zach Amsden (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6335 to look at the new patch set (#3). Change subject: IMPALA-5127: Add history_max option .. IMPALA-5127: Add

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5127: Add history_max option .. Patch Set 2: (1 comment) I made this a bit more friendly and tolerant as well.

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/6579 Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. IMPALA-5181: Extract PYPI metadata from a webpage There were

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-04-06 Thread Zach Amsden (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6335 to look at the new patch set (#4). Change subject: IMPALA-5127: Add history_max option .. IMPALA-5127: Add