[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables This

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Yes, looking at it now. -- To view, visit

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has abandoned this change. Change subject: CDH-48291: Fix flaky test TestRequestPoolService .. Abandoned MJ posted a fix for this. -- To view, visit http://gerrit.cloudera.org:8080/5507 To unsubscribe,

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 13: John, when do you plan to post a new patch that addresses the last comments? I think after

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5909 Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. IMPALA-4884: Add JVM heap and non-heap usage

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5909/1/www/memz.tmpl

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+1 Keep Alex's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5909 to look at the new patch set (#2). Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI ..

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 11: (1 comment) John, sending a new patch without indicating which comments have been addressed

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 22: Code-Review+1 (2 comments) Catalog changes look

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: (1 comment)

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 13: Code-Review+1 (5 comments) I'll let MJ and/or Todd make a final pass.

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5815 Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables .. IMPALA-2518: DROP DATABASE

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: Thank you for looking into this. It would be nice to

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5729 To

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5743

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5649/6/docs/shared/impala_common.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (15 comments) Another round of comments. I've seen that not all previous comments have been

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 7: (25 comments) http://gerrit.cloudera.org:8080/#/c/5649/7/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (10 comments) Thanks for the suggestions Henry. New screenshots are here:

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6127 To

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+2 Here is a screenshot from my dev box for the catalog/memz

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5967 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: A screenshot of the new web page with the JVM thread info is here:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6013 Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: A publicly available screenshot:

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6009 To unsubscribe,

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6009 To unsubscribe,

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/5710/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5731 To

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: Marcel, can you plz look at patch set 2 instead. Several things changed and

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 3: (2 comments) To answer Alex's question for alternatives to logging approaches. I would

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 3: (1 comment) I see a comment about removing BlockMetadataLoadStats but this is not

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (14 comments)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5710 to look at the new patch set (#5). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog ..

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 5: Code-Review+2 Rebase and carry Marcel's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5743/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: John, do we have a pdf from these sources? It helps immensely the review process of docs --

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6180 Change subject: IMPALA-4966: Add flatbuffers to build .. IMPALA-4966: Add flatbuffers to build FlatBuffers version 1.6.0 is

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/6013/2/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-03-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4966: Add flatbuffers to build .. Patch Set 2: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit http://gerrit.cloudera.org:8080/6180 To

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-03-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4420/2/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 4: (3 comments) Thanks for calling these out mikeb.

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 13: (15 comments)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 5: (13 comments) http://gerrit.cloudera.org:8080/#/c/4047/5/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4420 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 12: (10 comments)

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 10: (11 comments) Flushing some comments. Will focus on testing

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (94 comments) http://gerrit.cloudera.org:8080/#/c/4414/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (14 comments) Very nice! Minor nits in the code,

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. Patch Set 1: How come this discrepancy between Impala's and Hive's output wasn't caught

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/4860 Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. IMPALA-4374: Use new syntax for

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 1: (8 comments) Flushing some initial comments. Still need to wrap my head around

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 19: Code-Review+1 (8 comments) Minor fixes in the

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4869 To unsubscribe,

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment) Just flushing out one comment. Working on the rest of the comments.

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5026 Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column

  1   2   3   4   5   6   >