Re: [Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Henry Robinson
Oops, ignore the outdated PS2 comments. The PS6 ones are current though! On 17 April 2017 at 16:41, Henry Robinson (Code Review) wrote: > Henry Robinson has posted comments on this change. > > Change subject: IMPALA-2550: Switch to per-query

Re: [Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-08 Thread Henry Robinson
rrit-PatchSet: 11 > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-Owner: Henry Robinson > Gerrit-Reviewer: Henry Robinson > Gerrit-Reviewer: Matthew Jacobs > Gerrit-Reviewer: Tim Armstrong > Gerrit-HasComments: No > -- Henry Robinson Software Engineer Cloudera 415-994-6679

Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson
rg:8080/4445 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef > Gerrit-PatchSet: 5 > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-Owner: Henry Robinson > Gerrit-Reviewer: Henry Robin

Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson
SF/216/ > > -- > To view, visit http://gerrit.cloudera.org:8080/4445 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef > Gerrit-PatchSet: 5 > Gerrit-Project: Impala-ASF > Gerri

Re: [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-26 Thread Henry Robinson
t: 9 > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-Owner: stak...@cloudera.com > Gerrit-Reviewer: David Knupp > Gerrit-Reviewer: Michael Brown > Gerrit-Reviewer: Taras Bobrovytsky > Gerrit-Reviewer: stak...@cloudera.com > > -- > You received this message because you are subscribed to the Google Groups > "impala-cr" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to impala-cr+unsubscr...@cloudera.com. > For more options, visit https://groups.google.com/a/cloudera.com/d/optout. > -- Henry Robinson Software Engineer Cloudera 415-994-6679

Re: [Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson
Supposed to be a draft; will post the final patch in a short while. On 11 October 2016 at 16:44, Henry Robinson (Code Review) < ger...@cloudera.org> wrote: > Henry Robinson has uploaded a new patch set (#11). > > Change subject: IMPALA-2905: Handle coordinator fragment lifec

Re: [Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Henry Robinson
org:8080/settings > > > > Gerrit-MessageType: comment > > Gerrit-Change-Id: I9b688aa9e2423b0271c8891a983e5b22707d8dbc > > Gerrit-PatchSet: 2 > > Gerrit-Project: Impala-ASF > > Gerrit-Branch: master > > Gerrit-Owner: Lars Volker > > Gerrit-Reviewer: David Knupp

Re: [Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-25 Thread Henry Robinson
remaining inconsistencies. On 25 January 2017 at 19:18, Henry Robinson (Code Review) < ger...@cloudera.org> wrote: > Henry Robinson has uploaded a new patch set (#3). > > Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Stat

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/2/community.html File

[Impala-ASF-CR] IMPALA-3873: Add QueryStateAccessor

2016-09-13 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-3873: Add QueryStateAccessor .. Abandoned No time to work on this. Will pick up when I've implemented Marcel's suggestions as a comparison. -- To v

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

2016-09-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4080 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4428 Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. IMPALA-4138: Fix AcquireState() for

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (1 comment) Agree that this maybe isn't a fix so much

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4428/1/be/src

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4428/1/be/src

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called If

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
:8080/4428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson G

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
:8080/4428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson G

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4428/2/be/src

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-16 Thread Henry Robinson (Code Review)
cribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Rob

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity .. Patch Set 4: (2 comments) Rebased to include IMPALA_ASSERT_DEBUG_DEATH macro from trunk

[Impala-ASF-CR] IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state.

2016-09-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state. .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/4418/1/be/src/runtime

[Impala-ASF-CR] Remove Llama support.

2016-09-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4445 Change subject: Remove Llama support. .. Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of

[Impala-ASF-CR] Remove Llama support.

2016-09-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Llama support. .. Patch Set 1: Passed a core test run. -- To view, visit http://gerrit.cloudera.org:8080/4445 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4610: Remove Llama support. .. IMPALA-4610: Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of most excellent fancy

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4610: Remove Llama support. .. Patch Set 1: (4 comments) Matt's going to weigh in on what parts of the memory estimation path we can remove, depe

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#6). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift File

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 11: (16 comments) http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 12: > I'm not sure the extra complexity of the UI is worth it. Without the UI, we&#

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5971 Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. IMPALA-4905: Reduce coordinator lock contention in

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5971/1/be/src/runtime

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. IMPALA-4905: Reduce coordinator lock contention in RPC handler Fragment instances call

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. Patch Set 1: (1 comment) Changed how the logging works - it didn't quite work i

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-02-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5987 Change subject: IMPALA-4925: Cancel finstance if query has finished .. IMPALA-4925: Cancel finstance if query has finished This patch

[Impala-ASF-CR] Qualify min() in header

2017-02-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5991 Change subject: Qualify min() in header .. Qualify min() in header Change-Id: I840869bc2b8ffebc34f4bf4bbefe89976d4e54f2 --- M be/src

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 12: (16 comments) Getting closer now. http://gerrit.cloudera.org:8080/#/c/5792/12/be/src

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 1: (Sorry, should have also asked that you remove the line that Sailesh pointed

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 1: Code-Review+2 That compiler define is no longer relevant - it was removed

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: This is super useful. Could you post the screenshot somewhere that's publicly acces

[Impala-ASF-CR] IMPALA-4926: Upgrade LZ4 to 1.7.5

2017-02-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6030 Change subject: IMPALA-4926: Upgrade LZ4 to 1.7.5 .. IMPALA-4926: Upgrade LZ4 to 1.7.5 LZ4 has deprecated the method names

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (5 comments) this is pretty cool. Got a couple of suggestions about organisation and

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. Patch Set 2: Code-Review+1 lgtm - can you get Sailesh to check as well? -- To view, visit

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. Patch Set 2: Code-Review+2 That's what I meant, we're good to go. -- To view,

[Impala-ASF-CR] Three misc webpage changes

2017-02-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6045 Change subject: Three misc webpage changes .. Three misc webpage changes 1. Change the content width to 80% of the screen. Lots of our

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-16 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. Abandoned Abandon for now, pending some coordinator changes in another patch. -- To view, visit http

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6056/3/be/src/rpc/authentication.cc File be

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6056/3/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Anyone want to take a quick look at this? -- To view, visit http://gerrit.cloudera.org:8080/6045 To unsubscribe

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Thanks for the reviews! > seems fine but I don't really know jquery If it makes it easier, this is basic

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6149 Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler .. Remove Scheduler abstract interf

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler .. Patch Set 1: Although this patch looks big, the files are moved + clang-format

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 2: (11 comments) Just minor things. http://gerrit.cloudera.org:8080/#/c/6013/2/be/src/util

[native-toolchain-CR] IMPALA-4983: Compile LZ4 in release mode

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6164 Change subject: IMPALA-4983: Compile LZ4 in release mode .. IMPALA-4983: Compile LZ4 in release mode LZ4 was not compiled (apparently

[native-toolchain-CR] IMPALA-4983: Compile LZ4 in release mode

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4983: Compile LZ4 in release mode .. Patch Set 1: Code-Review+2 Verified+1 Carry +2 from Toolchain project. Verified by complete build. -- To view

[native-toolchain-CR] IMPALA-4983: Compile LZ4 in release mode

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4983: Compile LZ4 in release mode .. IMPALA-4983: Compile LZ4 in release mode LZ4 was not compiled (apparently ever?) with optimization enabled

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler .. Patch Set 2: (1 comment) I've reverted the renames, temporarily, for eas

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler .. Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler F

[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6165 Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags .. IMPALA-4983: Set toolchain version to include LZ4

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6166 Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes .. IMPALA-5001: Redownload dependencies if toolchain ID

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler .. Patch Set 3: Code-Review+2 Rebase, carry +2. -- To view, visit h

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6149/2/be/

[Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

2017-02-27 Thread Henry Robinson (Code Review)
ribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lar

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6166/1/bin/bootstrap_toolchain.py

[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags .. Patch Set 1: > I assume this has passed tests with the new lz4 bits? Basic tests pass.

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: Code-Review+2 (4 comments) Looks pretty good to me. http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6166/1/bin

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-02-27 Thread Henry Robinson (Code Review)
it-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs

[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags .. Patch Set 1: Confirmed that the perf regression is fixed. With IMPALA-5001 the steps aren&#

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 14: Code-Review+2 Discussed offline. I believe the out-of-the-box behaviour hasn't ch

[Impala-ASF-CR] IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

2017-02-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6190 Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order .. IMPALA-5005: Don't allow server to

[native-toolchain-CR] Bump breakpad upstream version

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Bump breakpad upstream version .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6213/2//COMMIT_MSG Commit Message: PS2, Line 7

[Impala-ASF-CR] IMPALA-4856: Port ImpalaInternalService to KRPC

2017-03-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5888/1/be/src/service/impala-internal

[native-toolchain-CR] IMPALA-5025: upgrade to binutils 2.26.1

2017-03-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6247 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

2017-03-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5027: make udf headers buildable externally .. Patch Set 1: Is it unreasonable to require C++11 support? I can see this becoming problematic with

[Impala-ASF-CR] Add min / max to histograms

2017-03-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6257 Change subject: Add min / max to histograms .. Add min / max to histograms Even 99.9th %-ile measurements can hide a single huge

[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup

2017-03-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 1: I don't fully understand the JNI model, but I'm wondering if this is exac

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-03-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Sounds good - I commented on the bugfix, hopefully we can get these both in quickly. -- To

[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup

2017-03-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 2: (1 comment) If you get rid of the local frame, do you still need to promote

[native-toolchain-CR] Add historical version for breakpad

2017-03-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add historical version for breakpad .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6271 To unsubscribe, visit http

[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup

2017-03-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 3: Code-Review+2 (1 comment) Thanks. This seems better as the amount of '

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6166 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4212: Add sink output expressions to explain output

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4212: Add sink output expressions to explain output .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4783 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4935 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5115 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/6013/3/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 3: (17 comments) Few stylistic comments. http://gerrit.cloudera.org:8080/#/c/6037/4/be/src/runtime

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: Even better - because the partition function definition would be a template (and therefore

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src

[Impala-ASF-CR] IMPALA-5041: AuthManager::Init() is not idempotent

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5041: AuthManager::Init() is not idempotent .. Patch Set 1: (5 comments) Thanks for doing this. http://gerrit.cloudera.org:8080/#/c/6333/1//COMMIT_MSG

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6372 Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 1: This passes a native-toolchain build. -- To view, visit http://gerrit.cloudera.org

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) Upgrade gflags and glog together, glog is

  1   2   3   4   5   6   7   8   9   10   >