[kudu-CR] [cmake modules] fix linker probing on macOS

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15107 ) Change subject: [cmake_modules] fix linker probing on macOS .. [cmake_modules] fix linker probing on macOS Fixed linkage on

[kudu-CR] [cmake modules] fix linker probing on macOS

2020-01-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15107 ) Change subject: [cmake_modules] fix linker probing on macOS .. Patch Set 3: Code-Review+2 Thanks for fixing this! I built with this on

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-01-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 12: (20 comments)

[kudu-CR] KUDU-3046: dfelake TabletServerQuiescingITest

2020-01-27 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15113 Change subject: KUDU-3046: dfelake TabletServerQuiescingITest .. KUDU-3046: dfelake TabletServerQuiescingITest The test was flaky for a

[kudu-CR] [tests] simpler wait-for-crash in TestFillMultipleDisks

2020-01-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15112 ) Change subject: [tests] simpler wait-for-crash in TestFillMultipleDisks .. Patch Set 1: Code-Review+2 Thanks for fixing that! -- To

[kudu-CR] KUDU-3046: deflake TabletServerQuiescingITest

2020-01-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15113 to look at the new patch set (#2). Change subject: KUDU-3046: deflake TabletServerQuiescingITest .. KUDU-3046:

[kudu-CR] KUDU-3046: deflake TabletServerQuiescingITest

2020-01-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15113 to look at the new patch set (#3). Change subject: KUDU-3046: deflake TabletServerQuiescingITest .. KUDU-3046:

[kudu-CR] [tests] simpler wait-for-crash in TestFillMultipleDisks

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15112 Change subject: [tests] simpler wait-for-crash in TestFillMultipleDisks .. [tests] simpler wait-for-crash in TestFillMultipleDisks I

[kudu-CR] KUDU-3046: deflake TabletServerQuiescingITest

2020-01-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15113 ) Change subject: KUDU-3046: deflake TabletServerQuiescingITest .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-3046: deflake TabletServerQuiescingITest

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15113 ) Change subject: KUDU-3046: deflake TabletServerQuiescingITest .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2971 p2: add basic protobuf msg .. Patch Set 12: Code-Review+1 -- To view, visit

[kudu-CR] [docs] curl in the list of packages for build-from-source

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15114 Change subject: [docs] curl in the list of packages for build-from-source .. [docs] curl in the list of packages for build-from-source

[kudu-CR] [tests] simpler wait-for-crash in TestFillMultipleDisks

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15112 ) Change subject: [tests] simpler wait-for-crash in TestFillMultipleDisks .. Patch Set 1: > Thanks for fixing that! Thank you for the

[kudu-CR] [tests] simpler wait-for-crash in TestFillMultipleDisks

2020-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15112 ) Change subject: [tests] simpler wait-for-crash in TestFillMultipleDisks .. [tests] simpler wait-for-crash in