[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+2 (1 comment) Fix the one misspelling and then forward my +2 and submit it. http://gerrit.cloudera.org:8080/#/c/12936/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12936/1//COMMIT_MSG@7 PS1, Line 7: bulding building -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 18:27:40 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: > Patch Set 1: Code-Review+1 > > I don't have the ability to test this since I used the workaround to install > the headers, but I am onboard with the fix. It could be worth backporting to > 1.9.x too. I tested it yesterday without the workaround, Will tested it with the workaround installed on his MacBook. -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 18:26:38 + Gerrit-HasComments: No
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+1 I don't have the ability to test this since I used the workaround to install the headers, but I am onboard with the fix. It could be worth backporting to 1.9.x too. -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 13:28:16 + Gerrit-HasComments: No
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Verified+1 unrelated Java flake in TSAN build -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 00:32:21 + Gerrit-HasComments: No
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has removed a vote on this change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Hello Will Berkeley, Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12936 to review the following change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave When macOS_SDK_headers_for_macOS_10.14 is installed setting the --sysroot to the default header location breaks the build, which is why there was a check whether /usr/include existed and only set --sysroot to the SDK path if it didn't. The problem with this is if something creates the /usr/include directory, the build will fail again. This commit changes the check to look for /usr/include/libc.h instead. Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/12936/1 -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit makes CMake locate the headers using "xcrun --show-sdk-path" and pass it to clang's sysroot. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Reviewed-on: http://gerrit.cloudera.org:8080/12054 Reviewed-by: Adar Dembo Tested-by: Attila Bukor --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Attila Bukor: Verified -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: it was verified to work with and without installing /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 21 Dec 2018 19:17:59 + Gerrit-HasComments: No
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 21 Dec 2018 19:17:17 + Gerrit-HasComments: No
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 5: Code-Review+2 Assuming it works... -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Mon, 10 Dec 2018 20:19:02 + Gerrit-HasComments: No
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. (
http://gerrit.cloudera.org:8080/12054 )
Change subject: [build] Fix bulding codegen on MacOS Mojave
..
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@74
PS3, Line 74:
> Hmm OK.
Done
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@96
PS4, Line 96: # [1]
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes
: if (APPLE AND NOT EXISTS /usr/include)
> Nit: combine onto one line:
Done
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@98
PS4, Line 98: ECUTE_P
> Don't need this inner set of parens.
Done
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@105
PS4, Line 105: --sysroot="${SDKPATH}")
: endif()
> Nit: indentation (see L84).
Done
--
To view, visit http://gerrit.cloudera.org:8080/12054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Sat, 08 Dec 2018 11:24:29 +
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has removed a vote on this change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#5). Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit makes CMake locate the headers using "xcrun --show-sdk-path" and pass it to clang's sysroot. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/5 -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/12054 )
Change subject: [build] Fix bulding codegen on MacOS Mojave
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@74
PS3, Line 74:
> no, it seems it breaks stuff when the workaround is implemented (at least p
Hmm OK.
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@96
PS4, Line 96: # [1]
: #
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes
Nit: combine onto one line:
1. https://developer.apple.com/...
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@98
PS4, Line 98: (APPLE)
Don't need this inner set of parens.
http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@105
PS4, Line 105: ${IR_FLAGS}
: --sysroot="${SDKPATH}")
Nit: indentation (see L84).
--
To view, visit http://gerrit.cloudera.org:8080/12054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Sat, 08 Dec 2018 00:25:22 +
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@73 PS3, Line 73: endif() > Once this is working we'll need a big block comment here explaining what's Done http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@74 PS3, Line 74: > Isn't the below correct to do regardless of whether /usr/include exists? no, it seems it breaks stuff when the workaround is implemented (at least patch set #2 broke Grant's build and that was the difference) http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@82 PS3, Line 82: > I guess this is fine if it works, but isn't -I sufficient? I'm reading thro I tried with -I first and it didn't work that way for some reason. http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@95 PS3, Line 95: # > If you go down the --sysroot path, I think I'd prefer adding it directly to Done -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 07 Dec 2018 20:57:40 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#4). Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit makes CMake locate the headers using "xcrun --show-sdk-path" and pass it to clang's sysroot. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/4 -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/12054 )
Change subject: [build] Fix bulding codegen on MacOS Mojave
..
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@73
PS3, Line 73:
Once this is working we'll need a big block comment here explaining what's
going on.
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@74
PS3, Line 74: if (NOT EXISTS /usr/include)
Isn't the below correct to do regardless of whether /usr/include exists?
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@82
PS3, Line 82: --sysroot="${SDKPATH}")
I guess this is fine if it works, but isn't -I sufficient? I'm reading through
https://clang.llvm.org/docs/CrossCompilation.html.
http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@95
PS3, Line 95: set(IR_FLAGS
If you go down the --sysroot path, I think I'd prefer adding it directly to
IR_FLAGS rather than to PREFIXED_IR_INCLUDES, because strictly speaking it's
not an "include"; it's an additional configuration for clang.
--
To view, visit http://gerrit.cloudera.org:8080/12054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Fri, 07 Dec 2018 18:18:46 +
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#3). Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit makes CMake locate the headers using "xcrun --show-sdk-path" and pass it to clang's sysroot. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/3 -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12054 to look at the new patch set (#2). Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit makes CMake locate the headers using "xcrun --show-sdk-path" and pass it to clang's sysroot. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/2 -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Hello Will Berkeley, Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12054 to review the following change. Change subject: [build] Fix bulding codegen on MacOS Mojave .. [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit locates the headers using "xcrun --show-sdk-path" and passes this path as "--sysroot" to clang. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/1 -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Will Berkeley
