[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/17912 )
Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'.
..
Patch Set 13:
(1 comment)
I'm late to reviewing this change, but I spotted an ABI-breaking change in this
patch. I guess we need to revert this.
http://gerrit.cloudera.org:8080/#/c/17912/13/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/17912/13/src/kudu/client/client.h@748
PS13, Line 748: const std::string& filter = "");
:
: struct KUDU_EXPORT ListTableInfo {
: std::string table_name;
: uint64_t live_row_count;
: int num_tablets;
: int num_replicas;
: };
: /// List only those tables whose names pass a substring match
on @c filter.
: ///
: /// @param [out] list_table_infos
: /// The placeholder for the result. Appended only on
success.
: /// @param [in] filter
: /// Substring filter to use; empty sub-string filter
matches all tables.
: /// @return Status object for the operation.
: Status ListTables(std::vector*
list_table_infos,
: const std::string& filter = "");
This change isn't ABI compatible and should be reverted. For API
compatibility, see
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
--
To view, visit http://gerrit.cloudera.org:8080/17912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f
Gerrit-Change-Number: 17912
Gerrit-PatchSet: 13
Gerrit-Owner: yejiabao
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: yejiabao
Gerrit-Comment-Date: Mon, 25 Oct 2021 23:39:19 +
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Reviewed-on: http://gerrit.cloudera.org:8080/17912 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 101 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 13 Gerrit-Owner: yejiabao Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 12 Gerrit-Owner: yejiabao Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao Gerrit-Comment-Date: Thu, 21 Oct 2021 17:28:13 + Gerrit-HasComments: No
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#12). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 101 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/12 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 12 Gerrit-Owner: yejiabao Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#11). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 101 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/11 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 11 Gerrit-Owner: yejiabao Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/master/master.proto@597 PS10, Line 597: record_number nit: Maybe use x_count instead of x_number for better clarity? http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/tool_action_table.cc@107 PS10, Line 107: like tablet number nit: maybe replace it with "such as number of tablets"? Same with replica number and record number -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 10 Gerrit-Owner: yejiabao Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao Gerrit-Comment-Date: Thu, 21 Oct 2021 04:26:51 + Gerrit-HasComments: Yes
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/17912 )
Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'.
..
Patch Set 10:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.h@758
PS10, Line 758: list_table_info
The parameter name must match.
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.cc
File src/kudu/client/client.cc:
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.cc@614
PS10, Line 614: for (int i = 0; i < resp.tables_size(); i++) {
: const auto& table = resp.tables(i);
Better to use for range loop with resp.tables instead.
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.cc@621
PS10, Line 621: list_table_infos->push_back(list_table_info);
emplace_back(std::move(list_table_info))
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/kudu-tool-test.cc@4093
PS10, Line 4093: int
const int kReplicaNum
--
To view, visit http://gerrit.cloudera.org:8080/17912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f
Gerrit-Change-Number: 17912
Gerrit-PatchSet: 10
Gerrit-Owner: yejiabao
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: yejiabao
Gerrit-Comment-Date: Wed, 20 Oct 2021 18:14:41 +
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#10). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 102 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/10 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 10 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#9). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 102 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/9 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 9 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#8). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 103 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/8 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 8 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/17912 )
Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'.
..
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/client/client.h@750
PS7, Line 750: struct KUDU_EXPORT ListTableInfo {
: std::vector table_names;
: std::vector record_numbers;
: std::vector tablet_numbers;
: std::vector replica_numbers;
: };
Instead of separate vectors for each field, need a structure that encapsulates
all fields related to a table and then a vector of that structure.
Like
struct TableInfo {
std::string table_name;
uint64_t record_number;
int tablet_number;
int replica_number;
}
vector list_table_info
http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/master/master.proto@597
PS7, Line 597: required uint64 record_number = 3;
: required int32 tablet_number = 4;
: required int32 replica_number = 5;
These new fields need to be optional.
http://gerrit.cloudera.org:8080/#/c/17912/6/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/17912/6/src/kudu/tools/kudu-tool-test.cc@4166
PS6, Line 4166: expected.push_back(Substitute("$0 Tablet_N:1 Replica_N:$1
Record_N:0",
> warning: 'push_back' is called inside a loop; consider pre-allocating the v
This is a reasonable comment from the bot. Please consider incorporating it.
http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:
http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/tools/tool_action_table.cc@107
PS7, Line 107: tablet numbe
Include statistics like tablet number,
--
To view, visit http://gerrit.cloudera.org:8080/17912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f
Gerrit-Change-Number: 17912
Gerrit-PatchSet: 7
Gerrit-Owner: yejiabao
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: yejiabao
Gerrit-Comment-Date: Mon, 18 Oct 2021 18:37:02 +
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
yejiabao has abandoned this change. ( http://gerrit.cloudera.org:8080/17938 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/17938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4d7194c60ff458ea05cf1c7e4a2a271e0643893e Gerrit-Change-Number: 17938 Gerrit-PatchSet: 1 Gerrit-Owner: yejiabao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#7). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 97 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/7 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 7 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
yejiabao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17938 Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I4d7194c60ff458ea05cf1c7e4a2a271e0643893e --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 97 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/17938/1 -- To view, visit http://gerrit.cloudera.org:8080/17938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4d7194c60ff458ea05cf1c7e4a2a271e0643893e Gerrit-Change-Number: 17938 Gerrit-PatchSet: 1 Gerrit-Owner: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#6). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScannerPrefetching.java M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 8 files changed, 487 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/6 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 6 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#5). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 98 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/5 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 5 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#4). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 98 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/4 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 4 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#3). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 99 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/3 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 3 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
yejiabao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. Patch Set 2: > We already have "kudu table statistics. Do we still need statistics > to be listed as part of "kudu table list"? > > https://kudu.apache.org/docs/command_line_tools_reference.html#table-statistics yes, i known this, but i find 'kudu table statistics' just get a table at a time，and in 'kudu table list’we can get all tables, so i think this patch can make easy to know one or more just you want the tables detail infos -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 2 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao Gerrit-Comment-Date: Thu, 14 Oct 2021 14:18:36 + Gerrit-HasComments: No
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 ) Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. Patch Set 2: We already have "kudu table statistics. Do we still need statistics to be listed as part of "kudu table list"? https://kudu.apache.org/docs/command_line_tools_reference.html#table-statistics -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 2 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 11 Oct 2021 19:14:54 + Gerrit-HasComments: No
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17912 to look at the new patch set (#2). Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 95 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/2 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 2 Gerrit-Owner: yejiabao Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.
yejiabao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17912 Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. .. [tool] Add a '-list_statistics' flag to the 'kudu table list'. '-list_statistics' flag can help to list table's statistics such as tablet number, replica number, and record number Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 94 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/1 -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 1 Gerrit-Owner: yejiabao
