[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 5: > I'm going to push even though Tidy Bot flagged another warning. It > did so because you modified the

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [util] minor clean-up on kudu::Subprocess .. [util] minor clean-up on kudu::Subprocess Do not call CHECK_EQ() in case where it's possible to report on erro

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 4: Code-Review+2 I'm going to push even though Tidy Bot flagged another warning. It did so because you modif

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4502 to look at the new patch set (#4). Change subject: [util] minor clean-up on kudu::Subprocess .. [util] minor clean-

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4502 to look at the new patch set (#3). Change subject: [util] minor clean-up on kudu::Subprocess .. [util] minor clean-

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4502/2/src/kudu/benchmarks/tpch/tpch_real_world.cc Fi

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4502/2/src/kudu/benchmarks/tpch/tpch_real_world.cc File

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-23 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4502 to look at the new patch set (#2). Change subject: [util] minor clean-up on kudu::Subprocess .. [util] minor clean-

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/sub

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] minor clean-up on kudu::Subprocess .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4502/1/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [util] minor clean-up on kudu::Subprocess

2016-09-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4502 Change subject: [util] minor clean-up on kudu::Subprocess .. [util] minor clean-up on kudu::Subprocess Do not call CHECK_EQ() in case wh