[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Fix kudu-ts-cli crash when there is no data in tablet NULL pointer was being sent in as an

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4134 To unsubscribe, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/10/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#11). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/3202/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/10/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: (13 comments) TFTR folks, updated the diffs after a round of testing again. This addresses

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#10). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/3191/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: (6 comments) Ugh, I forgot to publish the comments I had last night. I think Todd ended up

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/9/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3188/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#9). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 8: (3 comments)

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#8). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3185/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/4134/7/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3180/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: > Subprocess::Call has optional out-parameters for stdout/stderr so > you can capture it

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3161/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#7). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Code-Review+1 Code LGTM, but I agree that a test would be nice. -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Subprocess::Call has optional out-parameters for stdout/stderr so you can capture it and

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: > Code change looks good, but how about a test in kudu-ts-cli-test? Yess, thought about

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Code change looks good, but how about a test in kudu-ts-cli-test? -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3131/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#6). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#5). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3130/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 4: (5 comments) TFTR Alexey/Todd, please see response inlined.

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-28 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3127/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-28 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#4). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-28 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3126/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-28 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#3). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#2). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3091/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3090/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4134 to review the following change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet