[kudu-CR] Avoid unused var warning in deltafile-test.cc

2016-06-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3288 Change subject: Avoid unused var warning in deltafile-test.cc .. Avoid unused var warning in deltafile-test.cc Now that in memory

[kudu-CR] Don't default 'request' to null in WriteTransactionState's ctor

2016-06-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3290 Change subject: Don't default 'request' to null in WriteTransactionState's ctor .. Don't default 'request' to null in

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) Add weekly update for 06/06

2016-06-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3316 To unsubscribe, visit

[kudu-CR](gh-pages) Add weekly update for 06/06

2016-06-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3316/1/_posts/2016-06-06-weekly-update.md File

[kudu-CR](gh-pages) Add weekly update for 06/06

2016-06-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add weekly update for 06/06 .. Patch Set 2: Code-Review+2 (1 comment) lgtm, fix the nit if you think it's worth it.

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: (1 comment) can you add a test for this? something simple like setting the

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Patch Set 2: where is this used? -- To view, visit http://gerrit.cloudera.org:8080/3345 To unsubscribe,

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 3: general wondering. Should we just kill the consensus.h interface and refactor

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 3: yeah was not saying that we needed to do it here. Not sure there is much to discuss though,

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: Code-Review+2 Ran the tests in my mac. When running on ctest all tests that injected

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Do not run (g)addr2line translator on MacOS X .. Do not run (g)addr2line translator on MacOS X When running tests on MacOS X, omit using the

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#3). Change subject: Allow to set RequestId in the RPC RequestHeader .. Allow to set

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 6: (1 comment) This is still missing a parallel test for the failure

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 3: Verified+1 unrelated java failure -- To view, visit http://gerrit.cloudera.org:8080/3179

[kudu-CR] Add unique id generation to the client

2016-05-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add unique id generation to the client .. Add unique id generation to the client This adds unique id generation to the client, which takes the

[kudu-CR] catalog manager: fix a locking error

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: catalog_manager: fix a locking error .. Patch Set 2: Code-Review+2 yeah, brain fart seemed a bit too much :) -- To view, visit

[kudu-CR] Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix stray memory writes due to tcmalloc profiling .. Patch Set 1: Code-Review+2 good catch -- To view, visit http://gerrit.cloudera.org:8080/3445 To

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3344 To

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 4: (3 comments)

[kudu-CR] Remove the LocalConsensus implementation

2016-06-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3350/5/src/kudu/consensus/metadata.proto File

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: Verified+1 unrelated failure on

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Mark the Response accessors in transactions/transaction's state const .. Mark the Response accessors in transactions/transaction's state const

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: was looking into updating gmock and it seems like it has moved to a

[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: catalog_manager: fix a locking brain fart .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3425/1//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project. ..

[kudu-CR] WIP: Exactly once semantics for writes

2016-06-17 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3403 to look at the new patch set (#3). Change subject: WIP: Exactly once semantics for writes .. WIP: Exactly once

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 12: Verified+1 (12 comments)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 13: Verified+1 unrelated flake ReplicatedAlterTableTest.TestReplicatedAlter --

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#12). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-06-22 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#9). Change subject: Allow to set RequestId in the RPC RequestHeader ..

[kudu-CR] Integrate the request tracker with the client

2016-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3080/8//COMMIT_MSG Commit Message: Line

[kudu-CR](branch-0.9.x) catalog manager: fix a locking error

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: catalog_manager: fix a locking error .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3461 To unsubscribe, visit

[kudu-CR] KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 13: (24 comments)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 12: (1 comment)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#13). Change subject: Add a ResultTracker class that will track server side results

[kudu-CR] Integrate the result tracker with writes

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 1: this is good to be reviewed, but it's still missing a flag to disable it until we've finished

[kudu-CR] Integrate the result tracker with writes

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 1: Verified+1 unrelated flake org.kududb.client.TestTimeouts.org.kududb.client.TestTimeouts -- To

[kudu-CR] WIP: Exactly once semantics for writes

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: WIP: Exactly once semantics for writes .. Abandoned superceded by other patches -- To view, visit http://gerrit.cloudera.org:8080/3403 To unsubscribe, visit

[kudu-CR] Integrate the result tracker with writes

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3449 Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the

[kudu-CR] Integrate the request tracker with the client

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#8). Change subject: Integrate the request tracker with the client .. Integrate the request tracker with the client This integrates the request tracker with the client, making

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 6: (2 comments) bq. wonder whether it would be a clearer API to instead have a flag like

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#4). Change subject: Allow to set RequestId in the RPC RequestHeader .. Allow to set

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#8). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: we can will do (disregard the update of this patch) -- To view,

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#7). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Clarify the different between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3409 Change subject: Clarify the different between 'call_id' and 'request_id' .. Clarify the different between 'call_id' and

[kudu-CR] Make 'num attempts' in RequestIdPB required

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3408 Change subject: Make 'num_attempts' in RequestIdPB required .. Make 'num_attempts' in RequestIdPB required Differentiating which

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#7). Change subject: Add a RpcContext::RespondFailure() method .. Add a

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3179/3/src/kudu/rpc/rpc_controller.h File

[kudu-CR] Allow crcutil* symbols in the client

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow crcutil* symbols in the client .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map File

[kudu-CR] Allow crcutil* symbols in the client

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow crcutil* symbols in the client .. Patch Set 3: don't follow, isn't it ok if it follows this one on the sequence? -- To view, visit

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#5). Change subject: Allow to set RequestId in the RPC RequestHeader ..

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#9). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Allow crcutil* symbols in the client

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3412 Change subject: Allow crcutil* symbols in the client .. Allow crcutil* symbols in the client A previous patch moved PB tracing

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#9). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] Allow crcutil* symbols in the client

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3412 to look at the new patch set (#4). Change subject: Allow crcutil* symbols in the client .. Allow crcutil* symbols

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#10). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#10). Change subject: Add a ResultTracker class that will track server side results

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 5: Verified+1 unrelated flake

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3409 to look at the new patch set (#3). Change subject: Clarify the difference between 'call_id' and 'request_id' ..

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 2: (1 comment)

[kudu-CR] Make 'num attempts' in RequestIdPB required

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3408 to look at the new patch set (#3). Change subject: Make 'num_attempts' in RequestIdPB required .. Make

[kudu-CR] Make 'num attempts' in RequestIdPB required

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make 'num_attempts' in RequestIdPB required .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3408/2//COMMIT_MSG Commit Message: Line 15:

[kudu-CR] Allow crcutil* symbols in the client

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow crcutil* symbols in the client .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3412/3/src/kudu/client/symbols.map File

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#7). Change subject: Allow to set RequestId in the RPC RequestHeader ..

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#10). Change subject: Add a RpcContext::RespondFailure() method .. Add a

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#11). Change subject: Add a ResultTracker class that will track server side results

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 10: Verified+1 unrelated flake MasterTest.TestMasterMetadataConsistentDespiteFailures -- To view,

[kudu-CR] Make 'num attempts' in RequestIdPB required

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3408 to look at the new patch set (#4). Change subject: Make 'num_attempts' in RequestIdPB required .. Make

[kudu-CR] Make 'num attempts' in RequestIdPB required

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make 'num_attempts' in RequestIdPB required .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3408/2//COMMIT_MSG Commit Message: Line 15:

[kudu-CR] Allow crcutil* symbols in the client

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Allow crcutil* symbols in the client .. Allow crcutil* symbols in the client A previous patch moved PB tracing utilities into pb_util.cc/h but in

[kudu-CR] Make 'num attempts' in RequestIdPB required

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Make 'num_attempts' in RequestIdPB required .. Make 'num_attempts' in RequestIdPB required We need to differentiate between attempts, on the

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 4: (2 comments)

[kudu-CR](gh-pages) Add blog post about removing LocalConsensus

2016-06-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add blog post about removing LocalConsensus .. Patch Set 1: (3 comments)

[kudu-CR] WIP: Exactly once semantics for writes

2016-06-17 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3403 to look at the new patch set (#2). Change subject: WIP: Exactly once semantics for writes .. WIP: Exactly once

[kudu-CR] alter schema transaction: don't crash in ToString() when no timestamp

2016-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: alter_schema_transaction: don't crash in ToString() when no timestamp .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#12). Change subject: Integrate the request tracker with the client .. Integrate the

[kudu-CR] Integrate the result tracker with writes

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#5). Change subject: Integrate the result tracker with writes .. Integrate the

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3506 to look at the new patch set (#3). Change subject: Disable exactly once semantics by default and add a flag to enable it for tests

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3504 To

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 2: unrelated flake

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3517/1/docs/release_notes.adoc File

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#13). Change subject: Integrate the request tracker with the client .. Integrate the

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 11: (1 comment)

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings in raft_consensus-test.cc In this test

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: (1 comment)

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3505 to look at the new patch set (#5). Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 2: Code-Review+2 thanks for adding the additional info -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3519 Change subject: WIP: Integration test for replay cache .. WIP: Integration test for replay cache This adds a new integration test

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-06-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3506 to look at the new patch set (#5). Change subject: Disable exactly once semantics by default and add a flag to enable it for tests

[kudu-CR] Integrate the result tracker with writes

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#7). Change subject: Integrate the result tracker with writes .. Integrate the

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings in raft_consensus-test.cc In

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#16). Change subject: Integrate the ResultTracker into the rpc subsystem ..

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#14). Change subject: Add a ResultTracker class that will track server side results .. Add a ResultTracker class that will track server side results This adds the initial

[kudu-CR] Integrate the result tracker with writes

2016-06-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions,

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

2016-06-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3503 Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Add information about Exactly Once RPC semantics to

[kudu-CR] Remove the LocalConsensus implementation

2016-06-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3350 To unsubscribe, visit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 6: (4 comments)

  1   2   3   4   >